Commits · 5f61be2274f0d1303782050720605ffa7d6cc59e · Vincent Pelletier / neoppod

05 Feb, 2010 7 commits

Grégory Wisniewski authored Feb 05, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1644 71dcc9de-d417-0410-9af5-da40c76e7ee4

5f61be22

Revert "There is at most one iteration that match, break when found." · 333003cc
Grégory Wisniewski authored Feb 05, 2010
```
This reverts commit r1630.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1643 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
333003cc

Remove useless method override. · a3b706aa

Grégory Wisniewski authored Feb 05, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1642 71dcc9de-d417-0410-9af5-da40c76e7ee4

a3b706aa

Do not give a new instance in 'dict.setdefault'. · 46390f7c

Grégory Wisniewski authored Feb 05, 2010

This create an object each time a transaction or object is stored, even if the entry is found in the dictionnary.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1641 71dcc9de-d417-0410-9af5-da40c76e7ee4

46390f7c

Remove this unimplemented test. · d9e19865

Grégory Wisniewski authored Feb 05, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1640 71dcc9de-d417-0410-9af5-da40c76e7ee4

d9e19865

Unify comparison order. · 138a8b34

Grégory Wisniewski authored Feb 05, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1639 71dcc9de-d417-0410-9af5-da40c76e7ee4

138a8b34

Remove a bug entry fixed in r1632. · d0d85628

Grégory Wisniewski authored Feb 05, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1638 71dcc9de-d417-0410-9af5-da40c76e7ee4

d0d85628

04 Feb, 2010 10 commits

Notify the dropped node that it is down before close the connection. · 87ea823f

Grégory Wisniewski authored Feb 04, 2010

This ensure it will not reappear in pending state.
Explain why the connection is closed by the master rather than wait for a remote closure.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1637 71dcc9de-d417-0410-9af5-da40c76e7ee4

87ea823f

Use asTuple provide by Node class. · a3c67575

Grégory Wisniewski authored Feb 04, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1636 71dcc9de-d417-0410-9af5-da40c76e7ee4

a3c67575

Raise if the locking/unlocking transaction is unknown. · 704ff1af
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1635 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
704ff1af

Use 'self.app' directly. · 924c2f7e

Grégory Wisniewski authored Feb 04, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1634 71dcc9de-d417-0410-9af5-da40c76e7ee4

924c2f7e

A transaction must have been started when lock/unlock is received. · 46eeac6f
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1633 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
46eeac6f

Bug fix: Don't drop transaction information when locked. · 66ef9bed

Grégory Wisniewski authored Feb 04, 2010

If a client node disconnect from storage node right after send 'finishTransaction' to the primary master, then the storage clear it's related information and can not store them later in the database, when notifyUnlockInformation is received from the master.
Here the transaction object got a new attribute '_locked' set when the storage receive the 'lockInformation' from the master, meaning that the client is finish it's transaction.
If locked, the transaction is not cleared when the client disconnect from storage node.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1632 71dcc9de-d417-0410-9af5-da40c76e7ee4

66ef9bed

Try executed pending events only if something has changed. · feea26c9
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1631 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
feea26c9
There is at most one iteration that match, break when found. · 5d9248b6
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1630 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5d9248b6
Add a bug entry related to transaction manager from storage side. · defcca90
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1629 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
defcca90
Remove unexplained try/except/pass statements. · d3869809
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1628 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d3869809

03 Feb, 2010 23 commits
- Rewrite of client's master handler tests. · 43b1e494
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1627 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  43b1e494
- Rewrite of client's master handler tests. · 7b86a853
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1626 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  7b86a853
- Split client's handlers test module in two. · 57f41fbd
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1625 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  57f41fbd
- Check 'tid' parameter, must match with current transaction. · 320e4f54
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1624 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  320e4f54
- Raise if a TransactionFinished packet contains a wrong TID. · 00f89a53
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1623 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  00f89a53
- Few accesses to 'app', don't get intermediate variable. · c7deb039
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1622 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  c7deb039
- Client handlers take dispatcher reference from app. · 31087cad
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1621 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  31087cad
- Fix handling of notifyNodeInformation in client side. · c2088712
  Grégory Wisniewski authored Feb 03, 2010
```
Cut the connection to non-running nodes and remove it from pool in case of storage nodes.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1620 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  c2088712
- Add a comment to explain a try/except/pass · 6755bd49
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1619 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  6755bd49
- Fix the meaning of a comment. · 8f3889eb
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1618 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  8f3889eb
- Only a primary master is binded to this handler. · 68972dad
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1617 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  68972dad
- Unknown master nodes must not be accepted. · 946faf6f
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1616 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  946faf6f
- A master node must always supply an UUID to the accepted client. · 568e83bc
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1615 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  568e83bc
- Retreive the node after check basics requirements. · 00ab5bff
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1614 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  00ab5bff
- Log notifyNodeInformation packet content. · 5e799d01
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1613 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  5e799d01
- expectAssignedCells now takes the process as parameter instead of UUID. · deeb6b2c
  Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1612 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  deeb6b2c
- Simplify a "if: pass else: ..." block. · 49b6acad
  Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1611 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  49b6acad
- Add XXX near lock release which doesn't check who owns the lock. · 47c4926f
  Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1610 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  47c4926f
- Add TODOs near possibly abusive "try:..except..: pass" blocks. · 1b412591
  Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1609 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  1b412591
- Simplify loop exit logic. · af907e65
  Vincent Pelletier authored Feb 03, 2010
```
Also, don't add 10 to "t" on each iteration.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1608 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  af907e65
- Get rid of a try:..except: pass. · 6961628f
  Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1607 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  6961628f
- Get rid of empty BaseStorageHandler class. · 87ea655c
  Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1606 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  87ea655c
- Add an XXX about master shutdown code for later review. · 3353d4db
  Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1605 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  3353d4db