- 24 Mar, 2023 4 commits
-
-
Rafael Monnerat authored
Allow the developer associate a Mixin on Business template level without require to overwrite the portal type itself Include mixins can be done in the same way, allowed content types or property sheets are set.
-
Jérome Perrin authored
After updating Products.CMFCore we had issues on sites where URLTool was registered as ISiteRoot. In the case of ERP5, we don't really need portal_url.getPortalObject(), this changes to use ERP5Site.getPortalObject(), while at the same time doing something so that portal_url.getPortalObject() also works. See https://github.com/zopefoundation/Products.CMFCore/pull/126 for more details See merge request nexedi/erp5!1758
-
Jérome Perrin authored
this is a "magic" local variable used to add more debugging information in zope traceback, it's not supposed to be used directly so it was a false positive in our case. This extends the default value of --dummy-variable-rgx that was defined to _$|dummy in pylint 1.4.4 ( https://github.com/PyCQA/pylint/blob/pylint-1.4.4/pylint/checkers/variables.py#L296 )
-
Jérome Perrin authored
This can happen when request is used as a cache storage, especially after eab00f14 (deferred_style: Properly keep request parameters, 2021-03-10)
-
- 20 Mar, 2023 11 commits
-
-
Rafael Monnerat authored
See merge request nexedi/erp5!1756
-
Jérome Perrin authored
Products.CMFCore's version 2.7.0 of portal_url.getPortalObject returns the portal in an incomplete acquisition context, which causes issues when the site is registered as ISiteRoot utility (the typical error being AttributeError REQUEST) ERP5Site.getPortalObject works just fine and is used in many places, this commit replaces all occurences of portal_url.getPortalObject by getPortalObject.
-
Jérome Perrin authored
and adjust the test for better python3 compatibility
-
Jérome Perrin authored
we don't use these
-
Jérome Perrin authored
This TALES is complex, especially if we need to support python3 as well
-
Jérome Perrin authored
Some old ERP5 site were registered as ISiteRoot and this cause issues with Products.CMFCore update 2.2.10 -> 2.7
-
Jérome Perrin authored
-
Jérome Perrin authored
this interaction adjust membership criterions when variation categories is changed, but we don't really need security restriction in the interaction, because security is already checked when setting variation categories.
-
Jérome Perrin authored
This factorize code and fix a problem that when the variation category was a Category from the same variation base category, we had the base category twice ( something like group/group/nexedi )
-
Jérome Perrin authored
We have been using scripts returning categories but it was missing in the relation field.
-
Jérome Perrin authored
otherwise it is acquired from BudgetLine, which is bad because: - the value of catalog.has_cell_content will be wrong - hasCellContent is slow and this was called for all cells in a budget line
-
- 19 Mar, 2023 3 commits
-
-
Levin Zimmermann authored
/reviewed-on nexedi/erp5!1757
-
Levin Zimmermann authored
In nexedi/erp5@79fa584e we moved some security definition from wendelin to erp5, but we didn't add any tests anywhere. Recent project based tests revealed that this migration actually failed [1]. We should therefore add a test for this. [1] nexedi/wendelin@f8678468 (comment 181134) /reviewed-on nexedi/erp5!1757
-
Arnaud Fontaine authored
This reduces dependency on DCWorkflow and cleanup StateChangeInfo monkey patch.
-
- 17 Mar, 2023 8 commits
-
-
Rafael Monnerat authored
It the user don't have fully permission on the object (already changed state), this set will fail to check if source should be defined.
-
Rafael Monnerat authored
See merge request nexedi/erp5!1537
-
Arnaud Fontaine authored
And the Product was removed in recent ERP5 SR.
-
Jérome Perrin authored
This patch seems not needed
-
Jérome Perrin authored
-
Jérome Perrin authored
This is in SyncMLUtils
-
Jérome Perrin authored
Now this is defined from new workflows, we no longer need the DCWorkflow version
-
Jérome Perrin authored
This was only useful during the transition to ERP5 Workflow, now that workflows are migrated, Category API (setDestination) is more natural, so there's no reason to keep this patch
-
- 16 Mar, 2023 5 commits
-
-
Rafael Monnerat authored
-
Romain Courteaud authored
Conflicts: bt5/erp5_crm/bt/revision
-
Alain Takoudjou authored
-
Jérome Perrin authored
Test setup monkey-patched some function which we removed when merging Zope4 support. This function was used in translationContext, it was working fine in the tests, because the function was here thanks to the monkey-patch, but it failed with ImportError when used for real. This fixes the import to use the real getRequest and drop the patch to prevent similar problems.
-
Jérome Perrin authored
According to https://www.legifrance.gouv.fr/codes/article_lc/LEGIARTI000027804775/ ValidDate is the date when the transaction was validated ( "16. La date de validation de l'écriture comptable"), this implementation was simply returning the modification date, which was not always correct, for example after causality state was recaculated. This keeps the `getModificationDate` fallback for cases where FEC is used with some non validated transactions, in order to keep compatibility
-
- 15 Mar, 2023 9 commits
-
-
Rafael Monnerat authored
On the implementation 0 dont set stop date on the Assignment
-
Rafael Monnerat authored
If preferences sets a negative duration, don't set stop/start dates on assignments.
-
Rafael Monnerat authored
See merge request !1754
-
Jérome Perrin authored
This fixes some regressions introduced by nexedi/erp5!1545 when searching the catalog for non ascii text See merge request nexedi/erp5!1752
-
Jérome Perrin authored
Using unicode with a catalog key or related key got broken in the merge of zope4 support, but using unicode on a translated key (such as translated_portal_type or translated_validation_state_title) was not working before.
-
Jérome Perrin authored
-
Jérome Perrin authored
it supports text, but unless they have non-ASCI characters, so it's better to always pass bytes.
-
Jérome Perrin authored
In original Products.ZSQLMethods, this is text, we want to keep the same semantics and encode only at a lower level.
-
Jérome Perrin authored
MySQLdb's string_literal is a method from the C API and the name is not natural for python programmers, because it manipulates bytes. It supports str, unless they have non ASCII characters, so it's better to always pass bytes. On python2, this change repairs a regression visible when searching catalog with translated related keys. This regression was introduced in the merge of zope4 support, more specifically with 610972af (py3: Update Shared.DC.ZRDB.{sqltest,sqlvar} monkey patches., 2022-04-16), because with the new version of the patches this method gets passed unicode strings, which is fine, unless they contain non ASCII characters.
-