1. 17 Feb, 2020 5 commits
    • Xiaowu Zhang's avatar
    • Jérome Perrin's avatar
      CodingStyleTestCase: check rebuilding tested BT to catch packaging problems · cc7b8d71
      Jérome Perrin authored
      This test should catch when business templates metadata in `bt/` is different from the actual content in `*TemplateItem/` . It should not happen, but sometimes we can forgot to include one or the other in commit.
      
      This also fixes problems in the currently tested business templates, there was three kind of problems:
       * binary files are now exported with `bin` extension, it use to be `obj`.
       * In several business templates, we export categories as `portal_categories/category/*`, while this looks convenient, it's problematic when categories are added by other business templates, every time developer export the business template they have to consider whether the new paths should be exported or not. This changed to list explicitly all the paths to include in business template.
       * some business templates were partially commited ( "erp5_dms_ui_test:  Add selenium tests" )
      
      /reviewed-on nexedi/erp5!1049
      cc7b8d71
    • Jérome Perrin's avatar
      Bank reconciliation cleanups · 3d03d158
      Jérome Perrin authored
      Make it pass coding style
      
      "Hide" an action that is not really useful and problematic when used by mistake
      
      /reviewed-on nexedi/erp5!1051
      3d03d158
    • Jérome Perrin's avatar
      TextDocument: lazily convert substitution mapping to unicode · 5016f968
      Jérome Perrin authored
      This way, the substitution mapping method can return a dynamic mapping,
      the only requirement is to implement __getitem__
      
      ne use case is to be able to use the same substitution script for
      different CRM notification messages and only compute the "heavy"
      substitution variables when they are actually needed.
      
      See nexedi/erp5!1047
      5016f968
    • Jérome Perrin's avatar
      testNotificationMessageModule: cleanups · 7e775f3c
      Jérome Perrin authored
      7e775f3c
  2. 14 Feb, 2020 10 commits
  3. 13 Feb, 2020 1 commit
    • Jérome Perrin's avatar
      bank_reconciliation: Disable "Select Non Reconciled" · 4761e8be
      Jérome Perrin authored
      This action is very rarely used, typically once for each section and
      then never used again.
      
      Make it only enabled for Manager user, as a way to disable it, but it's
      still here and it still works, but it's not useful in normal operations.
      4761e8be
  4. 12 Feb, 2020 4 commits
  5. 10 Feb, 2020 9 commits
  6. 07 Feb, 2020 2 commits
    • Jérome Perrin's avatar
      ERP5JS: render before commit · dc02bfa8
      Jérome Perrin authored
      Since 264ded5c in ERP5JS we render the form directly after a successful edit, but this was done sometimes too early, namely, the next form was rendered before interaction workflows and this leads to problems like the ones discussed in nexedi/erp5!982 (comment 92893)
      
      /reviewed-on nexedi/erp5!1040
      dc02bfa8
    • Jérome Perrin's avatar
      knowledge_pad_ui_test: fix a random failure · ed44bee5
      Jérome Perrin authored
      This test click on the delete button which deletes by an ajax request
      and immediatly after open the "wait for activities" page. Sometimes the
      second request starts before the first is committed, so there are no
      activities to wait for.
      
      When using ZServer, we had only one worker thread, so this was not
      visible, but with wsgi we have more than one so it happened sometimes.
      
      Use an old jQuery trick to wait that the first request is no longer in
      flight.
      
      /reviewed-on nexedi/erp5!1038
      ed44bee5
  7. 06 Feb, 2020 3 commits
  8. 05 Feb, 2020 3 commits
  9. 04 Feb, 2020 1 commit
  10. 03 Feb, 2020 2 commits
    • Jérome Perrin's avatar
      hal_json_style: after save, render next form later · 97c40dcb
      Jérome Perrin authored
      We want to render the next page after interaction workflows are
      executed.
      97c40dcb
    • Jérome Perrin's avatar
      ui_test: test how interaction workflows can change values when saving · fcde3e85
      Jérome Perrin authored
      This uses a foo_interaction_workflow that sets a short title when title
      is set to a special value. We use it to check that when user set the
      title to that special value and save, next time the form is displayed,
      the values displayed are the ones after interaction workflow modified.
      
      This is a simple and a bit unrealistic scenario, but we have for example
      interaction workflows that update security definitions when some
      properties are modified, we want the next form to display the values
      after modifications.
      
      This is also the case of editions of portal components which sets the
      document to "modified" state and "re-validate" it at the end of
      transaction, unless pylint detects error.
      fcde3e85