According to pep-0263, python scripts can define encoding magic on
first or second line.
If we use for example such a script:

```python
  # coding: utf-8
  return "héhé"
```

then using .read() was wrong, because it return the script with headers,
ie:

```python
  ## Script (Python) "test_coding"
  ##bind container=container
  ##bind context=context
  ##bind namespace=
  ##bind script=script
  ##bind subpath=traverse_subpath
  ##parameters=
  ##title=
  ##
  # coding: utf-8
  return "héhé"
```

so the coding magic is no longer in first line and pylint complains
with error like:

Cannot decode using encoding "ascii", unexpected byte at position 11 (invalid-encoded-data)]

/reviewed-on nexedi/erp5!825

This method is used to import ZODB Components when fallback on filesystem is needed
and used when loading Document and Extension Components.

1,000,000 executions:
  * Before:
    timeit("erp5.component.extension.find_load_module(module_name)",
           setup="import erp5.component.extension; module_name='Hoge'")
    59.073
    59.324
  * b45914fa ExternalMethod optimization:
    timeit("__import__('erp5.component.extension.' + module_name, fromlist='*', level=0)",
           setup="module_name='Hoge'")
    1.754
    1.845
  * This commit:
    timeit("import_module('erp5.component.extension.' + module_name)",
           setup="from importlib import import_module; module_name='Hoge'")
    1.346
    1.311
    => Faster because import_module() calls __import__() without fromlist (not
       needed as it returns module from sys.modules after this) and level
       parameters.
    => Introduced in python3 and backported to python2.7. Recommended over
       __import__ in Python documentation for non-internal usage and when
       getting the module itself and not its top-level one.

When clicking "Reply" on a discussion post, this script adds a hidden input to mark which post we are replying to.
This cause problem  when ctrl+clicking reply to reply in a new tab, because it leaves the page with the extra hidden input, which cause problems, like clicking reply again cause `Error Value: You are not allowed to access '['1', '1']`' in this context , or clicking change page will reply.

This is a minimal effort fix, just remove the added element after click.

/reviewed-on nexedi/erp5!823

This reverts commit b7d9590c.

Users are not supposed to edit templates because documents are not in
their "normal" context, if user edit templates some unexpected things
might happen. We don't want user to change state or do some actions that
may cause interactions on other documents from a template. This was
never strongly enforced, but there was not supposed to be an easy way
for users to access the template document.

With old versions of ERP5 (before the rework of isIndexable /
isSubTreeIndexable ), users could also add lines inside the template
document and these lines where indexable.

Note that the way of editing templates is:
 * make a "real" document from the template
 * modify this document
 * use "Make Template" again - this will replace the document with the
same title.

/reviewed-on nexedi/erp5!822

This allow to pick up only few document on which to execute the action.

Listbox 'Edit' mode will contain copy/paste/delete actions.
Listbox 'Select' mode will contain include/exclude and all other erp5 actions (except delete).

Define the action on erp5 with the object_list_action category value.

Stop using change command by default.
This was a hack to hope that some parameters were propagated.

Propagate instead a cancel parameter to correctly quit dialog.

Stop hardcoding extended search parameter propagation.

This allow user to revert his change by using the browser back button.

See nexedi/erp5@9dcbc756

This fixes:

  Traceback (innermost last):
    Module Products.CMFActivity.ActivityTool, line 1373, in invokeGroup
      traverse(method_id)(expanded_object_list)
    Module Products.ERP5Catalog.CatalogTool, line 946, in catalogObjectList
      super(CatalogTool, self).catalogObjectList(tmp_object_list, **m.kw)
    Module Products.ZSQLCatalog.ZSQLCatalog, line 813, in catalogObjectList
      **kw
  TypeError: catalogObjectList() got an unexpected keyword argument 'group_id'

/reviewed-on nexedi/erp5!819

* Set MAKEFLAGS with -l to limit number of jobs by load and number of
processes
* set NPY_NUM_BUILD_JOBS & BUNDLE_JOBS to `node_quantity` instance
parameter

/reviewed-on nexedi/erp5!809

Originally, uids somehow sorted messages by date of insertion, in particular
for those that were created within the same second. But since random uids,
such messages became validated or processed in random order.

Note however that by default, messages created in the same transaction all have
exactly the same date, so commit a42da4de
("CMFActivity: Do not use offset for scanning messages to validate.")
forces us to keep the ordering on uids (in addition to priority/date).

Existing instances will upgrade automatically, using the already existing code
to upgrade tables in a generic way. You should see the following logs:

    INFO CMFActivity 'message_queue' table upgraded
    ALTER TABLE message_queue
      MODIFY COLUMN date datetime(6) NOT NULL AFTER uid,
      MODIFY COLUMN processing_date datetime(6) DEFAULT NULL AFTER processing
    INFO CMFActivity 'message_job' table upgraded
    ALTER TABLE message_job
      MODIFY COLUMN date datetime(6) NOT NULL AFTER uid,
      MODIFY COLUMN processing_date datetime(6) DEFAULT NULL AFTER processing
    INFO CMFActivity 'message' table upgraded
    ALTER TABLE message
      MODIFY COLUMN date datetime(6) NOT NULL AFTER uid,
      MODIFY COLUMN processing_date datetime(6) DEFAULT NULL AFTER processing


/reviewed-on nexedi/erp5!820

so that options are kept

Same behaviour than xhtml style

Next step is to activate more contextual listbox actions.

Move listbox select button to the right, to simplify cancellation.

WebSite redirection must be tested against different virtual host monster configuration
TODO: No idea how to fetch the ipv6 in live test

https://lab.nexedi.com/nexedi/slapos/tree/master/software/proftpd/test
was just named "test", we want the test result to be named "proftpd"
instead.

/reviewed-on nexedi/erp5!815

See nexedi/erp5@04939506

Since recent rework of isSubtreeIndexable, direct indexation of a trash bin
is fixed, but recursive indexation recursion condition broke: it stop just
above the trash bin instead of stopping just below it.

Revert "mark file uploading tests as expected failure." as these Functional Tests are not supposed to fail.

This reverts commit ade16831.

enablePrivilege, and thus UniversalFileRead used to upload files, was disabled
in Firefox 17. Since SlapOS Firefox has been upgraded, "The operation is insecure"
error is raised when uploading files. However, this doesn't mean that these tests
should be expected to fail (and if they are, they should be removed instead).

This workflow involved an Assignee who can open, close, re-open and an
Assignor who can close definitively.
This is usually configured so that accountants are Assignee and CFO is
Assignor.

We realized that re-opening a Period that was previously closed is
something we don't want the accountants to do without CFO's approval.

To support this configuration, we only allow Assignor to re-open.

Now Assignee can open and close temporarily and Assignor can re-open and
close definitively.

/reviewed-on nexedi/erp5!813

This is really a hack, which may be integrated into renderJS directly

Reduce potential Zelenium test timeout by waiting for iframe to be loaded one by one

This check got lost when the first isSubtreeIndexable call was done on
parent document and not on self.

This partially reverts:

commit 76e3c115
Author: Vincent Pelletier <vincent@nexedi.com>
Date:   Mon Dec 10 16:40:48 2018 +0900

    Base: Fix isAncestryIndexable implementation.

as it accidentally carried over a totally unrelated (and unfinished)
change.

Start checking isSubtreeIndexable on parent document, not on current
document.
This bug broke Trash Bins indexation (and should not affect anything else,
as only Trash Bins prevent content indexation currently).

Extent trash tool unit test to verify actual indexation, and not just
indexability API.

Fixup 559c5e8b

See 994d8369

/reviewed-on nexedi/erp5!768

This should be tested even if it currently fails with "The operation is insecure"
when trying to upload local ODS files.

erp5_configurator_standard_ui_test: Fix testFunctionalConfigurator failures with erp5testnode (b955dbe0).

The following error occurred because setupAutomaticBusinessTemplateRepository()
was called and only added bt5/ directory but not bootstrap bt5s directory:
  BusinessTemplateMissingDependency: While analysing erp5_dhtml_style the following dependency could not be satisfied: erp5_xhtml_style ()
  Reason: Business Template could not be found in the repositories

Instead assume that bt5 repositories are set up properly.

Also, running through erp5testnode requires apache-backend Timeout to be
increased as waiting for upgrader activities to be processed can take
~15 minutes (!377).

[erp5_core] Follow guidelines for Actions on portal types Catalog and Catalog Tool by adding dialog before executing

Also, Cleanup useless actions and functions

/reviewed-on nexedi/erp5!811