• Daniel Theophanes's avatar
    database/sql: add driver.ResetSessioner and add pool support · 2620ac3a
    Daniel Theophanes authored
    A single database connection ususally maps to a single session.
    A connection pool is logically also a session pool. Most
    sessions have a way to reset the session state which is desirable
    to prevent one bad query from poisoning another later query with
    temp table name conflicts or other persistent session resources.
    
    It also lets drivers provide users with better error messages from
    queryies when the underlying transport or query method fails.
    Internally the driver connection should now be marked as bad, but
    return the actual connection. When ResetSession is called on the
    connection it should return driver.ErrBadConn to remove it from
    the connection pool. Previously drivers had to choose between
    meaningful error messages or poisoning the connection pool.
    
    Lastly update TestPoolExhaustOnCancel from relying on a
    WAIT query fixing a flaky timeout issue exposed by this
    change.
    
    Fixes #22049
    Fixes #20807
    
    Change-Id: Idffa1a7ca9ccfe633257c4a3ae299b864f46c5b6
    Reviewed-on: https://go-review.googlesource.com/67630Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
    2620ac3a
sql.go 82.8 KB