Commits · 4869996b928d0e5dc978a4de31f2824b47ae8cb7 · Kirill Smelkov / go

20 Dec, 2011 21 commits

template: better error message for empty templates · 4869996b

Rob Pike authored Dec 20, 2011

New("x").ParseFiles("y") can result in an empty "x" template.
Make the message clearer that this is the problem. The error
returns from both template packages in this case were
confusing.

I considered making the method use "x" instead of "y" in
this case, but that just made other situations confusing
and harder to explain.

Fixes #2594.

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/5498048

4869996b

.hgignore: ignore autogenerated files · bbdd2070
Christopher Wedgwood authored Dec 20, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5491077
```
bbdd2070

runtime/cgo: fix build · 5d429ad0

Russ Cox authored Dec 20, 2011

Two forgotten renames from last CL.

TBR=r
CC=golang-dev
https://golang.org/cl/5502046

5d429ad0

go: build runtime/cgo · 54fb9940

Russ Cox authored Dec 20, 2011

Also rename -v to -x in the build and install commands,
to match the flag in go test (which we can't change
because -v is taken).  Matches sh -x anyway.

R=r, iant, ality
CC=golang-dev
https://golang.org/cl/5504045

54fb9940

panics: use the new facilities of testing.B instead · 6b772462

Rob Pike authored Dec 20, 2011

Lots of panics go away.
Also fix a name error in html/template.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5498045

6b772462

go/ast, parser: remember short variable decls. w/ correspoding ident objects · b9697d4a

Robert Griesemer authored Dec 20, 2011

The ast.Object's Decl field pointed back to the corresponding declaration for
all but short variable declarations. Now remember corresponding assignment
statement in the Decl field.

Also: simplified some code for parsing select statements.

R=golang-dev, r, bradfitz
CC=golang-dev
https://golang.org/cl/5492072

b9697d4a

testing: allow benchmarks to print and fail · c50e4f5e

Rob Pike authored Dec 20, 2011

Refactors the benchmarks and test code.
Now benchmarks can call Errorf, Fail, etc.,
and the runner will act accordingly.

Because functionality has been folded into an
embedded type, a number of methods' docs
no longer appear in godoc output. A fix is
underway; if it doesn't happen fast enough,
I'll add wrapper methods to restore the
documentation.

R=bradfitz, adg, rsc
CC=golang-dev
https://golang.org/cl/5492060

c50e4f5e

cgo: support export for built-in types · 7be6229f

Maxim Pimenov authored Dec 20, 2011

This change doesn't pay attention to structs
so they still cannot be exported, see Issue 2552.

Fixes #2462.

R=dvyukov, rsc, iant
CC=golang-dev
https://golang.org/cl/5487058

7be6229f

encoding/binary: add more benchmarks · 16bf7d9e

Roger Peppe authored Dec 20, 2011

Also add a byte count to the varint benchmarks - this
isn't accurate, of course, but it allows a rough comparison to
the other benchmarks.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5496070

16bf7d9e

time: JSON marshaler for Time · 317ad14c

Robert Hencke authored Dec 20, 2011

R=golang-dev, dsymonds, hectorchu, r, r
CC=golang-dev
https://golang.org/cl/5496064

317ad14c

go: build runtime · a1198fcc

Russ Cox authored Dec 20, 2011

R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/5495068

a1198fcc

syscall: remove unnecessary semicolon from mksyscall.pl · b4962566
Ian Lance Taylor authored Dec 19, 2011
```
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5495098
```
b4962566
strconv: remove obsolete comment. · 36397814
Ian Lance Taylor authored Dec 19, 2011
```
R=r, rsc
CC=golang-dev
https://golang.org/cl/5490078
```
36397814
runtime: correct '.' to '·' in comments · 21af3d86
Ian Lance Taylor authored Dec 19, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5495097
```
21af3d86

dashboard: todo sends full Commit with Kind field · 634f0eda

Andrew Gerrand authored Dec 20, 2011

Permits us to implement other Kinds of todo instruction in the future.

R=rsc
CC=golang-dev
https://golang.org/cl/5495087

634f0eda

encoding/binary: add Write and Read examples · 7bffdc72
Andrew Gerrand authored Dec 20, 2011
```
R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/5495095
```
7bffdc72
5l/6l/8l: add support for netbsd signature note section · 5842f7e4
Joel Sing authored Dec 20, 2011
```
R=m4dh4tt3r, jsing, rsc
CC=golang-dev
https://golang.org/cl/5493068
```
5842f7e4
net/http: test should not leave tmp files behind on windows · b7e9d225
Alex Brainman authored Dec 20, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5496067
```
b7e9d225
os: make sure Remove returns correct error on windows · 796a2c19
Alex Brainman authored Dec 20, 2011
```
R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/5493078
```
796a2c19
old/template: close file in TestAll before deleting it · 448d89d6
Alex Brainman authored Dec 20, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5491073
```
448d89d6

dashboard: display correct package build state · 7c94dc04

Andrew Gerrand authored Dec 20, 2011

Includes some boring whitespace tweaks.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5492067

7c94dc04

19 Dec, 2011 19 commits

html: ignore <caption>, <col>, <tbody> etc. when parsing table fragments · a0bd46e7

Andrew Balholm authored Dec 20, 2011

Pass tests6.dat, test 36:
<caption><col><colgroup><tbody><tfoot><thead><tr>

| <tr>

Pass tests through test 44:
<body></body></html>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5494055

a0bd46e7

zip: fix data race in test · 315b361f
Brad Fitzpatrick authored Dec 19, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5492073
```
315b361f
syscall: regenerate z-files for linux/arm · d2933e99
Mikio Hara authored Dec 20, 2011
```
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5496062
```
d2933e99
exec: disable new test to fix build · 355ed5da
Ian Lance Taylor authored Dec 19, 2011
```
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/5494075
```
355ed5da

strconv: implement faster parsing of decimal numbers. · 2368b003

Rémy Oudompheng authored Dec 19, 2011

The algorithm is the same as in the double-conversion library
which also implements Florian Loitsch's fast printing algorithm.
It uses extended floats with a 64-bit mantissa, but cannot give
an answer for all cases.

                           old ns/op  new ns/op  speedup
BenchmarkAtof64Decimal         332        322      1.0x
BenchmarkAtof64Float           385        373      1.0x
BenchmarkAtof64FloatExp       9777        419     23.3x
BenchmarkAtof64Big            3934        691      5.7x
BenchmarkAtof64RandomBits    34060        899     37.9x
BenchmarkAtof64RandomFloats   1329        680      2.0x

See F. Loitsch, ``Printing Floating-Point Numbers Quickly and
Accurately with Integers'', Proceedings of the ACM, 2010.

R=ality, rsc
CC=golang-dev, remy
https://golang.org/cl/5494068

2368b003

doc: delete go course notes · c99f4f5b

Rob Pike authored Dec 19, 2011

They're out of date, a pain to maintain, and most of the material
is better served by the Go Tour.

Fixes #2101.

R=golang-dev, rsc, r, adg
CC=golang-dev
https://golang.org/cl/5489053

c99f4f5b

net, syscall, os: set CLOEXEC flag on epoll/kqueue descriptor · 38432959
Ian Lance Taylor authored Dec 19, 2011
```
Enable new test in os.

R=dave, iant, rsc
CC=golang-dev
https://golang.org/cl/5494061
```
38432959
gc: avoid unsafe in defn of package runtime · 1d0f93b4
Russ Cox authored Dec 19, 2011
```
Keeps -u tracking simple.

R=ken2
CC=golang-dev
https://golang.org/cl/5495094
```
1d0f93b4

runtime: separate out auto-generated files, take 2 · 55889409

Russ Cox authored Dec 19, 2011

This is like the ill-fated CL 5493063 except that
I have written a shell script (autogen.sh) instead of
thinking I could possibly write a correct Makefile.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5496075

55889409

encoding/json: cleanup leftover variables in array decoding. · 4a4c39e7

Rémy Oudompheng authored Dec 19, 2011

An old update for API changes in reflect package left several
helper variables that do not have a meaning anymore, and
the type checking of arrays vs slices was broken.
Fixes #2513.

R=ultrotter, rsc
CC=golang-dev, remy
https://golang.org/cl/5488094

4a4c39e7

strconv: reduce buffer size for multi-precision decimals. · 3a2dec02

Rémy Oudompheng authored Dec 19, 2011

The longest numbers we have to represent are the smallest denormals.
Their decimal mantissa is not longer than 5^1100. Taking into
account some extra size for in-place operations, 800 digits are
enough. This saves time used for zero intiialization of extra
bytes.

                                        old ns/op  new ns/op    delta
strconv_test.BenchmarkAtof64Decimal           521        334   -35.9%
strconv_test.BenchmarkAtof64Float             572        391   -31.6%
strconv_test.BenchmarkAtof64FloatExp        10242      10036    -2.0%
strconv_test.BenchmarkAtof64Big              4229       4029    -4.7%
strconv_test.BenchmarkFormatFloatDecimal     1396        934   -33.1%
strconv_test.BenchmarkFormatFloat            4295       3341   -22.2%
strconv_test.BenchmarkFormatFloatExp        12035      11181    -7.1%
strconv_test.BenchmarkFormatFloatBig         4213       3229   -23.4%
strconv_test.BenchmarkAppendFloatDecimal     1031        600   -41.8%
strconv_test.BenchmarkAppendFloat            3971       3044   -23.3%
strconv_test.BenchmarkAppendFloatExp        11699      11003    -5.9%
strconv_test.BenchmarkAppendFloatBig         3836       2915   -24.0%

R=golang-dev, bradfitz, rsc
CC=golang-dev, remy
https://golang.org/cl/5491064

3a2dec02

exec: add test to verify net package's epoll fd doesn't go to child · 178be83e
Brad Fitzpatrick authored Dec 19, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5490075
```
178be83e

syscall: Changes to the syscall package to support NetBSD. · 5425db8f

Christopher Nielsen authored Dec 20, 2011

Not all syscalls are implemented, but many are. On the suggestion
of Joel Sing <jsing@google.com>, the generated files were added
with hg add instead of hg cp, since they are generated on an OS
dependant basis.

R=golang-dev, jsing, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5491050

5425db8f

crypto/tls: don't assume an RSA private key in the API. · 2ca4a616

Adam Langley authored Dec 19, 2011

We still very much assume it in the code, but with this change in
place we can implement other things later without changing and users
of the package.

Fixes #2319.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5489073

2ca4a616

net/http: test both texta and textb values, not texta twice · 10e43384
Alex Brainman authored Dec 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5489082
```
10e43384
io/ioutil: close file in TestWriteFile before deleting it · c4227f5b
Alex Brainman authored Dec 19, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5495086
```
c4227f5b
dashboard: improve formatting of build status page · 35755b9c
Andrew Gerrand authored Dec 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5493077
```
35755b9c
builder: send commit time to dashboard · 9b3799aa
Andrew Gerrand authored Dec 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5489084
```
9b3799aa
archive/zip: add SetModTime method to FileHeader · 0b28de9a
Andrew Gerrand authored Dec 19, 2011
```
Fixes #2574.

R=golang-dev, bradfitz, adg, bradfitz
CC=golang-dev
https://golang.org/cl/5494072
```
0b28de9a