1. 18 Sep, 2019 10 commits
  2. 17 Sep, 2019 12 commits
  3. 16 Sep, 2019 16 commits
  4. 15 Sep, 2019 2 commits
    • Austin Clements's avatar
      misc/wasm: fix argv/envp layout · 142c002e
      Austin Clements authored
      The wasm_exec.js wrapper tries to set up the argv and envp following
      the UNIX conventions, but doesn't get it quite right, which can cause
      runtime.goenv to crash if you get unlucky.
      
      The main problem was that the envp array wasn't terminated with a nil
      pointer, so the runtime didn't know when to stop reading the array.
      This CL adds that nil pointer to the end of the envp array.
      
      The other problem was harmless, but confusing. In the UNIX convention,
      the argv array consists of argc pointers followed by a nil pointer,
      followed by the envp array. However, wasm_exec.js put the environment
      variable count between the two pointer arrays rather than a nil
      pointer. The runtime never looks at this slot, so it didn't matter,
      but the break from convention left Cherry and I trying to debug why it
      *wasn't* losing any environment variables before we realized that that
      layouts happened to be close enough to work. This CL switches to the
      UNIX convention of simply terminating the argv array with a nil
      pointer.
      
      Change-Id: Ic9a4cd9eabb5dfa599a809b960f9e579b9f1f4db
      Reviewed-on: https://go-review.googlesource.com/c/go/+/193417
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      Reviewed-by: default avatarRichard Musiol <neelance@gmail.com>
      142c002e
    • Ben Shi's avatar
      go/parser: fix ignored errors in ParseExprFrom · d12c62d1
      Ben Shi authored
      This CL fixes a bug in ParseExprFrom which makes
      error messages ignored when there are 10+ errors
      in a single expression.
      
      fixes #34241
      fixes #34274
      
      Change-Id: I29a82d3e3e726279005eb6fbcd7ee3aebffaa679
      Reviewed-on: https://go-review.googlesource.com/c/go/+/194638
      Run-TryBot: Ben Shi <powerman1st@163.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
      d12c62d1