An error occurred fetching the project authors.
  1. 22 Jun, 2015 8 commits
    • Russ Cox's avatar
      net/http: fix tests for recent URL.RawPath addition · ffbed5c2
      Russ Cox authored
      Change-Id: I35d20ed958c32d464b2c9d849403b6e3f99b6482
      Reviewed-on: https://go-review.googlesource.com/11343Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      ffbed5c2
    • Austin Clements's avatar
      runtime: one more Map{Bits,Spans} before arena_used update · 9a3112bc
      Austin Clements authored
      In order to avoid a race with a concurrent write barrier or garbage
      collector thread, any update to arena_used must be preceded by mapping
      the corresponding heap bitmap and spans array memory. Otherwise, the
      concurrent access may observe that a pointer falls within the heap
      arena, but then attempt to access unmapped memory to look up its span
      or heap bits.
      
      Commit d57c889a fixed all of the places where we updated arena_used
      immediately before mapping the heap bitmap and spans, but it missed
      the one place where we update arena_used and depend on later code to
      update it again and map the bitmap and spans. This creates a window
      where the original race can still happen. This commit fixes this by
      mapping the heap bitmap and spans before this arena_used update as
      well. This code path is only taken when expanding the heap reservation
      on 32-bit over a hole in the address space, so these extra mmap calls
      should have negligible impact.
      
      Fixes #10212, #11324.
      
      Change-Id: Id67795e6c7563eb551873bc401e5cc997aaa2bd8
      Reviewed-on: https://go-review.googlesource.com/11340
      Run-TryBot: Austin Clements <austin@google.com>
      Reviewed-by: default avatarRick Hudson <rlh@golang.org>
      Reviewed-by: default avatarDmitry Vyukov <dvyukov@google.com>
      9a3112bc
    • Austin Clements's avatar
      runtime: document relaxed access to arena_used · 2a331ca8
      Austin Clements authored
      The unsynchronized accesses to mheap_.arena_used in the concurrent
      part of the garbage collector look like a problem waiting to happen.
      In fact, they are safe, but the reason is somewhat subtle and
      undocumented. This commit documents this reasoning.
      
      Related to issue #9984.
      
      Change-Id: Icdbf2329c1aa11dbe2396a71eb5fc2a85bd4afd5
      Reviewed-on: https://go-review.googlesource.com/11254Reviewed-by: default avatarDmitry Vyukov <dvyukov@google.com>
      2a331ca8
    • Russ Cox's avatar
      net/url: add RawPath field, a hint at the desired encoding of Path · 874a605a
      Russ Cox authored
      Historically we have declined to try to provide real support for URLs
      that contain %2F in the path, but they seem to be popping up more
      often, especially in (arguably ill-considered) REST APIs that shoehorn
      entire paths into individual path elements.
      
      The obvious thing to do is to introduce a URL.RawPath field that
      records the original encoding of Path and then consult it during
      URL.String and URL.RequestURI. The problem with the obvious thing
      is that it breaks backward compatibility: if someone parses a URL
      into u, modifies u.Path, and calls u.String, they expect the result
      to use the modified u.Path and not the original raw encoding.
      
      Split the difference by treating u.RawPath as a hint: the observation
      is that there are many valid encodings of u.Path. If u.RawPath is one
      of them, use it. Otherwise compute the encoding of u.Path as before.
      
      If a client does not use RawPath, the only change will be that String
      selects a different valid encoding sometimes (the original passed
      to Parse).
      
      This ensures that, for example, HTTP requests use the exact
      encoding passed to http.Get (or http.NewRequest, etc).
      
      Also add new URL.EscapedPath method for access to the actual
      escaped path. Clients should use EscapedPath instead of
      reading RawPath directly.
      
      All the old workarounds remain valid.
      
      Fixes #5777.
      Might help #9859.
      Fixes #7356.
      Fixes #8767.
      Fixes #8292.
      Fixes #8450.
      Fixes #4860.
      Fixes #10887.
      Fixes #3659.
      Fixes #8248.
      Fixes #6658.
      Reduces need for #2782.
      
      Change-Id: I77b88f14631883a7d74b72d1cf19b0073d4f5473
      Reviewed-on: https://go-review.googlesource.com/11302Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      874a605a
    • Russ Cox's avatar
      cmd/go: fix test for issue 8181 · 794c01b8
      Russ Cox authored
      The test was translated from shell incorrectly,
      and it depended on having hg installed, which
      may not be the case.
      
      Moved repo to GitHub, updated code, and fixed
      go list ... command to be expected to succeed.
      
      Fixes test for #8181.
      
      Change-Id: I7f3e8fb20cd16cac5ed24de6fd952003bc5e08d4
      Reviewed-on: https://go-review.googlesource.com/11301Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      794c01b8
    • Carlos C's avatar
      encoding/csv: add examples for package · 1be335b6
      Carlos C authored
      Change-Id: I3463826aa760aa5984dec4fc043b95fd2a5120ac
      Reviewed-on: https://go-review.googlesource.com/11240Reviewed-by: default avatarAndrew Gerrand <adg@golang.org>
      1be335b6
    • Rob Pike's avatar
      cmd/asm: remove needless check for negative right shift · 71859efc
      Rob Pike authored
      In the parser, the shift value is always a uint64.
      
      Change-Id: I9b50295a9f7d174ed1f6f9baf78ec0ed43db417f
      Reviewed-on: https://go-review.googlesource.com/11322Reviewed-by: default avatarAndrew Gerrand <adg@golang.org>
      71859efc
    • Jeff R. Allen's avatar
      net/textproto: skip zero-length keys · 626188dd
      Jeff R. Allen authored
      A header of ": value" results in an empty key. Do not add
      it to the headers, because RFC7230 (section 3.2) says that
      field-names are tokens, which are one or more characters.
      
      Fixes #11205.
      
      Change-Id: I883be89da1489dc84f98523786b019d1d0169d46
      Reviewed-on: https://go-review.googlesource.com/11242Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      626188dd
  2. 21 Jun, 2015 1 commit
  3. 20 Jun, 2015 2 commits
  4. 19 Jun, 2015 20 commits
  5. 18 Jun, 2015 9 commits