• Hans de Goede's avatar
    drm/gma500: Refactor backlight support (v2) · 1f90b123
    Hans de Goede authored
    Refactor backlight support so that the gma_backlight_enable() /
    gma_backlight_disable() / gma_backlight_set() functions used by
    the Opregion handle will also work if no backlight_device gets
    registered.
    
    This is a preparation patch for not registering the gma500's own backlight
    device when acpi_video should be used, since registering 2 backlight
    devices for a single display really is undesirable.
    
    Since the acpi-video interface often uses the OpRegion we need to keep
    the OpRegion functional even when dev_priv->backlight_device is NULL.
    
    As a result of this refactor the actual backlight_device_register()
    call is moved to the shared backlight.c code and all #ifdefs related to
    CONFIG_BACKLIGHT_CLASS_DEVICE are now also limited to backlight.c .
    
    No functional changes intended.
    
    This has been tested on a Packard Bell Dot SC (Intel Atom N2600, cedarview)
    and a Sony Vaio vpc-x11s1e (Intel N540, poulsbo) laptop.
    
    Changes in v2:
    - Fix unused variable warnings when CONFIG_BACKLIGHT is not selected by
      marking the 2 variables as  __maybe_unused.
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Acked-by: default avatarPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220917205920.647212-2-hdegoede@redhat.com
    1f90b123
psb_device.c 7.52 KB