• Ronak Doshi's avatar
    vmxnet3: use gro callback when UPT is enabled · 3bced313
    Ronak Doshi authored
    Currently, vmxnet3 uses GRO callback only if LRO is disabled. However,
    on smartNic based setups where UPT is supported, LRO can be enabled
    from guest VM but UPT devicve does not support LRO as of now. In such
    cases, there can be performance degradation as GRO is not being done.
    
    This patch fixes this issue by calling GRO API when UPT is enabled. We
    use updateRxProd to determine if UPT mode is active or not.
    
    To clarify few things discussed over the thread:
    The patch is not neglecting any feature bits nor disabling GRO. It uses
    GRO callback when UPT is active as LRO is not available in UPT.
    GRO callback cannot be used as default for all cases as it degrades
    performance for non-UPT cases or for cases when LRO is already done in
    ESXi.
    
    Cc: stable@vger.kernel.org
    Fixes: 6f91f4ba ("vmxnet3: add support for capability registers")
    Signed-off-by: default avatarRonak Doshi <doshir@vmware.com>
    Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
    Link: https://lore.kernel.org/r/20230323200721.27622-1-doshir@vmware.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    3bced313
vmxnet3_drv.c 115 KB