• Viresh Kumar's avatar
    arch_topology: Avoid use-after-free for scale_freq_data · 83150f5d
    Viresh Kumar authored
    Currently topology_scale_freq_tick() (which gets called from
    scheduler_tick()) may end up using a pointer to "struct
    scale_freq_data", which was previously cleared by
    topology_clear_scale_freq_source(), as there is no protection in place
    here. The users of topology_clear_scale_freq_source() though needs a
    guarantee that the previously cleared scale_freq_data isn't used
    anymore, so they can free the related resources.
    
    Since topology_scale_freq_tick() is called from scheduler tick, we don't
    want to add locking in there. Use the RCU update mechanism instead
    (which is already used by the scheduler's utilization update path) to
    guarantee race free updates here.
    
    synchronize_rcu() makes sure that all RCU critical sections that started
    before it is called, will finish before it returns. And so the callers
    of topology_clear_scale_freq_source() don't need to worry about their
    callback getting called anymore.
    
    Cc: Paul E. McKenney <paulmck@kernel.org>
    Fixes: 01e055c1 ("arch_topology: Allow multiple entities to provide sched_freq_tick() callback")
    Tested-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
    Reviewed-by: default avatarIonela Voinescu <ionela.voinescu@arm.com>
    Tested-by: default avatarQian Cai <quic_qiancai@quicinc.com>
    Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
    83150f5d
arch_topology.c 16.1 KB