• Martin KaFai Lau's avatar
    selftests/bpf: Remove "&>" usage in the selftests · fbaf59a9
    Martin KaFai Lau authored
    In s390, CI reported that the sock_iter_batch selftest
    hits this error very often:
    
    2024-01-26T16:56:49.3091804Z Bind /proc/self/ns/net -> /run/netns/sock_iter_batch_netns failed: No such file or directory
    2024-01-26T16:56:49.3149524Z Cannot remove namespace file "/run/netns/sock_iter_batch_netns": No such file or directory
    2024-01-26T16:56:49.3772213Z test_sock_iter_batch:FAIL:ip netns add sock_iter_batch_netns unexpected error: 256 (errno 0)
    
    It happens very often in s390 but Manu also noticed it happens very
    sparsely in other arch also.
    
    It turns out the default dash shell does not recognize "&>"
    as a redirection operator, so the command went to the background.
    In the sock_iter_batch selftest, the "ip netns delete" went
    into background and then race with the following "ip netns add"
    command.
    
    This patch replaces the "&> /dev/null" usage with ">/dev/null 2>&1"
    and does this redirection in the SYS_NOFAIL macro instead of doing
    it individually by its caller. The SYS_NOFAIL callers do not care
    about failure, so it is no harm to do this redirection even if
    some of the existing callers do not redirect to /dev/null now.
    
    It touches different test files, so I skipped the Fixes tags
    in this patch. Some of the changed tests do not use "&>"
    but they use the SYS_NOFAIL, so these tests are also
    changed to avoid doing its own redirection because
    SYS_NOFAIL does it internally now.
    Signed-off-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
    Link: https://lore.kernel.org/r/20240127025017.950825-1-martin.lau@linux.devSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    fbaf59a9
lwt_reroute.c 6.95 KB