• Rohit Maheshwari's avatar
    cxgb4/ch_ktls: creating skbs causes panic · 687823d2
    Rohit Maheshwari authored
    Creating SKB per tls record and freeing the original one causes
    panic. There will be race if connection reset is requested. By
    freeing original skb, refcnt will be decremented and that means,
    there is no pending record to send, and so tls_dev_del will be
    requested in control path while SKB of related connection is in
    queue.
     Better approach is to use same SKB to send one record (partial
    data) at a time. We still have to create a new SKB when partial
    last part of a record is requested.
     This fix introduces new API cxgb4_write_partial_sgl() to send
    partial part of skb. Present cxgb4_write_sgl can only provide
    feasibility to start from an offset which limits to header only
    and it can write sgls for the whole skb len. But this new API
    will help in both. It can start from any offset and can end
    writing in middle of the skb.
    
    v4->v5:
    - Removed extra changes.
    
    Fixes: 429765a1 ("chcr: handle partial end part of a record")
    Signed-off-by: default avatarRohit Maheshwari <rohitm@chelsio.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    687823d2
sge.c 146 KB