- 08 May, 2024 13 commits
-
-
Wenjing Liu authored
[why] Switching between DSC clock or disable DSC block are not double buffered update. Corruption is observed if these updates happen before DSC double buffered disconnection. [how] Move DSC disable and refclk reset to post unlock update. Wait for DSC double buffered disconnection and all mpccs are disconnected before reset DSC clock. Reviewed-by:
Samson Tam <samson.tam@amd.com> Acked-by:
Tom Chung <chiahsuan.chung@amd.com> Signed-off-by:
Wenjing Liu <wenjing.liu@amd.com> Tested-by:
Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Alvin Lee authored
This reverts commit 3351c608 ("drm/amd/display: Only program P-State force if pipe config changed") Which causes regression. Reviewed-by:
Alvin Lee <alvin.lee2@amd.com> Tested-by:
-
Agustin Gutierrez authored
[Why] Some older MST hubs do not report DPCD registers according to specification. [How] This change re-applies commit c5365554 ("drm/amd/display: dsc mst re-compute pbn for changes on hub"). With an additional check for these older MST devices. Reviewed-by:
Swapnil Patel <swapnil.patel@amd.com> Acked-by:
Agustin Gutierrez <agustin.gutierrez@amd.com> Tested-by:
-
Nicholas Kazlauskas authored
[Why] Idle optimizations are blocked if there's more than one eDP connector on the board - blocking S0i3 and IPS2 for static screen. [How] Fix the checks to correctly detect number of active eDP. Also restrict the eDP support to panels that have correct feature support. Cc: Mario Limonciello <mario.limonciello@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: stable@vger.kernel.org Reviewed-by:
Charlene Liu <charlene.liu@amd.com> Acked-by:
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Tested-by:
-
Dillon Varone authored
[WHY & HOW] Make enable and disable sequences symmetric. Reviewed-by:
Dillon Varone <dillon.varone@amd.com> Tested-by:
-
Bhuvana Chandra Pinninti authored
[why] cleaning up the code refactor requires hubp to be in its own component. [how] move all files under newly created hubp folder and fixing the makefiles. Reviewed-by:
Martin Leung <martin.leung@amd.com> Acked-by:
Bhuvana Chandra Pinninti <bhuvanachandra.pinninti@amd.com> Tested-by:
-
Samson Tam authored
[Why & How] Split into a separate adjust and calculate call so we can let the caller adjust recout Reviewed-by:
Jun Lei <jun.lei@amd.com> Acked-by:
-
Agustin Gutierrez authored
[Why] This fixes a bug introduced by commit c5365554 ("drm/amd/display: dsc mst re-compute pbn for changes on hub"). The change caused light-up issues with a second display that required DSC on some MST docks. [How] Use Virtual DPCD for DSC caps in MST case. [Limitations] This change only affects MST DSC devices that follow specifications additional changes are required to check for old MST DSC devices such as ones which do not check for Virtual DPCD registers. Reviewed-by:
Hersen Wu <hersenxs.wu@amd.com> Acked-by:
-
Nicholas Susanto authored
[Why] Underflow occurs when running Netflix in a 4k144 eDP + 4k60 HDMI FRL setup. It is caused by latency varying based on the DCFCLK/FCLK state. [How] Enable urgent latency adjustment and match the reference to existing ASIC that also see increased latency at low FCLK. Reviewed-by:
Nicholas Susanto <nicholas.susanto@amd.com> Tested-by:
-
Dillon Varone authored
[WHY] Input mode for the DIG FIFO should be programmed as part of stream encoder setup. [HOW] Pre-calculate the pixels per cycle as part of the pixel clock params, and program as part of stream encoder setup. Reviewed-by:
-
Sreeja Golui authored
[Why] Providing a mechanism to manipulate the pwm frequency on the individual GPUs and monitor the transition during the switch. [How] Added a variable in dc_debug_options data structure. Using this variable to call the newly added command on the firmware. Reviewed-by:
Harry Vanzylldejong <harry.vanzylldejong@amd.com> Acked-by:
Sreeja Golui <sreeja.golui@amd.com> Tested-by:
-
Tom Chung authored
[Why & How] User can get the panel replay capability and state for debug. sudo cat /sys/kernel/debug/dri/0/eDP-1/replay_capability "Sink support: no" - if panel doesn't support Replay "Sink support: yes" - if panel supports Replay "Driver support: no\n" - if driver doesn't support Replay "Driver support: yes\n" - if driver supports Replay sudo cat /sys/kernel/debug/dri/0/eDP-1/replay_state It will return current panel replay state Reviewed-by:
Sun peng Li <sunpeng.li@amd.com> Acked-by:
-
Xi Liu authored
[Why and how] Current 420 ODM combine will override debug settings. Add support if debug settings is set for 420 ODM combine. Reviewed-by:
Xi Liu <xi.liu@amd.com> Tested-by:
-
- 03 May, 2024 3 commits
-
-
Sunil Khatri authored
reg_count is not used and the register count is directly derived from the array size and hence removed. Signed-off-by:
Sunil Khatri <sunil.khatri@amd.com> Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
-
Alex Hung authored
This fixes 12 UNINIT issues reported by Coverity. Reviewed-by:
Alex Hung <alex.hung@amd.com> Signed-off-by:
-
Alex Hung authored
[WHY & HOW] The assignment of disp_cfg_index_max is missed and should be assigned to __DML2_WRAPPER_MAX_STREAMS_PLANES__. Fixes: 55ec7679 ("drm/amd/display: Limit array index according to architecture") Reviewed-by:
-
- 02 May, 2024 24 commits
-
-
Asad Kamal authored
Validate tbo resource pointer, skip if NULL Signed-off-by:
Asad Kamal <asad.kamal@amd.com> Reviewed-by:
Lijo Lazar <lijo.lazar@amd.com> Signed-off-by:
-
Hersen Wu authored
[Why] Coverity reports OVERRUN warning. soc.num_states could be 40. But array range of bw_params->clk_table.entries is 8. [How] Assert if soc.num_states greater than 8. Reviewed-by:
-
Hersen Wu authored
[Why] Coverity report LOCK_EVASION warning. Access acrtc->wb_pending without lock wb_conn->job_lock. [How] Lock wb_conn->job_lock before accessing acrtc->wb_pending. Reviewed-by:
-
Hersen Wu authored
[Why] Coverity reports Memory - illegal accesses. [How] Skip inactive planes. Reviewed-by:
-
Alex Hung authored
[WHY & HOW] Make sure vmid0p72_idx, vnom0p8_idx and vmax0p9_idx calculation will never overflow and exceess array size. This fixes 3 OVERRUN and 1 INTEGER_OVERFLOW issues reported by Coverity. Reviewed-by:
Harry Wentland <harry.wentland@amd.com> Acked-by:
-
Alex Hung authored
[Why & How] dml_stream_idx will be -1 when it is not found. Check and skip in such a case as -1 is not a valid array index. This fixes a NEGATIVE_RETURNS issue reported by Coverity. Reviewed-by:
-
Alex Hung authored
[Why] dc_clk_table->entries has size of MAX_NUM_DPM_LVL(=8), but the loop counter i can go up to DML_MAX_CLK_TABLE_SIZE(=20) - 1. [How] The loop should be min(DML_MAX_CLK_TABLE_SIZE, MAX_NUM_DPM_LVL) - 1 instead. This fixes 21 OVERRUN issues reported by Coverity. Reviewed-by:
-
Hersen Wu authored
[Why] For addtion (uint8_t) variable + constant 1, coverity generates message below: Truncation due to cast operation on "cur_idx + 1" from 32 to 8 bits. Then Coverity assume result is 32 bits value be saved into 8 bits variable. When result is used as index to access array, Coverity suspects index invalid. [How] Change varaible type to uint32_t. Reviewed-by:
-
Alex Hung authored
[WHY & HOW] ctx->architecture determine array sizes of ODMMode and DPPPerSurface arrays to __DML2_WRAPPER_MAX_STREAMS_PLANES__ or __DML_NUM_PLANES__, and these array index should be checked before used This fixes 2 OVERRUN issues reported by Coverity. Reviewed-by:
-
Alex Hung authored
[WHY & HOW] A read of acrtc_attach->base.state->event was not locked so moving it inside the spinlock. This fixes a LOCK_EVASION issue reported by Coverity. Reviewed-by:
-
Alex Hung authored
[WHAT & HOW] Check clk table's array size to avoid out-of-bound memory accesses. This fixes two OVERRUN issues reported by Coverity. Reviewed-by:
-
Hersen Wu authored
[Why] Coverity reports RESOURCE_LEAK for some implemenations of clock_source_create. Do not release memory of clk_src if contructor fails. [How] Free clk_src if contructor fails. Reviewed-by:
-
Hersen Wu authored
[Why] Coverity reports OVERRUN warning for CalculateSwathAndDETConfiguration_params->hw_debug5 = &s->dummy_boolean[2]. bool dummy_boolean[2] is defined within struct dml2_core_calcs_mode_support_locals. [How] Change array size from 2 to 3. Reviewed-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Acked-by:
-
Hersen Wu authored
[Why & How] Check return pointer of kzalloc before using it. Reviewed-by:
-
Hersen Wu authored
[Why] For subtraction, coverity reports integer overflow warning message when variable type is uint32_t. [How] Change variable type to int32_t. Reviewed-by:
-
Hersen Wu authored
[Why] For substrcation, coverity reports integer overflow warning message when variable type is uint32_t. [How] Change varaible type to int32_t. Reviewed-by:
-
Hersen Wu authored
[Why] Coverity reports NULL_RETURN warning. [How] Add otg_master NULL check. Reviewed-by:
-
Alex Hung authored
[WHY & HOW] dc->links[] has max size of MAX_LINKS and NULL is return when trying to access with out-of-bound index. This fixes 3 OVERRUN and 1 RESOURCE_LEAK issues reported by Coverity. Reviewed-by:
-
Hersen Wu authored
[Why] Coverity reports RESOURCE_LEAK warning. State memory is not released if dm_create_color_properties fail. [How] Call kfree(state) before return. Reviewed-by:
-
Alex Hung authored
[WHY & HOW] HDCP_MESSAGE_ID_INVALID (-1) is not a valid msg_id nor is it a valid array index, and it needs checking before used. This fixes 4 OVERRUN issues reported by Coverity. Reviewed-by:
-
Alex Hung authored
This prevents accessing to negative index of link_encoders array. This fixes an OVERRUN issue reported by Coverity. Reviewed-by:
Rodrigo Siqueira <rodrigo.siqueira@amd.com> Acked-by:
-
Alex Hung authored
[WHY & HOW] num_valid_sets needs to be checked to avoid a negative index when accessing reader_wm_sets[num_valid_sets - 1]. This fixes an OVERRUN issue reported by Coverity. Reviewed-by:
-
Hersen Wu authored
[Why] Coverity reports OVERRUN warning. Do not check if array index valid. [How] Check msg_id valid and valid array index. Reviewed-by:
-
Hersen Wu authored
[Why & How] ASSERT if return NULL from kcalloc. Reviewed-by:
-
