- 18 Dec, 2023 7 commits
-
-
Maxime Ripard authored
Commits 63e83c1d ("drm: Consolidate connector arrays in drm_atomic_state"), b8b5342b ("drm: Consolidate plane arrays in drm_atomic_state") and 5d943aa6 ("drm: Consolidate crtc arrays in drm_atomic_state") moved the object pointer and their state pointer to an intermediate structure storing both. The CRTC commit didn't update the doc of the crtcs field to reflect that, and the doc for the planes and connectors fields mention that they are pointers to an array of structures with per-$OBJECT data. The private_objs field was added later on by commit b430c27a ("drm: Add driver-private objects to atomic state") reusing the same sentence than the crtcs field, probably due to copy and paste. While these fields are indeed pointers to an array, each item of that array contain a pointer to the object structure affected by the update, and its old and new state. There's no per-object data there, and there's more than just a pointer to the objects. Let's rephrase those fields a bit to better match the current situation. Acked-by:
Sui Jingfeng <sui.jingfeng@linux.dev> Reviewed-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://lore.kernel.org/r/20231214100917.277842-3-mripard@kernel.orgSigned-off-by:
Maxime Ripard <mripard@kernel.org>
-
Maxime Ripard authored
Commit 63e83c1d ("drm: Consolidate connector arrays in drm_atomic_state") removed the connector_states field but didn't remove its mention in the num_connectors documentation. Acked-by:
-
Maxime Ripard authored
Some fields of drm_atomic_state have been documented in-line, but some were documented in the main kerneldoc block before the structure. Since the former is the preferred option in DRM, let's move all the fields to an inline documentation. Acked-by:
-
Thomas Zimmermann authored
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that vesafb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by:
Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231206135153.2599-5-tzimmermann@suse.de
-
Thomas Zimmermann authored
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. Signed-off-by:
-
Thomas Zimmermann authored
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that efifb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by:
-
Thomas Zimmermann authored
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. v3: * use const screen_info in several places (Sui) * fix build for deferred takeover (kernel test robot) Signed-off-by:
-
- 15 Dec, 2023 14 commits
-
-
Pranjal Ramajor Asha Kanojiya authored
Every time QAIC_MMAP_BO ioctl is called for a BO, drm_gem_create_mmap_offset() is called. Calling drm_gem_create_mmap_offset() more then once for a BO seems redundant. Signed-off-by:
Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com> Reviewed-by:
Jeffrey Hugo <quic_jhugo@quicinc.com> Signed-off-by:
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231208163457.1295993-6-quic_jhugo@quicinc.com
-
Pranjal Ramajor Asha Kanojiya authored
Do not free BO explicitly in error path, just drop its reference, cleanup will be taken care by DRM as we have registered for ->free() callback. This patch makes sure that there is only one code path for BO to be freed. Signed-off-by:
Carl Vanderlip <quic_carlv@quicinc.com> Reviewed-by:
-
Jeffrey Hugo authored
The timesync channels have their struct fields out of order with the rest of the channels. Fix them so there is a consistent style in the file. Signed-off-by:
-
Pranjal Ramajor Asha Kanojiya authored
->queued field is used to track whether the BO is submitted to hardware for DMA or not. Since same information can be retrieved using ->xfer_list field of same structure remove ->queued as it is redundant. Signed-off-by:
-
Pranjal Ramajor Asha Kanojiya authored
->size in struct qaic_attach_slice_hdr is redundant since we have BO handle and its size can be retrieved from base BO structure. Signed-off-by:
-
Huang Rui authored
This Venus capset definition is used by Qemu, and Qemu imports the kernel protocol header file. Add Venus capset to the VirtIO-GPU protocol. Signed-off-by:
Huang Rui <ray.huang@amd.com> [dmitry.osipenko@collabora.com: edit commit message] Signed-off-by:
Dmitry Osipenko <dmitry.osipenko@collabora.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230915105918.3763061-1-ray.huang@amd.com
-
Dario Binacchi authored
It was useless to check again the "ret" variable if the function register_host() was not called. Signed-off-by:
Dario Binacchi <dario.binacchi@amarulasolutions.com> Reviewed-by:
Frieder Schrempf <frieder.schrempf@kontron.de> Signed-off-by:
Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20231207161056.183442-1-dario.binacchi@amarulasolutions.com
-
Alexander Stein authored
Use the register names from the datasheet. No functional change intended. Signed-off-by:
Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by:
-
Alexander Stein authored
This is the single register which clears its value upon read operation. Signed-off-by:
-
Alexander Stein authored
These registers might change their value without any host write operation. Signed-off-by:
-
Alexander Stein authored
Sort the list by the starting address to ease adding new entries. No functional change intended. Signed-off-by:
-
Alexander Stein authored
While at it, also add missing register definitions. HDCP registers are skipped as they are not named, range 0x0980 - 0x09ac. Signed-off-by:
-
Alexander Stein authored
0x0510 is bigger than 0x50c, order them accordingly. No functional change intended. Signed-off-by:
-
Alexander Stein authored
Using ranges it is easier to add more register where writing is not allowed, especially for sequences of registers. Signed-off-by:
-
- 14 Dec, 2023 16 commits
-
-
Christophe JAILLET authored
drm/tegra: output: Fix missing i2c_put_adapter() in the error handling paths of tegra_output_probe() If an error occurs after a successful of_get_i2c_adapter_by_node() call, it should be undone by a corresponding i2c_put_adapter(). Add the missing i2c_put_adapter() call. Fixes: 9be7d864 ("drm/tegra: Implement panel support") Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by:
Thierry Reding <treding@nvidia.com> Link: https://patchwork.freedesktop.org/patch/msgid/b38604178991e1f08b2cda219103be266be2d680.1693667005.git.christophe.jaillet@wanadoo.fr
-
Christophe JAILLET authored
If clk_get_sys(..., "pll_d2_out0") fails, the clk_get_sys() call must be undone. Add the missing clk_put and a new 'put_pll_d_out0' label in the error handling path, and use it. Fixes: 0c921b6d ("drm/tegra: dc: rgb: Allow changing PLLD rate on Tegra30+") Signed-off-by:
-
Christophe JAILLET authored
If an error occurs after calling tegra_output_probe(), tegra_output_remove() should be called as already done in the remove function. Fixes: 59d29c0e ("drm/tegra: Allocate resources at probe time") Signed-off-by:
-
Christophe JAILLET authored
If an error occurs after calling tegra_output_probe(), tegra_output_remove() should be called as already done in the remove function. Fixes: 59d29c0e ("drm/tegra: Allocate resources at probe time") Signed-off-by:
-
Christophe JAILLET authored
If an error occurs after calling pm_runtime_enable(), pm_runtime_disable() should be called as already done in the remove function. Fixes: ef8187d7 ("drm/tegra: dsi: Implement runtime PM") Signed-off-by:
-
Christophe JAILLET authored
If an error occurs after calling tegra_output_probe(), tegra_output_remove() should be called as already done in the remove function. Fixes: dec72739 ("drm/tegra: Add DSI support") Signed-off-by:
-
Zhang Shurong authored
The pm_runtime_enable function increases the power disable depth, which means that we must perform a matching decrement on the error handling path to maintain balance within the given context. Additionally, we need to address the same issue for pm_runtime_get_sync. We fix this by invoking pm_runtime_disable and pm_runtime_put_sync when error returns. Fixes: 82b81b3e ("drm/tegra: dpaux: Implement runtime PM") Signed-off-by:
Zhang Shurong <zhang_shurong@foxmail.com> Signed-off-by:
-
Jani Nikula authored
Reduce the need for rebuilds when drm_edid.h is modified by including it only where needed. v2: Fix build (kernel test robot <lkp@intel.com>) Signed-off-by:
Jani Nikula <jani.nikula@intel.com> Signed-off-by:
-
Chen Ni authored
Add check for the return value of of_find_device_by_node() and return the error if it fails in order to avoid NULL pointer dereference. Fixes: e94236cd ("drm/tegra: dsi: Add ganged mode support") Signed-off-by:
Chen Ni <nichen@iscas.ac.cn> Signed-off-by:
-
Donald Robson authored
I will be leaving Imagination Technologies on 2023-12-15 and will no longer be working on this driver. Signed-off-by:
Donald Robson <donald.robson@imgtec.com> Signed-off-by:
-
Jani Nikula authored
__packed is preferred over __attribute__((packed)). Signed-off-by:
Simon Ser <contact@emersion.fr> Link: https://patchwork.freedesktop.org/patch/msgid/20231212132557.3777281-2-jani.nikula@intel.com
-
Jani Nikula authored
__packed is preferred over __attribute__((packed)). Signed-off-by:
-
Karolina Stolarek authored
Test reservation and release of TTM buffer objects. Add tests to check pin and unpin operations. Signed-off-by:
Karolina Stolarek <karolina.stolarek@intel.com> Tested-by:
Amaranath Somalapuram <Amaranath.Somalapuram@amd.com> Reviewed-by:
Andi Shyti <andi.shyti@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/fcd53970f55ae4be8c738e03f9fcf45366d20b47.1701257386.git.karolina.stolarek@intel.comSigned-off-by:
Christian König <christian.koenig@amd.com>
-
Karolina Stolarek authored
Test initialization, creation and destruction of ttm_tt instances. Export ttm_tt_destroy and ttm_tt_create symbols for testing purposes. Signed-off-by:
-
Karolina Stolarek authored
Test initialization of ttm_resource using different memory domains. Add tests for a system memory manager and functions that can be tested without a fully-featured resource manager. Update ttm_bo_kunit_init() to initialize BO's kref and a genuine GEM drm object. Export ttm_resource_alloc for test purposes only. Signed-off-by:
-
Brian Masney authored
When the power domains cannot be parsed, the message is incorrectly logged as an info message. Let's change this to an error since an error is returned. Fixes: 92a511a5 ("fbdev/simplefb: Add support for generic power-domains") Signed-off-by:
Brian Masney <bmasney@redhat.com> Acked-by:
Andrew Halaney <ahalaney@redhat.com> Acked-by:
Hans de Goede <hdegoede@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231212195754.232303-1-bmasney@redhat.com
-
- 13 Dec, 2023 3 commits
-
-
Vignesh Raman authored
Update msm-apq8016-fails, mediatek-mt8173-fails and virtio_gpu-none-fails to include the tests which fail. Signed-off-by:
Vignesh Raman <vignesh.raman@collabora.com> Signed-off-by:
Helen Koike <helen.koike@collabora.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231207091831.660054-11-vignesh.raman@collabora.com
-
Vignesh Raman authored
Document the IGT version in the flaky tests reporting template. Acked-by:
-
Vignesh Raman authored
virtio-gpu kernel driver reports 16 for count_crtcs which exceeds IGT_MAX_PIPES set to 8 in igt-gpu-tools. This results in below memory corruption, malloc(): corrupted top size Received signal SIGABRT. Stack trace: #0 [fatal_sig_handler+0x17b] #1 [__sigaction+0x40] #2 [pthread_key_delete+0x14c] #3 [gsignal+0x12] #4 [abort+0xd3] #5 [__fsetlocking+0x290] #6 [timer_settime+0x37a] #7 [__default_morecore+0x1f1b] #8 [__libc_calloc+0x161] #9 [drmModeGetPlaneResources+0x44] #10 [igt_display_require+0x194] #11 [__igt_unique____real_main1356+0x93c] #12 [main+0x3f] #13 [__libc_init_first+0x8a] #14 [__libc_start_main+0x85] #15 [_start+0x21] This is fixed in igt-gpu-tools by increasing IGT_MAX_PIPES to 16. https://patchwork.freedesktop.org/series/126327/ Uprev IGT to include the patches which fixes this issue. Acked-by:
-
