- 20 Dec, 2023 1 commit
-
-
Pranjal Ramajor Asha Kanojiya authored
Offload the balancing of init and destroy calls to DRM managed APIs. mutex destroy for ->cntl_mutex is not called during device release and destroy workqueue is not called in error path of create_qdev(). So, use DRM managed APIs to manage the release of resources and avoid such problems. Signed-off-by:
Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com> Reviewed-by:
Jeffrey Hugo <quic_jhugo@quicinc.com> Signed-off-by:
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231208163457.1295993-7-quic_jhugo@quicinc.com
-
- 18 Dec, 2023 14 commits
-
-
Xuxin Xiong authored
Add support for the following 3 panels: 1. BOE NV116WHM-N49 V8.0 2. BOE NV122WUM-N41 3. CSO MNC207QS1-1 Signed-off-by:
Xuxin Xiong <xuxinxiong@huaqin.corp-partner.google.com> Reviewed-by:
Douglas Anderson <dianders@chromium.org> Signed-off-by:
-
Pin-yen Lin authored
These panels are used by Mediatek MT8173 Chromebooks, and they used to work with the downstream v4.19 kernel without any specified delay. Back in the v4.19 kernel, they used the "little white lie" approach, which is making the devicetree claim a specific panel's compatible string for many different panels. That was a common solution before the generic edp-panel driver. After we uprevved the device to a newer kernel and used the edp-panel driver, we saw multiple devices reporting warnings of using an unknown panel and falling back to the conservative timings, which means that they turn on/off much more slowly than they should. We tried to fill in the timings for those panels, but we failed to find all the data sheets for them. Therefore, instead of having them use the default conservative timings, update them with less-conservative timings from other panels of the same vendor. The panels should still work under those timings, and we can save some delays and suppress the warnings. Signed-off-by:
Pin-yen Lin <treapking@chromium.org> Reviewed-by:
-
Pin-yen Lin authored
Add panels used by Mediatek MT8173 Chromebooks. Signed-off-by:
-
Pin-yen Lin authored
Add the support of powered_on_to_enable delay as the minimum time that needs to have passed between the panel powered on and enable may begin. This delay is seen in BOE panels as the minimum delay of T3+T4+T5+T6+T8 in the eDP timing diagrams. Signed-off-by:
-
Ville Syrjälä authored
The original rationale for commit cd456f8d ("drm: Restrict stackdepot usage to builtin drm.ko") was that depot_save_stack() (which is what we used back then) wasn't exported. stack_depot_save() (which is what we use now) is exported however, so relax the dependency allow CONFIG_DRM_MM_DEBUG with DRM=m. Signed-off-by:
Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231215111129.9559-1-ville.syrjala@linux.intel.comAcked-by:
Javier Martinez Canillas <javierm@redhat.com>
-
Maxime Ripard authored
The name of the structure drm_atomic_state is confusing. Let's add an entry to our todo list to rename it. Reviewed-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://lore.kernel.org/r/20231214100917.277842-5-mripard@kernel.orgSigned-off-by:
Maxime Ripard <mripard@kernel.org>
-
Maxime Ripard authored
The current documentation of drm_atomic_state says that it's the "global state object". This is confusing since, while it does contain all the objects affected by an update and their respective states, if an object isn't affected by this update it won't be part of it. Thus, it's not truly a "global state", unlike object state structures that do contain the entire state of a given object. Reviewed-by:
Hamza Mahfooz <hamza.mahfooz@amd.com> Acked-by:
Pekka Paalanen <pekka.paalanen@collabora.com> Link: https://lore.kernel.org/r/20231214100917.277842-4-mripard@kernel.orgSigned-off-by:
-
Maxime Ripard authored
Commits 63e83c1d ("drm: Consolidate connector arrays in drm_atomic_state"), b8b5342b ("drm: Consolidate plane arrays in drm_atomic_state") and 5d943aa6 ("drm: Consolidate crtc arrays in drm_atomic_state") moved the object pointer and their state pointer to an intermediate structure storing both. The CRTC commit didn't update the doc of the crtcs field to reflect that, and the doc for the planes and connectors fields mention that they are pointers to an array of structures with per-$OBJECT data. The private_objs field was added later on by commit b430c27a ("drm: Add driver-private objects to atomic state") reusing the same sentence than the crtcs field, probably due to copy and paste. While these fields are indeed pointers to an array, each item of that array contain a pointer to the object structure affected by the update, and its old and new state. There's no per-object data there, and there's more than just a pointer to the objects. Let's rephrase those fields a bit to better match the current situation. Acked-by:
Sui Jingfeng <sui.jingfeng@linux.dev> Reviewed-by:
-
Maxime Ripard authored
Commit 63e83c1d ("drm: Consolidate connector arrays in drm_atomic_state") removed the connector_states field but didn't remove its mention in the num_connectors documentation. Acked-by:
-
Maxime Ripard authored
Some fields of drm_atomic_state have been documented in-line, but some were documented in the main kerneldoc block before the structure. Since the former is the preferred option in DRM, let's move all the fields to an inline documentation. Acked-by:
-
Thomas Zimmermann authored
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that vesafb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by:
Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by:
-
Thomas Zimmermann authored
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. Signed-off-by:
-
Thomas Zimmermann authored
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that efifb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by:
-
Thomas Zimmermann authored
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. v3: * use const screen_info in several places (Sui) * fix build for deferred takeover (kernel test robot) Signed-off-by:
-
- 15 Dec, 2023 14 commits
-
-
Pranjal Ramajor Asha Kanojiya authored
Every time QAIC_MMAP_BO ioctl is called for a BO, drm_gem_create_mmap_offset() is called. Calling drm_gem_create_mmap_offset() more then once for a BO seems redundant. Signed-off-by:
-
Pranjal Ramajor Asha Kanojiya authored
Do not free BO explicitly in error path, just drop its reference, cleanup will be taken care by DRM as we have registered for ->free() callback. This patch makes sure that there is only one code path for BO to be freed. Signed-off-by:
Carl Vanderlip <quic_carlv@quicinc.com> Reviewed-by:
-
Jeffrey Hugo authored
The timesync channels have their struct fields out of order with the rest of the channels. Fix them so there is a consistent style in the file. Signed-off-by:
-
Pranjal Ramajor Asha Kanojiya authored
->queued field is used to track whether the BO is submitted to hardware for DMA or not. Since same information can be retrieved using ->xfer_list field of same structure remove ->queued as it is redundant. Signed-off-by:
-
Pranjal Ramajor Asha Kanojiya authored
->size in struct qaic_attach_slice_hdr is redundant since we have BO handle and its size can be retrieved from base BO structure. Signed-off-by:
-
Huang Rui authored
This Venus capset definition is used by Qemu, and Qemu imports the kernel protocol header file. Add Venus capset to the VirtIO-GPU protocol. Signed-off-by:
Huang Rui <ray.huang@amd.com> [dmitry.osipenko@collabora.com: edit commit message] Signed-off-by:
Dmitry Osipenko <dmitry.osipenko@collabora.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230915105918.3763061-1-ray.huang@amd.com
-
Dario Binacchi authored
It was useless to check again the "ret" variable if the function register_host() was not called. Signed-off-by:
Dario Binacchi <dario.binacchi@amarulasolutions.com> Reviewed-by:
Frieder Schrempf <frieder.schrempf@kontron.de> Signed-off-by:
Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20231207161056.183442-1-dario.binacchi@amarulasolutions.com
-
Alexander Stein authored
Use the register names from the datasheet. No functional change intended. Signed-off-by:
Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by:
-
Alexander Stein authored
This is the single register which clears its value upon read operation. Signed-off-by:
-
Alexander Stein authored
These registers might change their value without any host write operation. Signed-off-by:
-
Alexander Stein authored
Sort the list by the starting address to ease adding new entries. No functional change intended. Signed-off-by:
-
Alexander Stein authored
While at it, also add missing register definitions. HDCP registers are skipped as they are not named, range 0x0980 - 0x09ac. Signed-off-by:
-
Alexander Stein authored
0x0510 is bigger than 0x50c, order them accordingly. No functional change intended. Signed-off-by:
-
Alexander Stein authored
Using ranges it is easier to add more register where writing is not allowed, especially for sequences of registers. Signed-off-by:
-
- 14 Dec, 2023 11 commits
-
-
Christophe JAILLET authored
drm/tegra: output: Fix missing i2c_put_adapter() in the error handling paths of tegra_output_probe() If an error occurs after a successful of_get_i2c_adapter_by_node() call, it should be undone by a corresponding i2c_put_adapter(). Add the missing i2c_put_adapter() call. Fixes: 9be7d864 ("drm/tegra: Implement panel support") Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by:
Thierry Reding <treding@nvidia.com> Link: https://patchwork.freedesktop.org/patch/msgid/b38604178991e1f08b2cda219103be266be2d680.1693667005.git.christophe.jaillet@wanadoo.fr
-
Christophe JAILLET authored
If clk_get_sys(..., "pll_d2_out0") fails, the clk_get_sys() call must be undone. Add the missing clk_put and a new 'put_pll_d_out0' label in the error handling path, and use it. Fixes: 0c921b6d ("drm/tegra: dc: rgb: Allow changing PLLD rate on Tegra30+") Signed-off-by:
-
Christophe JAILLET authored
If an error occurs after calling tegra_output_probe(), tegra_output_remove() should be called as already done in the remove function. Fixes: 59d29c0e ("drm/tegra: Allocate resources at probe time") Signed-off-by:
-
Christophe JAILLET authored
If an error occurs after calling tegra_output_probe(), tegra_output_remove() should be called as already done in the remove function. Fixes: 59d29c0e ("drm/tegra: Allocate resources at probe time") Signed-off-by:
-
Christophe JAILLET authored
If an error occurs after calling pm_runtime_enable(), pm_runtime_disable() should be called as already done in the remove function. Fixes: ef8187d7 ("drm/tegra: dsi: Implement runtime PM") Signed-off-by:
-
Christophe JAILLET authored
If an error occurs after calling tegra_output_probe(), tegra_output_remove() should be called as already done in the remove function. Fixes: dec72739 ("drm/tegra: Add DSI support") Signed-off-by:
-
Zhang Shurong authored
The pm_runtime_enable function increases the power disable depth, which means that we must perform a matching decrement on the error handling path to maintain balance within the given context. Additionally, we need to address the same issue for pm_runtime_get_sync. We fix this by invoking pm_runtime_disable and pm_runtime_put_sync when error returns. Fixes: 82b81b3e ("drm/tegra: dpaux: Implement runtime PM") Signed-off-by:
Zhang Shurong <zhang_shurong@foxmail.com> Signed-off-by:
-
Jani Nikula authored
Reduce the need for rebuilds when drm_edid.h is modified by including it only where needed. v2: Fix build (kernel test robot <lkp@intel.com>) Signed-off-by:
Jani Nikula <jani.nikula@intel.com> Signed-off-by:
-
Chen Ni authored
Add check for the return value of of_find_device_by_node() and return the error if it fails in order to avoid NULL pointer dereference. Fixes: e94236cd ("drm/tegra: dsi: Add ganged mode support") Signed-off-by:
Chen Ni <nichen@iscas.ac.cn> Signed-off-by:
-
Donald Robson authored
I will be leaving Imagination Technologies on 2023-12-15 and will no longer be working on this driver. Signed-off-by:
Donald Robson <donald.robson@imgtec.com> Signed-off-by:
-
Jani Nikula authored
__packed is preferred over __attribute__((packed)). Signed-off-by:
Simon Ser <contact@emersion.fr> Link: https://patchwork.freedesktop.org/patch/msgid/20231212132557.3777281-2-jani.nikula@intel.com
-
