1. 26 Oct, 2012 3 commits
    • Neil Horman's avatar
      sctp: Make hmac algorithm selection for cookie generation dynamic · 3c68198e
      Neil Horman authored
      Currently sctp allows for the optional use of md5 of sha1 hmac algorithms to
      generate cookie values when establishing new connections via two build time
      config options.  Theres no real reason to make this a static selection.  We can
      add a sysctl that allows for the dynamic selection of these algorithms at run
      time, with the default value determined by the corresponding crypto library
      availability.
      This comes in handy when, for example running a system in FIPS mode, where use
      of md5 is disallowed, but SHA1 is permitted.
      
      Note: This new sysctl has no corresponding socket option to select the cookie
      hmac algorithm.  I chose not to implement that intentionally, as RFC 6458
      contains no option for this value, and I opted not to pollute the socket option
      namespace.
      
      Change notes:
      v2)
      	* Updated subject to have the proper sctp prefix as per Dave M.
      	* Replaced deafult selection options with new options that allow
      	  developers to explicitly select available hmac algs at build time
      	  as per suggestion by Vlad Y.
      Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
      CC: Vlad Yasevich <vyasevich@gmail.com>
      CC: "David S. Miller" <davem@davemloft.net>
      CC: netdev@vger.kernel.org
      Acked-by: default avatarVlad Yasevich <vyasevich@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3c68198e
    • Daniel Borkmann's avatar
      packet: minor: remove unused err assignment · 342567cc
      Daniel Borkmann authored
      This tiny patch removes two unused err assignments. In those two cases the
      err variable is either overwritten with another value at a later point in
      time without having read the previous assigment, or it is assigned and the
      function returns without using/reading err after the assignment.
      Signed-off-by: default avatarDaniel Borkmann <daniel.borkmann@tik.ee.ethz.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      342567cc
    • hayeswang's avatar
      r8169: enable ALDPS for power saving · e0c07557
      hayeswang authored
      Enable ALDPS function to save power when link down. Note that the
      feature should be set after the other PHY settings. And the firmware
      is necessary. Don't enable it without loading the firmware.
      
      None of the firmware-free chipsets support ALDPS. Neither do the
      RTL8168d/8111d.
      
      For 8136 series, make sure the ALDPS is disabled before loading the
      firmware. For 8168 series, the ALDPS would be disabled automatically
      when loading firmware. You must not disable it directly.
      Signed-off-by: default avatarHayes Wang <hayeswang@realtek.com>
      Acked-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e0c07557
  2. 23 Oct, 2012 37 commits