1. 14 Aug, 2003 40 commits
    • Andrew Morton's avatar
      [PATCH] SELinux inode security init · 573429e3
      Andrew Morton authored
      From: Stephen Smalley <sds@epoch.ncsc.mil>
      
      This patch reworks the SELinux module code that handles inodes initialized
      before the policy is initially loaded to also cover the case where a pseudo
      filesystem such as selinuxfs or nfsd directly populate themselves.
      
      The list of inode security structures is split into per-superblock lists
      associated with each superblock security structure, and the initialization
      is performed by superblock_doinit.
      573429e3
    • Andrew Morton's avatar
      [PATCH] opl3 use-after-free fix · b99f2adc
      Andrew Morton authored
      From: Shawn Starr <spstarr@sh0n.net>
      
      opl3 use-after-free fix
      b99f2adc
    • Andrew Morton's avatar
      [PATCH] Docbook: Make mandocs output more terse · 6e88ebdf
      Andrew Morton authored
      From: Michael Still <mikal@stillhq.com>
      
      This patch takes into account requests from various LKML members for the
      mandocs output to be more terse.  Information about the copyright, and
      formatting of the man page is moved into a comment at the start of the
      groff output.
      
      Sample output can be found at:
        http://www.stillhq.com/linux/mandocs/2.6.0-test3-bk1/
      6e88ebdf
    • Andrew Morton's avatar
      [PATCH] uinput oops and panic fix · b0489fd7
      Andrew Morton authored
      From: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
      
      verify maximum number of bits before using set_bit
      b0489fd7
    • Andrew Morton's avatar
      [PATCH] Use mark_page_accessed() in follow_page() · a6bc080d
      Andrew Morton authored
      Touching a page via follow_page() counts as a reference so we should be
      either setting the referenced bit in the pte or running mark_page_accessed().
      
      Altering the pte is tricky because we haven't implemented an atomic
      pte_mkyoung().  And mark_page_accessed() is better anyway because it has more
      aging state: it can move the page onto the active list.
      a6bc080d
    • Andrew Morton's avatar
      [PATCH] access_process_vm() needs to dirty the page · 597536e3
      Andrew Morton authored
      If POKETEXT modifies the page it needs to tell the VM about it.
      597536e3
    • Andrew Morton's avatar
      [PATCH] dnotify documentation update · da8ac8ea
      Andrew Morton authored
      From: Stephen Rothwell <sfr@canb.auug.org.au>
      
      Fix the dnotify documentation and code example to reflect reality.
      da8ac8ea
    • Andrew Morton's avatar
      [PATCH] bugfix for initialization bug in adm1021 driver · 548373bb
      Andrew Morton authored
      From: Rusty Lynch <rusty@linux.co.intel.com>
      
      While initializing the adm1021 device, the driver is performing a conversion
      from fixed point to Celcius on values that were declaired as Celcius.  On my
      Dell Precision 220 this results in a shutdown after a couple of minutes
      running.
      
      The latch simply removes the conversion.
      548373bb
    • Andrew Morton's avatar
      [PATCH] Better argument size tracking in fs/exec.c · 5e46b7f3
      Andrew Morton authored
      From: Matthew Wilcox <willy@debian.org>
      
      Introduce a new variable "arg_size" and set it appropriately in each arm of
      the CONFIG_STACK_GROWSUP.  This patch fixes a bug for PA-RISC and makes the
      code cleaner for everyone.
      5e46b7f3
    • Andrew Morton's avatar
      [PATCH] Fix DAC960 oops · 0e4b3163
      Andrew Morton authored
      From: Dave Olien <dmo@osdl.org>
      
      The dynamic queue allocation appears to have exposed a long-standing bug.
      0e4b3163
    • Andrew Morton's avatar
      [PATCH] nls Makefile fix · 229326a9
      Andrew Morton authored
      From: Todor Todorov <ttodorov@web.de>
      
      A missig line fs/nls/Makefile prevents codepage 1250 from compiling and
      installing whatever the .config value.
      229326a9
    • Andrew Morton's avatar
      [PATCH] Fix strncpy off-by-one error · b33d0943
      Andrew Morton authored
      From: Yoshinori Sato <ysato@users.sourceforge.jp>
      
      It writes one too many zeroes when nulling out the destination.
      b33d0943
    • Andrew Morton's avatar
      [PATCH] Make 16-way x440's boot · 54d8435b
      Andrew Morton authored
      From: Matthew Dobson <colpatch@us.ibm.com>
      
      16 proc x440 boxen aren't booting mainline kernels right now for many valid
      configs.  This patch makes sure NUMA codepaths aren't executed for SMP
      configs.  It also adds some sane error messages to the code, and cleans up
      some #ifdefs.
      54d8435b
    • Andrew Morton's avatar
      [PATCH] jffs statfs fix · 0f9ba494
      Andrew Morton authored
      From: Josh Boyer <jwboyer@charter.net>
      
      jffs was missed in the statfs64 conversions.
      0f9ba494
    • Andrew Morton's avatar
      [PATCH] state request_firmware() maintainership. · e53988f7
      Andrew Morton authored
      From: Manuel Estrada Sainz <ranty@debian.org>
      
      Add Manuel to MAINTAINERS for request_firmware().
      e53988f7
    • Andrew Morton's avatar
      [PATCH] more documentation for request_firmware() · 86ae4503
      Andrew Morton authored
      From: Manuel Estrada Sainz <ranty@debian.org>
      
      Add some higher level docs to Documentation/firmware_class/README.
      86ae4503
    • Andrew Morton's avatar
      [PATCH] hugetlbfs - 'recovering' too many blocks on failure · 2e710fbb
      Andrew Morton authored
      From: Zwane Mwaikambo <zwane@linuxpower.ca>
      
      The code appears to be able to add too many blocks back to
      sbinfo->free_blocks in the failure path. We first do;
      
      len = vma->vm_end - vma->vm_start;
      sbinfo->free_blocks -= len;
      
      but then later do;
      len = (vma->vm_end - vma->vma_start) + (vma->vm_pgoff << HPAGE_SHIFT)
      
      error:
      sbinfo->free_blocks += len;
      2e710fbb
    • Andrew Morton's avatar
      [PATCH] ipmi_kcs_intf.c compile warning · b6a040f5
      Andrew Morton authored
      From: Zwane Mwaikambo <zwane@linuxpower.ca>
      
      drivers/char/ipmi/ipmi_kcs_intf.c: In function `acpi_find_bmc':
      drivers/char/ipmi/ipmi_kcs_intf.c:1088: warning: long unsigned int format, different type arg (arg 2)
      drivers/char/ipmi/ipmi_kcs_intf.c:1088: warning: long unsigned int format, different type arg (arg 2)
      b6a040f5
    • Andrew Morton's avatar
      [PATCH] fix [un]likely(), add ptr support · 2e0623e3
      Andrew Morton authored
      From: Albert Cahalan <albert@users.sourceforge.net>
      
      1. allows likely() and unlikely() to work for pointers
      
      2. fixes likely() (in C, any non-zero value is true)
      2e0623e3
    • Andrew Morton's avatar
      [PATCH] keyboard.c warning fix · ca5c021c
      Andrew Morton authored
      drivers/char/keyboard.c: In function `k_fn':
      drivers/char/keyboard.c:665: warning: comparison is always true due
      to limited range of data type
      
      I didn't want to just delete the code because one day the size of func_table
      may get smaller, or the type of `value' may get larger.  When that happens,
      the test becomes valid again.
      ca5c021c
    • Andrew Morton's avatar
      [PATCH] kill warning in jbd/revoke.c · 1c6e67fc
      Andrew Morton authored
      From: Peter Chubb <peterc@gelato.unsw.edu.au>
      
      If you need a long long format, then cast to long long, not u64.  u64 is
      long on 64-bit architectures.
      1c6e67fc
    • Andrew Morton's avatar
      [PATCH] Kill warning in drivers/input/misc/uinput.c on IA64 · 02cb6f3d
      Andrew Morton authored
      From: Peter Chubb <peterc@gelato.unsw.edu.au>
      
      Attached patch kills a warning when compiling on a 64-bit architecture
      (ssize_t is long, not int)
      02cb6f3d
    • Andrew Morton's avatar
      [PATCH] request_firmware fix · ef628dc9
      Andrew Morton authored
      From: Manuel Estrada Sainz <ranty@debian.org>
      
      - undo recent change, made in the believe that "buffer" was the size of
        the whole file, it is just PAGE_SIZE in size.  This was causing kernel
        memory corruption.
      
        - Since files are allowed to have unknown sizes, by setting their
          size to 0, we can't preallocate a buffer of their size on open.
      
      - Adapt request_firmware() to the sysfs change.
      
      - Adapt drivers/pci/pci-sysfs.c to the sysfs change.
      ef628dc9
    • Andrew Morton's avatar
      [PATCH] loop oops fix · 534d8695
      Andrew Morton authored
      loop-on-file oopses during unmount.  This is because lo_queue is now freed
      during lo_ioctl(LOOP_CLR_FD).  I think the scenario is:
      
      1: umount(8) opens /dev/loop0
      
      2: umount(8) runs lo_ioctl(LOOP_CLR_FD) (this frees the queue)
      
      3: umount(8) closes the /dev/loop0 handle.  The blockdev layer syncs the
         blockdev, but its mapping->backing_dev_info now points into la-la-land.
      
      We shouldn't be freeing the queue until all refs to it have gone away.  This
      patch gives the queue the same lifetime as the controlling loop_device
      itself.  It also makes the loop driver's queue appear in sysfs again.
      
      It would be better to free the queue when the device is not in use, but I'm
      not sure how we can hook into the blockdev layer to do that.
      534d8695
    • Andrew Morton's avatar
      [PATCH] Kill warning in minix filesystem on 64-bit archs · 2afe8ba3
      Andrew Morton authored
      From: Peter Chubb <peterc@gelato.unsw.edu.au>
      
      On 64-bit architectures, ino_t is int, not long, so the attached patch
      is needed to prevent a warning.
      2afe8ba3
    • Andrew Morton's avatar
      [PATCH] fix hugetlbfs slab corruption on umount · 1befd7a5
      Andrew Morton authored
      From: Zwane Mwaikambo <zwane@linuxpower.ca>
      
      hugetlbfs was accessing super_block->s_fs_info after free'ing it.  This was
      because it was being free'd prematurely.  I have deferred free until
      ->put_super().  I have also removed hugetlbfs_kill_super since it now is
      simply a kill_litter_super.
      1befd7a5
    • Andrew Morton's avatar
      [PATCH] fix typo in hd.c · 3b30d2b3
      Andrew Morton authored
      From: Adrian Bunk <bunk@fs.tum.de>
      
      hd.c contains a typo
      3b30d2b3
    • Andrew Morton's avatar
      [PATCH] Make MTRR init conform with recommended procedure · 8bc25c76
      Andrew Morton authored
      From: Zwane Mwaikambo <zwane@linuxpower.ca>
      
      This is a patch to make the MTRR initialisation more conformant with what
      is stated in volume 3 of (10-36 Memory Cache Control).  The most notable
      change is entering the no-fill cache mode before clearing the PGE bit in
      cr4.  Intel also states that we should do the cache flush via the cr3
      register shuffle.  If there is a problem with the patch please don't
      hesitate to beat me vigorously with a clue-by-four.
      
      It has been tested on a 3x Pentium 133, 8x PIII Xeon 700, 1x Celeron 550 and 32x
      PIII 500 NUMAQ (hardware courtesy of OSDL)
      8bc25c76
    • Andrew Morton's avatar
      [PATCH] floppy_init fix · 66c37726
      Andrew Morton authored
      From: Andrey Borzenkov <arvidjaar@mail.ru>
      
      The floppy driver doesn't remove /dev/floppy when floppy_init fails.
      66c37726
    • Andrew Morton's avatar
      [PATCH] _devfs_walk_path fix · 63d5d4f1
      Andrew Morton authored
      From: Andrey Borzenkov <arvidjaar@mail.ru>
      
      _devfs_walk_path does not check if de it is about to scan is a directory.
      Next step is spinlock on non-spinlock memory.  It requires either artificial
      setup or really broken driver but fairly easy to reproduce once you know how.
      
      It is likely to exist in 2.4 as well.
      63d5d4f1
    • Andrew Morton's avatar
      [PATCH] devfs_mk_dir fix · f82c2338
      Andrew Morton authored
      From: Andrey Borzenkov <arvidjaar@mail.ru>
      
      devfs_mk_dir freed wrong de and incorrectly passed to devfsd already freed
      de.  Besides it did not even check if entry found was actually directory.
      f82c2338
    • Andrew Morton's avatar
      [PATCH] firmware loader requires hotplug · 312e2e7b
      Andrew Morton authored
      From: Ramn Rey Vicente <ramon.rey@hispalinux.es>
      
      Fix the config issue with the hotplug firmware loader.  The firmware loader
      use hotplug, so this must be included as a dependency.
      312e2e7b
    • Andrew Morton's avatar
      [PATCH] handle old-style "root=" arguments · 11257180
      Andrew Morton authored
      When we changed try_name() to handle new-style printable dev_t formatting we
      broke lots of people's setups.  Lilo, grub, etc.
      
      Fix that by trying new-style formatting first, then fall back to old-style.
      
      People should generally use new-style %u:%u major:minor formatting in the
      future.
      11257180
    • Andrew Morton's avatar
      [PATCH] BUG fix for drivers/bluetooth/hci_usb.c · ba093cdd
      Andrew Morton authored
      From: Vinay K Nallamothu <vinay-rc@naturesoft.net>
      
      The patch below fixes two pointer reference bugs (shows up as compile
      time warnings given below) which wrongly take the address of "struct
      usb_interface*".
      
      	drivers/bluetooth/hci_usb.c: In function `hci_usb_probe':
      	drivers/bluetooth/hci_usb.c:786: warning: assignment from incompatible pointer type
      	drivers/bluetooth/hci_usb.c:810: warning: assignment from incompatible pointer type
      ba093cdd
    • Andrew Morton's avatar
      [PATCH] fix ide-scsi for ide_drive_t->queue change · 83415795
      Andrew Morton authored
      From: Mikael Pettersson <mikpe@csd.uu.se>
      
      This patch fixes ide-scsi.c for the ide_drive_t->queue type change
      in 2.6.0-test3.
      
      Without the patch you'll get these new warnings in -test3:
      
      drivers/scsi/ide-scsi.c: In function `idescsi_abort':
      drivers/scsi/ide-scsi.c:875: warning: passing arg 1 of `elv_queue_empty' from incompatible pointer type
      drivers/scsi/ide-scsi.c: In function `idescsi_reset':
      drivers/scsi/ide-scsi.c:902: warning: passing arg 1 of `elv_next_request' from incompatible pointer type
      83415795
    • Andrew Morton's avatar
      [PATCH] probe UDF after reiserfs · ae5a8df7
      Andrew Morton authored
      Bug 1065 (http://bugme.osdl.org/show_bug.cgi?id=1065) points out that there
      is a risk that UDF will accidentally mount a reiserfs partition, which would
      prevent a successful boot.
      
      Andries points out that probing is unreliable and that users/admins should
      always specify the root filesystem type on the kernel boot command line with
      "rootfstype=resierfs".
      
      But nobody does that, so we should be trying reiserfs before UDF.
      ae5a8df7
    • Andrew Morton's avatar
      [PATCH] fix task struct refcount bug · 4c0d7322
      Andrew Morton authored
      From: Manfred Spraul <manfred@colorfullife.com>
      
      (We think this might be the mystery bug which has been hanging about for
      months)
      
      
      We found a [the?] task struct refcount error: A task that dies sets
      tsk->state to TASK_ZOMBIE.  The next scheduled task checks prev->state, and
      if it's ZOMBIE, then it decrements the reference count of prev.  The
      prev->state & _ZOMBIE test is not atomic with schedule, thus if prev is
      scheduled again and dies between dropping the runqueue lock and checking
      prev->state, then the reference it dropped twice.
      
      This is possible with either preemption [schedule_tail is called by
      ret_from_fork with preemption count 1, finish_arch_switch drops it to 0] or
      profiling [profile_exit_mmap can sleep on profile_rwsem, called by
      mmdrop()] enabled.
      4c0d7322
    • Andrew Morton's avatar
      [PATCH] vt_ioctl warning fixes · 45ec9b9a
      Andrew Morton authored
      Several comparisons which can never be true because they're comparing u8's
      with numbers which are greater than 255.
      45ec9b9a
    • Andrew Morton's avatar
      [PATCH] /proc/net/pnp oops fix · 9dbe10bd
      Andrew Morton authored
      ic_servaddr is accessible after boot via /proc/net/pnp.  So it cannot be
      __initdata.
      
      davej says that other varibles there are treated the same way, so move them
      all into the regular data section.
      9dbe10bd
    • Andrew Morton's avatar
      [PATCH] nbd: fix send/receive/shutdown/disconnect races · e915e99b
      Andrew Morton authored
      From: Paul Clements <Paul.Clements@SteelEye.com>
      
      Here's the updated patch to fix several race conditions in nbd. It
      requires reverting the already included (but incomplete)
      nbd-race-fix.patch that's in -mm5.
      
      This patch fixes the following race conditions:
      
      1) adds an increment of req->ref_count to eliminate races between
      do_nbd_request and nbd_end_request, which resulted in the freeing of
      in-use requests -- there were races between send/receive, send/shutdown
      (killall -9 nbd-client), and send/disconnect (nbd-client -d), which are
      now all fixed
      
      2) adds locking and properly orders the code in NBD_CLEAR_SOCK to
      eliminate races with other code
      
      3) adds an lo->sock check to nbd_clear_que to eliminate races between
      do_nbd_request and nbd_clear_que, which resulted in the dequeuing of
      active requests
      
      4) adds an lo->sock check to NBD_DO_IT to eliminate races with
      NBD_CLEAR_SOCK, which caused an Oops when "nbd-client -d" was called
      e915e99b