- 01 Oct, 2020 33 commits
-
-
Corentin Labbe authored
Instead of using a fragile virt_to_bus, let's use proper DMA coherent for the stat_com entry. Signed-off-by:
Corentin Labbe <clabbe@baylibre.com> Signed-off-by:
Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-
Corentin Labbe authored
Supporting overlay is not necessary today, so let's reduce the code size by removing it. Signed-off-by:
-
Corentin Labbe authored
We need to get rid of zoran_fh, so let's change function arguments. Signed-off-by:
-
Corentin Labbe authored
Using video_drvdata() is proper and shorter than using directly fh pointers. Signed-off-by:
-
Corentin Labbe authored
We need to get rid of zoran_fh, so move the overlay_settings directly in the zoran structure. Signed-off-by:
-
Corentin Labbe authored
We need to get rid of zoran_fh, so move the jpg_settings directly in the zoran structure. Signed-off-by:
-
Corentin Labbe authored
We need to get rid of zoran_fh, so move the v4l_settings directly in the zoran structure. Signed-off-by:
-
Corentin Labbe authored
We need to get rid of zoran_fh, so move the buffer_size directly in the zoran structure. Signed-off-by:
-
Corentin Labbe authored
The slot 0 of guest is never initialized and so we print later random data. Signed-off-by:
-
Corentin Labbe authored
The ns_to_timeval function is removed, so replace it with v4l2_buffer_set_timestamp(). Signed-off-by:
-
Corentin Labbe authored
The VFL_TYPE_GRABBER type was removed, so let's use the new type. Signed-off-by:
-
Corentin Labbe authored
The zoran driver give some debug information in procfs, but this is not the right place. So let's remove them, we will use debugfs later. Signed-off-by:
-
Corentin Labbe authored
Signed-off-by:
-
Corentin Labbe authored
This patch convert dprintk(debug) to pci_dbg. Signed-off-by:
-
Corentin Labbe authored
This patch convert dprintk(info) to pci_info (or pci_dbg if the message is not important). Signed-off-by:
-
Corentin Labbe authored
This patch convert dprintk(warn) to pci_warn. Signed-off-by:
-
Corentin Labbe authored
This patch converts all errors dprintk to pci_err/pr_err. Signed-off-by:
-
Corentin Labbe authored
move function for avoiding forward declaration Signed-off-by:
-
Corentin Labbe authored
Fix a lot of style issue found by checkpatch. Signed-off-by:
-
Corentin Labbe authored
Fix some typo in doc. [hverkuil: The TV encoder are -> The TV encoder is] Signed-off-by:
-
Corentin Labbe authored
Simply remove this broken reference Signed-off-by:
-
Corentin Labbe authored
Add myself as maintainer. Signed-off-by:
-
Corentin Labbe authored
This reverts commit 8dce4b26. The revert is slighly modified: - Documentation/media/v4l-drivers/index.rst is ,ot restored since removed from tree - drivers/staging/media/Makefile is not restored since the zoran driver is not compilable yet. Signed-off-by:
-
Marek Szyprowski authored
Add proper control type to the recently introduced V4L2_CID_MPEG_VIDEO_FRAME_SKIP_MODE control. This will forward it to v4l2_ctrl_new_std_menu() not v4l2_ctrl_new_std(), what causes the failure. This fixes the following warning during driver initialization: s5p_mfc_enc_ctrls_setup:2671: Adding control (18) failed s5p_mfc_open:811: Failed to setup mfc controls Fixes: ef56b3ee ("media: s5p-mfc: Use standard frame skip mode control") Signed-off-by:
Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
Neither Vlc nor Gstreamer likes the PES_scrambling_control bits. In the case of GST, this can be seen with: $ GST_DEBUG=2 LANG=C gst-play-1.0 pcm_audio.ts ... 0:00:00.097973439 12308 0x55f7ddd155e0 WARN pesparser pesparse.c:411:mpegts_parse_pes_header: Wrong '0x10' marker before PES_scrambling_control (0x40) 0:00:00.097987026 12308 0x55f7ddd155e0 WARN tsdemux tsdemux.c:2314:gst_ts_demux_parse_pes_header: Error parsing PES header. pid: 0x111 stream_type: 0x6 ... So, change, it. After such change, the stream now plays fine with Vlc, Gstreamer, ffmpeg - and with programs that use such libraries, like Kaffeine. Signed-off-by: -
Mauro Carvalho Chehab authored
When compared with a stream generated via ffmpeg, it can be noticed that the PES doesn't contain any PCR info. That could cause problems with userspace decoding. So, rewrite the logic that fills the adaptation info, in order to allow it to add PCR frames without breaking frame alignment. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of passing struct pes_ts_header_write_args fields as function parameters, just pass a pointer to the struct. That would allow adding more args without needing to change the function prototype. Signed-off-by: -
Mauro Carvalho Chehab authored
optinal -> optional Signed-off-by: -
Mauro Carvalho Chehab authored
In order to better test userspace applications, add an encoding for the strings. The original channel string is also too big. As we're just playing the first compasses of the 5th Beethoven Symphony, change the service name to just "Beethoven". Also, add a provider's name. For such purpose, let's point it to the Linux media community website. With such changes, the SDT table now looks more like one got from a real digital TV channel: SDT | table_id 0x42 | section_length 44 | one 2 | zero 1 | syntax 1 | transport_stream_id 1860 | current_next 1 | version 0 | one2 3 | section_number 0 | last_section_number 0 | network_id 65281 | reserved 255 |\ |- service 0x0880 | EIT schedule 0 | EIT present following 0 | free CA mode 0 | running status 4 | descriptor length 27 | 0x48: service_descriptor | service type 1 | provider 'LinuxTV.org' | name 'Beethoven' |_ 1 services Signed-off-by: -
Mauro Carvalho Chehab authored
There's no reason to use static vars to store PSI version numbers. Also, currently, version numbers are starting with 0x01, because there's a code being called that increases it to 1 for all table initializer code, as the code may support dynamic changes at the PS tables on some future. So, let's just initialize them to 0x1f, in order for the versions to be reported as starting from 0. Signed-off-by: -
Mauro Carvalho Chehab authored
This field should point to the network ID, and has different ranges for cable, terrestrial or satellite. It also has an special range for temporary private usage. For now, let's use the temporary private one. Once the Network Information Table (NIT) gets added, this should be reviewed. Signed-off-by: -
Mauro Carvalho Chehab authored
Changeset 870e350d ("media: vidtv: get rid of ENDIAN_BITFIELD nonsense") was incomplete. There are still some wrong endannes logic at the driver. Get rid of them. Signed-off-by:
-
Mauro Carvalho Chehab authored
There's no need to have a check when setting timing.past_jiffies, as we can simply do the initialization earlier at vidtv_mux_init(). Signed-off-by:
-
- 30 Sep, 2020 7 commits
-
-
Mauro Carvalho Chehab authored
Using struct|enum :c:`type` here sounds a bad idea, as it may be documenting data types that were already removed. Also, it makes the file harder to read. As automarkup.py should be able to handle those cases, let's just get rid of the markup. While not required by automarkup, in order to make easier for grep, both type and names are now at the same line. Signed-off-by: -
Mauro Carvalho Chehab authored
There are several places there where struct was used twice, on multiple lines, like: struct struct ``v4l2_zoomcap`` That's probably done during the DocBook to ReSt conversion. Probably the cases where "struct struct" were at the same line was addressed back then, but the multi-line cases are still there. Get rid of them. Signed-off-by: -
Mauro Carvalho Chehab authored
As reported by Sphinx: ./Documentation/driver-api/media/v4l2-subdev:490: ./include/media/v4l2-subdev.h:384: WARNING: Unparseable C cross-reference: 'struct' Invalid C declaration: Expected identifier in nested name, got keyword: struct [error at 6] struct ------^ The markup there is wrong: &struct &v4l2_input -> &struct v4l2_input Signed-off-by: -
Mauro Carvalho Chehab authored
The new C domain code on Sphinx 3 is a lot more pedantic. It only accepts real functions declared as c:function. So, declarations like this are not valid: .. c:function:: int (*adap_enable)(struct cec_adapter *adap, bool enable); Also, no blank lines are allowed after ".. c:function:", and continuation lines should be like: .. c:function: int (void foo, \ int bar); Change the logic there, in order to avoid lots of warnings when built with Sphinx 3.x. Signed-off-by: -
Mauro Carvalho Chehab authored
There are two kernel-doc markups for include/media/v4l2-async.h, one at v4l2-async.rst and another one at v4l2-subdev.rst. Sphinx 3.x checks it and complains for duplicated symbols. So, get rid of one of them. Signed-off-by: -
Mauro Carvalho Chehab authored
The same markup are there twice, causing warnings with Sphinx 3.x. Drop the second copy. Signed-off-by: -
Mauro Carvalho Chehab authored
There are several :c:type: definitions there, in order to do cross-references with the driver's documentation. Those are broken when docs are built with Sphinx 3.x, as it would require :c:struct: instead. For Sphinx < 3.x, the automarkup.py extension is able to do the replacement already, and a future improvement on it should make it also work with Sphinx 3.x. So, get rid of the usage of the :c:type: macro there. Reviewed-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
