- 20 Apr, 2011 34 commits
-
-
Julia Lawall authored
Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Julia Lawall authored
Stream_bufs is initialized at the beginning of the function, and then the #ifdef code declares a new variable with the same name and initializes that. If the if in the ifdef is taken, the then branch returns, implying that the first stream_bufs is never used and is leaked. The first initialization is thus moved down after the ifdef. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by:
-
Julia Lawall authored
Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by:
-
Arend van Spriel authored
The hndpmu source file has functions for brcmfmac and brcmsmac driver but it turns out that on function level there is no reuse so for the brcmsmac its set of functions now reside in wlc_pmu.c. Reviewed-by:
Henry Ptasinski <henryp@broadcom.com> Reviewed-by:
Roland Vossen <rvossen@broadcom.com> Signed-off-by:
Arend van Spriel <arend@broadcom.com> Signed-off-by:
-
Roland Vossen authored
Code cleanup. Driver contains far too many ASSERTs. Bringing driver more in line with Greg KH's guidelines. Signed-off-by:
-
Roland Vossen authored
By calling wlc_wme_setparams() from wlc_edcf_setparams(), duplicate code in wlc_edcf_setparams() could be removed. Signed-off-by:
-
Roland Vossen authored
Code cleanup. Functions wlc_edcf_setparams() and wlc_wme_setparams() duplicate code amongst each other. This commit attempts to make life easier for the reviewer, by introducing non functional changes that bring wlc_edcf_setparams() more in line with wlc_wme_setparams(). As a result the subsequent commit can be reviewed more easily. Signed-off-by:
-
Roland Vossen authored
Signed-off-by:
-
Cho, Yu-Chen authored
transport.c usb.c use pr_<level> for messages Signed-off-by:
Cho, Yu-Chen <acho@novell.com> Signed-off-by:
-
Cho, Yu-Chen authored
smilmain.c use pr_<level> for messages Signed-off-by:
-
Cho, Yu-Chen authored
scsiglue.c use pr_<level> for messages Signed-off-by:
-
Cho, Yu-Chen authored
msscsi.c use pr_<level> for messages Signed-off-by:
-
Karthigan Srinivasan authored
issue. Fixed coding style issue. Signed-off-by:
Karthigan Srinivasan <karthigan.srinivasan2@gmail.com> Acked-by:
Pekka Enberg <penberg@kernel.org> Signed-off-by:
-
Tomas Winkler authored
fix indentation and drop success statements printouts that just causes code be less readable Signed-off-by:
Tomas Winkler <tomas.winkler@intel.com> Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
Marek Belisko <marek.belisko@open-nandra.com> Signed-off-by:
-
Nicolas Kaiser authored
Remove unused typedef bc_bool_t. Signed-off-by:
Nicolas Kaiser <nikai@nikai.net> Reviewed-by:
Jesper Juhl <jj@chaosbits.net> Signed-off-by:
-
Alexander Beregalov authored
Signed-off-by:
Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by:
-
Alexander Beregalov authored
Signed-off-by:
-
Alexander Beregalov authored
Replace rtsx_alloc_dma_buf() with kfree() back, chip parameter is not used; remove casts. Signed-off-by:
-
Alexander Beregalov authored
Signed-off-by:
-
Alexander Beregalov authored
Signed-off-by:
-
Alexander Beregalov authored
This code looks useless, t3e3_contigmemory_size is neither declared nor used anywhere else, as well as T3E3_USE_CONTIGMALLOC. Signed-off-by:
-
Michał Mirosław authored
Signed-off-by:
Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by:
-
Olaf Hering authored
make /sys/module/hv_vmbus/parameters/vmbus_loglevel writeable by root. Signed-off-by:
Olaf Hering <olaf@aepfle.de> Signed-off-by:
-
Olaf Hering authored
tasklet_init() takes an integer, so use one right away. Signed-off-by:
-
Olaf Hering authored
Change types in vmbus_on_event() to u32 since the input is u32 as well. Pass u32 to process_chn_event() instead of casting arg to void* and back. Update printk to reflect type change. Signed-off-by:
-
Olaf Hering authored
Reduce indention in vmbus_on_event() by converting two if (var) to if (!var) Signed-off-by:
-
K. Y. Srinivasan authored
We don't support removable media in Hyper-V block driver. Get rid of blkvsc_check_events() as it is efectively "dead code". Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
Hank Janssen <hjanssen@microsoft.com> Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of the forward declaration of blkvsc_getgeo() by moving the code around. Signed-off-by:
Abhishek Kane <v-abkane@microsoft.com> Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of the forward declaration of blkvsc_open() by moving the code around. Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of the forward declaration of blkvsc_check_events() by moving the code around. Signed-off-by:
-
K. Y. Srinivasan authored
Get rid of the forward declaration of blkvsc_submit_request() by moving the code around. Signed-off-by:
-
K. Y. Srinivasan authored
As part of the cleanup of the I/O request structure, allocate them zeroed out. This fixes a bug that was introduced in the patch-set titled: Staging: hv: Cleanup-storage-drivers-phase-II. A corrected version of this patch-set was sent out earlier, however the earlier (buggy) version of this patch-set was already applied. This patch fixes the problem. Signed-off-by:
-
K. Y. Srinivasan authored
Properly capture the error state after the completion of I/O. This fixes a bug that was introduced in the patch-set titled: Staging: hv: Cleanup-storage-drivers-phase-II. A corrected version of this patch-set was sent out earlier, however the earlier (buggy) version of this patch-set was already applied. This patch fixes the problem. Signed-off-by:
-
- 19 Apr, 2011 2 commits
-
-
Greg Kroah-Hartman authored
This handles the removal of the samsung-laptop driver and other minor merge issues. Signed-off-by: -
Linus Torvalds authored
-
- 18 Apr, 2011 4 commits
-
-
git://codeaurora.org/quic/kernel/davidb/linux-msmLinus Torvalds authored
* 'for-39-rc4' of git://codeaurora.org/quic/kernel/davidb/linux-msm: msm: timer: fix missing return value msm: Remove extraneous ffa device check
-
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/inputLinus Torvalds authored
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input: Input: xen-kbdfront - fix mouse getting stuck after save/restore Input: estimate number of events per packet Input: evdev - indicate buffer overrun with SYN_DROPPED Input: document event types and codes and their intended use Input: add KEY_IMAGES specifically for AL Image Browser Input: twl4030_keypad - fix potential NULL dereference in twl4030_kp_probe() Input: h3600_ts - fix error handling at connect Input: twl4030_keypad - avoid potential NULL-pointer dereference
-
git://git.kernel.dk/linux-2.6-blockLinus Torvalds authored
* 'for-linus' of git://git.kernel.dk/linux-2.6-block: block: add blk_run_queue_async block: blk_delay_queue() should use kblockd workqueue md: fix up raid1/raid10 unplugging. md: incorporate new plugging into raid5. md: provide generic support for handling unplug callbacks. md - remove old plugging code. md/dm - remove remains of plug_fn callback. md: use new plugging interface for RAID IO. block: drop queue lock before calling __blk_run_queue() for kblockd punt Revert "block: add callback function for unplug notification" block: Enhance new plugging support to support general callbacks
-
git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpcLinus Torvalds authored
* 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc: powerpc/powermac: Build fix with SMP and CPU hotplug powerpc/perf_event: Skip updating kernel counters if register value shrinks powerpc: Don't write protect kernel text with CONFIG_DYNAMIC_FTRACE enabled powerpc: Fix oops if scan_dispatch_log is called too early powerpc/pseries: Use a kmem cache for DTL buffers powerpc/kexec: Fix regression causing compile failure on UP powerpc/85xx: disable Suspend support if SMP enabled powerpc/e500mc: Remove CPU_FTR_MAYBE_CAN_NAP/CPU_FTR_MAYBE_CAN_DOZE powerpc/book3e: Fix CPU feature handling on 64-bit e5500 powerpc: Check device status before adding serial device powerpc/85xx: Don't add disabled PCIe devices
-
