this is a view for a portal type existing in erp5_budget

there is no "Method", but there is a property sheet "CatalogFilter"

Solver Type only exists in erp5_simulation it does not make sense to have
forms for solver types in base.

This was no longer used and replaced by Entity_addEventDialog since
fbd062eb (Allow creation of events from any document, 2011-02-25)

The spec says "see _getTypeBaseMethod" and _getTypeBaseMethod walks the
portal type class mro, which contain property sheets.

Probably we should be using interfaces instead, let's do this simple way
first and we'll improve later.

For most of theses, we can not change without risking to break
compatibility. Some of them are misnamed legacy fields library or some
forms that still needs to be updated to use field libraries.

Checking some conventions for form, dialog and reports based on
https://www.erp5.com/documentation/developer/guideline/programming/
and https://www.erp5.com/documentation/developer/guideline/module/

For now we implement only a few checks, we will extend later.

jsl complains about "class" in object literals, but there's nothing wrong
with this.

portal_skins/erp5_vcs/gadget_vcs_status.js
(17): SyntaxError: invalid property id
      class: true,

This fixes the testNamingConvention failure:

    AssertionError: erp5_vcs/BusinessTemplate_viewVcsStatusDialog : your_commit_json : can't be empty

Since this field is in bottom group, the label is not rendered, so it's
not needed to hide field name with some TALES.

This dialog had a proxy field to another field from the same dialog (
BusinessTemplate_viewGitLogin/your_auth ).
When dialog was renamed, proxy field got broken.

To ease maintenance, proxy to the same field as BusinessTemplate_viewGitLoginDialog/your_auth
is using.

Follow naming convention: https://www.erp5.com/documentation/developer/guideline/programming/erp5-Guideline.Programming.Naming.Conventions/#dialog-form-name-is-postfixed-with-dialog

* update template tool configuration
* create working copy
* create skin folder
* throw away local changes

Add a gadget to display and select the list of changes.

The gadget will show the selected diff to change the selection if needed.

Changelog can also be directly entered in the gadget to quickly switch the view while writing it.

Use usual ERP5 page template to commit bt5 changes from ERP5.

Use an hidden field to propagate all needed input values in case of an exception.
This single field will keep a json value, to simplify the maintainance of all forms using it (instead of many string fields).

Stop accessing the REQUEST directly, and rely on ERP5 navigation scripts (like Base_redirect) instead.

See ea219b74

See d7a4c3fc

This fix issues due to the publish method wiich is calling
request.close wich then call setSite without a site to reset it

Changes dones in tests that have since been moved to bt5 have been reported in them