Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Repository
  • gitlab-ce
  • spec
  • workers
  • process_commit_worker_spec.rb
Find file BlameHistoryPermalink
  • Chad Woolley's avatar
    Refactor Issuable services to subclass to BaseContainerService · b2e91499
    Chad Woolley authored Apr 12, 2021
    What:
    
    - Continuation of refactoring discussed and started in
      https://gitlab.com/gitlab-org/gitlab/-/merge_requests/30979#note_337747596
    - Refactors Issuable-related service classes to subclass
      `BaseContainerService` instead of `BaseService`.
    
    Why:
    
    - This provides a greater degree of type safety in order to
      more easily and safely introduce a new named argument
      `spam_params` to support
      https://gitlab.com/gitlab-org/gitlab/-/merge_requests/58603
    - The additional type safety will also make future refactors
      easier and less risky
    
    How:
    
    - Note that this is an incremental commit.
      In a subsequent commit, the
      first argument will be changed to `group` in the
      `Epics::BaseService` hierarchy.
    b2e91499
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7