Merge branch 'jj-respect-tracking-better' into 'master'

Stop pushing experiment data to the client (using Gon) when we shouldn't

See merge request gitlab-org/gitlab!56405

app/experiments/application_experiment.rb

@@ -10,9 +10,10 @@ class ApplicationExperiment < Gitlab::Experiment # rubocop:disable Gitlab/Namesp
   end
 
   def publish(_result = nil)
+    return unless should_track? # don't track events for excluded contexts
+
     track(:assignment) # track that we've assigned a variant for this context
 
-    # push the experiment data to the client
     begin
       Gon.push({ experiment: { name => signature } }, true) # push the experiment data to the client
     rescue NoMethodError

spec/experiments/application_experiment_spec.rb

@@ -58,6 +58,15 @@ RSpec.describe ApplicationExperiment, :experiment do
   end
 
   describe "publishing results" do
+    it "doesn't track or push data to the client if we shouldn't track", :snowplow do
+      allow(subject).to receive(:should_track?).and_return(false)
+      expect(Gon).not_to receive(:push)
+
+      subject.publish(:action)
+
+      expect_no_snowplow_event
+    end
+
     it "tracks the assignment" do
       expect(subject).to receive(:track).with(:assignment)
 

spec/support/gitlab_experiment.rb

@@ -6,6 +6,7 @@ require_relative 'stub_snowplow'
 
 # This is a temporary fix until we have a larger discussion around the
 # challenges raised in https://gitlab.com/gitlab-org/gitlab/-/issues/300104
+require Rails.root.join('app', 'experiments', 'application_experiment')
 class ApplicationExperiment # rubocop:disable Gitlab/NamespacedClass
   def initialize(...)
     super(...)