Merge branch 'pass-fake-diff-refs-by-building-a-commit' into 'master'

Refactor Diff Note tests to support factories parent strategy

See merge request gitlab-org/gitlab!41690

spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb

@@ -44,7 +44,7 @@ RSpec.describe 'Adding a DiffNote' do
     it_behaves_like 'a Note mutation when there are active record validation errors', model: DiffNote
 
     context do
-      let(:diff_refs) { build(:merge_request).diff_refs } # Allow fake diff refs so arguments are valid
+      let(:diff_refs) { build(:commit).diff_refs } # Allow fake diff refs so arguments are valid
 
       it_behaves_like 'a Note mutation when the given resource id is not for a Noteable'
     end

spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb

@@ -47,7 +47,7 @@ RSpec.describe 'Adding an image DiffNote' do
     it_behaves_like 'a Note mutation when there are active record validation errors', model: DiffNote
 
     context do
-      let(:diff_refs) { build(:merge_request).diff_refs } # Allow fake diff refs so arguments are valid
+      let(:diff_refs) { build(:commit).diff_refs } # Allow fake diff refs so arguments are valid
 
       it_behaves_like 'a Note mutation when the given resource id is not for a Noteable'
     end