- 29 Jan, 2020 40 commits
-
-
Thomas Randolph authored
There are basically 2 big updates in this commit: 1) Split up each range type handler into a separate function (plus a few helper functions). 2) Export a type infer-er The type infer-er is useful internally, but also helps me feel more confident about code changes. In theory no type should ever collide with another type, so this function is kind of like the "canary in the coal mine" in that we should always be able to test a 1:1 range type from this function. If we can test the types thoroughly, we can be more confident each respective handler is working on the right set of data. On that note, splitting up the logic for each range type makes me feel much more confident that each one is handled in a way that doesn't conflict with any other. More importantly, any potential changes to an existing range type or additions of new range types will: A) Not cause any changes to the existing ones and B) Scale gracefully On that final note of graceful scaling, I find the (very common) method of basically extending a long if/else if/else block to be frightening from the perspective of ever needing to add things. I've found the method I use here (a dictionary lookup, in a bunch of cases) to be much easier to reason about: every addition adds a single dictionary entry, and the JS selects it (O(1)) when it's needed.
-
Miguel Rincon authored
The date ranges can be used to represent periods of time relative to arbitrary points in time, such as a fixed date or the current moment.
-
Douglas Barbosa Alexandre authored
Create backend route for dedicated Release page See merge request gitlab-org/gitlab!23792
-
Sid Sijbrandij authored
Remove existing to clarify examples See merge request gitlab-org/gitlab!23987
-
Alessio Caiazza authored
Refactor merge request routing See merge request gitlab-org/gitlab!23782
-
Phil Hughes authored
Added Monaco-based editor lite version Closes #198618 See merge request gitlab-org/gitlab!23767
-
Denys Mishunov authored
This introduces the bare-minimum Monaco editor for single-file edits like those for Snippets, blobs and CI/CD configurations
-
Phil Hughes authored
Merge branch '197973-staged-and-unstaged-modification-tooltip-for-file-with-staged-changes-in-web-ide' into 'master' Resolve "Staged and unstaged modification" tooltip See merge request gitlab-org/gitlab!23847
-
Marcel van Remmerden authored
-
Stan Hu authored
Move SpamCheckService into spam folder See merge request gitlab-org/gitlab!23915
-
Douglas Barbosa Alexandre authored
Support design repo in project namespace transfer See merge request gitlab-org/gitlab!23573
-
Nathan Friend authored
This commit adds the backend route for the dedicated release show page. This page is hidden behind a `release_show_page` feature flag which is disabled by default.
-
Mayra Cabrera authored
Delete a comment See merge request gitlab-org/gitlab!23937
-
Lucy Fox authored
-
James Lopez authored
Add a `class_name: "::Project"` to a `belongs_to :project` in a spec Closes #199424 See merge request gitlab-org/gitlab!23979
-
Nick Thomas authored
Merge branch '39505-extend-the-ability-to-clone-a-dashboard-so-it-would-copy-the-custom-metrics' into 'master' Extend the ability to clone a dashboard so it would copy the custom metrics See merge request gitlab-org/gitlab!21923
-
Tim Rizzi authored
-
Rémy Coutable authored
Fix missing 'Pipeline schedules' link Closes #199088 See merge request gitlab-org/gitlab!23842
-
Adam Hegyi authored
- Add test case for FOSS and EE project and group navbar structure.
-
Rémy Coutable authored
Feature flag: adding of use_core_delta_islands See merge request gitlab-org/gitlab!23850
-
Natalia Tepluhina authored
Remove Elastic Stack cluster application feature flag See merge request gitlab-org/gitlab!23058
-
Adrien Kohlbecker authored
Enable the app by default
-
Mikolaj Wawrzyniak authored
To make metrics dashboard clonning fully function, we need to inclued custom metrics defined by user.
-
Achilleas Pipinellis authored
Update Dependency Proxy to ultimate only See merge request gitlab-org/gitlab!23925
-
Tim Rizzi authored
-
Achilleas Pipinellis authored
update link to BATS See merge request gitlab-org/gitlab!23866
-
Mikolaj Wawrzyniak authored
-
Achilleas Pipinellis authored
docs: Revise upgrade versions in update readme See merge request gitlab-org/gitlab!23952
-
Rémy Coutable authored
-
Rémy Coutable authored
Optimize ref name lookups in archive downloads See merge request gitlab-org/gitlab!23890
-
Achilleas Pipinellis authored
More explicit Praefect documentation See merge request gitlab-org/gitlab!23853
-
Zeger-Jan van de Weg authored
After another demo with the team, the configuration docs weren't explicit enough. This change updates the docs to be even more explicit.
-
Nick Thomas authored
Add only backend API for view arbitrary commit in merge request - issue #62817 See merge request gitlab-org/gitlab!23701
-
Anwar Sadath authored
-
Martin Wortschack authored
Fix nav link in security submenu See merge request gitlab-org/gitlab!23775
-
Martin Wortschack authored
Changed color of allowed to fail badge from danger to warning See merge request gitlab-org/gitlab!23437
-
Dimitrie Hoekstra authored
The color was not inline with our color design guidelines and was giving off the impression of an error.
-
Andreas Brandl authored
Allow custom Guard command See merge request gitlab-org/gitlab!23947
-
Stan Hu authored
Upgrade Gitaly to v1.85.0 See merge request gitlab-org/gitlab!23945
-
GitalyBot authored
This upgrade deprecates the branch parameter in UserSquash and removes the revision parameter from GetAllLFSPointersRequest.
-