- 14 Apr, 2021 40 commits
-
-
Stan Hu authored
-
Stan Hu authored
During a merge, we attempt to find a matching merge request with a SHA using a replica that should be up-to-date with the primary for a given PostgreSQL log sequence number (LSN). However, there is a race condition that can happen if service discovery alters the host list after this check has taken place. This most likely happens when a Web worker starts: 1. When Rails starts up for the first time, there is a 1-minute or 2-minute delay before service discovery finds replicas (see https://gitlab.com/gitlab-org/gitlab/-/issues/271575). 2. During this time `LoadBalancer#all_caught_up?` will return `true`. This will indicate to the Web worker that it can use replicas and does not have to use the primary. 3. During a request, service discovery may load all the replicas and change the host list. As a result, the next read may be directed to a lagging replica. However, this may cause a merge to fail if it cannot find a match. When a user merges a merge request, Sidekiq logs the minimum LSN needed to match a merge request for the API. If we have this LSN, we now: 1. Select from the available list of replicas that meet this LSN requirement. 2. Store this subset for the given request. 3. Round-robin reads with this subset of replicas. Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/247857
-
Stan Hu authored
Add documentation for configuring Microsoft Graph with MailRoom See merge request gitlab-org/gitlab!59084
-
Mark Lapierre authored
Update old test case link with max comments See merge request gitlab-org/gitlab!59410
-
Mark Lapierre authored
Update older testcase issue links See merge request gitlab-org/gitlab!59311
-
Stan Hu authored
-
Mike Jang authored
Document permission to manage group push rules See merge request gitlab-org/gitlab!59333
-
Stan Hu authored
Prevent manual upload of cloud license See merge request gitlab-org/gitlab!58709
-
Scott Hampton authored
Highlight paid features during active trial - Part 1 of 4 See merge request gitlab-org/gitlab!56155
-
Dallas Reedy authored
Part 1 of 4. Sets the groundwork for the “Highlight paid features during active trial” experiment. Mainly, it sets up a new experiment using the `gitlab-experiment` gem (GLEX) and creates the initial badge component that will be used as the building block for the rest of the experiment features.
-
Mike Jang authored
Docs: Surface merge approval rules in permissions list See merge request gitlab-org/gitlab!59384
-
Paul Slaughter authored
Allow Add Comment To Review See merge request gitlab-org/gitlab!51718
-
-
Dmytro Zaporozhets (DZ) authored
Update UI text in the drone integration See merge request gitlab-org/gitlab!59231
-
Marcel Amirault authored
-
Yannis Roussos authored
Merge branch '323676-add-index-on-created-at-web-hook-id-to-partitioned-web-hook-logs' into 'master' Add index to partitioned web_hook_logs (Part 1 of 3) See merge request gitlab-org/gitlab!59261
-
Fabio Pitino authored
Return 403 when job is deleted See merge request gitlab-org/gitlab!59382
-
Tyler Amos authored
Updates the LicenseController#create action to prevent cloud licenses from being created. Presents an alert to the user to upload a valid license. Improve LicenseController specs with expectations on the creation of License records.
-
Tiffany Rea authored
-
Yannis Roussos authored
- Add the index on (created_at, web_hook_id) that is defined for web_hook_logs to the partitioned version of the table
-
Mayra Cabrera authored
Fix a 'Style/RegexpLiteralMixedPreserve' RuboCop offense See merge request gitlab-org/gitlab!59404
-
Nick Thomas authored
Document On-demand Scans Authentication options See merge request gitlab-org/gitlab!59169
-
Dheeraj Joshi authored
-
Nick Thomas authored
Merge branch 'philipcunningham-enable-additional-fields-feature-flag-by-default-292897' into 'master' Enable DAST extra fields feature flag by default See merge request gitlab-org/gitlab!58859
-
Steve Azzopardi authored
When a job get's deleted a 404 is return which is HTTP semantically correct. A 404 can be a temporary problem on the network which the Runner will retry the request. This prevents from deleted jobs running until timeout. reference https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27765
-
Suzanne Selhorn authored
Promote dependencies section See merge request gitlab-org/gitlab!59338
-
Suzanne Selhorn authored
Document Billable Memberships API See merge request gitlab-org/gitlab!59315
-
Jason Goodman authored
-
Arturo Herrero authored
Active integrations should be displayed in a separate table See merge request gitlab-org/gitlab!57198
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Etienne Baqué authored
Add debug info to Pages::LookupPath::LegacyStorageDisabledError See merge request gitlab-org/gitlab!59265
-
Matthias Käppler authored
Restrict group level approval settings to top level group See merge request gitlab-org/gitlab!59225
-
Vitali Tatarintev authored
Add Source Members Url to Billable Memberships API See merge request gitlab-org/gitlab!59312
-
Rémy Coutable authored
Externalise strings in sessions/_new_crowd.html.haml See merge request gitlab-org/gitlab!58269
-
Marvin Karegyeya authored
-
Amy Qualls authored
Add fork form FF to docs See merge request gitlab-org/gitlab!56461
-
Samantha Ming authored
-
Alper Akgun authored
Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/security See merge request gitlab-org/gitlab!58323
-
Abdul Wadood authored
-
Stan Hu authored
Bump recommended Redis version from 4.0 to 5.0 See merge request gitlab-org/gitlab!59072
-