• Arnaud Ebalard's avatar
    rtc: rtc-isl12057: add isil,irq2-can-wakeup-machine property for in-tree users · 298ff012
    Arnaud Ebalard authored
    Current in-tree users of ISL12057 RTC chip (NETGEAR ReadyNAS 102, 104 and
    2120) do not have the IRQ#2 pin of the chip (associated w/ the Alarm1
    mechanism) connected to their SoC, but to a PMIC (TPS65251 FWIW).  This
    specific hardware configuration allows the NAS to wake up when the alarms
    rings.
    
    Recently introduced alarm support for ISL12057 relies on the provision of
    an "interrupts" property in system .dts file, which previous three users
    will never get.  For that reason, alarm support on those devices is not
    function.  To support this use case, this patch adds a new DT property for
    ISL12057 (isil,irq2-can-wakeup-machine) to indicate that the chip is
    capable of waking up the device using its IRQ#2 pin (even though it does
    not have its IRQ#2 pin connected directly to the SoC).
    
    This specific configuration was tested on a ReadyNAS 102 by setting an
    alarm, powering off the device and see it reboot as expected when the
    alarm rang w/:
    
      # echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
      # shutdown -h now
    
    As a side note, the ISL12057 remains in the list of trivial devices,
    because the property is not per se required by the device to work but can
    help handle system w/ specific requirements.  In exchange, the new feature
    is described in details in a specific documentation file.
    Signed-off-by: default avatarArnaud Ebalard <arno@natisbad.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Alessandro Zummo <a.zummo@towertech.it>
    Cc: Peter Huewe <peter.huewe@infineon.com>
    Cc: Linus Walleij <linus.walleij@linaro.org>
    Cc: Thierry Reding <treding@nvidia.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Darshana Padmadas <darshanapadmadas@gmail.com>
    Cc: Rob Herring <rob.herring@calxeda.com>
    Cc: Pawel Moll <pawel.moll@arm.com>
    Cc: Stephen Warren <swarren@wwwdotorg.org>
    Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
    Cc: Grant Likely <grant.likely@linaro.org>
    Cc: Rob Landley <rob@landley.net>
    Cc: Jason Cooper <jason@lakedaemon.net>
    Cc: Guenter Roeck <linux@roeck-us.net>
    Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
    Cc: Kumar Gala <galak@codeaurora.org>
    Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    298ff012
rtc-isl12057.c 18.2 KB