• Ladi Prosek's avatar
    KVM: nVMX: fix SMI injection in guest mode · 72e9cbdb
    Ladi Prosek authored
    Entering SMM while running in guest mode wasn't working very well because several
    pieces of the vcpu state were left set up for nested operation.
    
    Some of the issues observed:
    
    * L1 was getting unexpected VM exits (using L1 interception controls but running
      in SMM execution environment)
    * SMM handler couldn't write to vmx_set_cr4 because of incorrect validity checks
      predicated on nested.vmxon
    * MMU was confused (walk_mmu was still set to nested_mmu)
    
    Intel SDM actually prescribes the logical processor to "leave VMX operation" upon
    entering SMM in 34.14.1 Default Treatment of SMI Delivery. What we need to do is
    basically get out of guest mode and set nested.vmxon to false for the duration of
    SMM. All this completely transparent to L1, i.e. L1 is not given control and no
    L1 observable state changes.
    
    To avoid code duplication this commit takes advantage of the existing nested
    vmexit and run functionality, perhaps at the cost of efficiency. To get out of
    guest mode, nested_vmx_vmexit with exit_reason == -1 is called, a trick already
    used in vmx_leave_nested. Re-entering is cleaner, using enter_vmx_non_root_mode.
    
    This commit fixes running Windows Server 2016 with Hyper-V enabled in a VM with
    OVMF firmware (OVMF_CODE-need-smm.fd).
    Signed-off-by: default avatarLadi Prosek <lprosek@redhat.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    72e9cbdb
vmx.c 344 KB