• Carlo Caione's avatar
    arm64: dts: meson: Fix IRQ trigger type for macirq · 8b3e6f89
    Carlo Caione authored
    A long running stress test on a custom board shipping an AXG SoCs and a
    Realtek RTL8211F PHY revealed that after a few hours the connection
    speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time
    the 'macirq' (eth0) IRQ would stop being triggered at all and as
    consequence the GMAC IRQs never ACKed.
    
    After a painful investigation the problem seemed to be due to a wrong
    defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of
    EDGE_RISING.
    
    The change in the macirq IRQ type also solved another long standing
    issue affecting this SoC/PHY where EEE was causing the network
    connection to die after stressing it with iperf3 (even though much
    sooner). It's now possible to remove the 'eee-broken-1000t' quirk as
    well.
    
    Fixes: feb3cbea ("ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage")
    Fixes: 6d28d577 ("ARM64: dts: meson-axg: fix ethernet stability issue")
    Reviewed-by: default avatarJerome Brunet <jbrunet@baylibre.com>
    Tested-by: default avatarJerome Brunet <jbrunet@baylibre.com>
    Acked-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
    Signed-off-by: default avatarCarlo Caione <ccaione@baylibre.com>
    Signed-off-by: default avatarKevin Hilman <khilman@baylibre.com>
    8b3e6f89
meson-gx.dtsi 13.2 KB