• unknown's avatar
    Federated Storage Engine, bug 9925 "Federated query processor (step 2 or step 3) not using logic in · 6743f0ee
    unknown authored
    WHERE statement"
    
    
    sql/ha_federated.cc:
      Changes per Jimw's review. 
      
      notes about some suggestions:
      
      1. Tried to replace my_sprintf with strxmov, but had problems. Couldn't 
         get the test suite to run at all, and could not find any particular
         error. Since this is something that is not critical, I'll leave it
         as is for now.
      2. I would like to use my_error to create all of my error messages, but 
         cannot figure out how to get it to take more than one argument to be
         passed to the error message (I tried this once but had errors, and 
         cannot find an example of how to get it to work despite seeing messages
         with obviously more than one arg
      3. Replaced all string building from literals to defined SQL string pieces
         such as "SELECT ", "FROM " ...
      4. Format fixes, spacing fixes completed
      5. Removed records_in_range records calculation functionality
    sql/ha_federated.h:
      Formatting changes, new defines for SQL query string tokens
    sql/share/errmsg.txt:
      changed 'SRC' to 'SOURCE' per Jimw's review
    6743f0ee
ha_federated.h 8.56 KB