1. 15 May, 2007 1 commit
    • marko's avatar
      branches/zip: Minor cleanup. · 19569a8b
      marko authored
      page_cur_tuple_insert(), page_cur_rec_insert(): Improve the documentation.
      Note that the physical position of page_cursor may change.
      
      page_cur_rec_insert(), page_cur_insert_rec_low(), page_cur_insert_rec_zip():
      Add a const qualifier to the parameter rec.
      19569a8b
  2. 14 May, 2007 1 commit
  3. 07 May, 2007 1 commit
    • marko's avatar
      branches/zip: Fix two bugs. · fbc6f37c
      marko authored
      mtr_commit(): Do not acquire the log mutex if no log records are to be written.
      
      ibuf_set_free_bits_func(): Do not clear mtr.modifications, because that would
      prevent the dirty insert buffer bitmap block from being moved to the flush
      list.  Instead, assume that mtr_commit() will not acquire log_sys->mutex
      because redo logging is disabled.
      
      buf_page_init_for_read(): I/O-fix the block before buf_buddy_alloc(), because
      the newly allocated block could otherwise be reused by the compressed page.
      fbc6f37c
  4. 06 May, 2007 5 commits
    • marko's avatar
      branches/zip: When reading pages for merging buffered inserts, request that · dd529ee4
      marko authored
      the pages be decompressed.
      
      buf_read_page_low(), buf_page_init_for_read(): Add parameter "unzip".
      dd529ee4
    • marko's avatar
      branches/zip: ibuf_set_free_bits_func(): Disable redo logging when · 2e739224
      marko authored
      crash recovery is in progress.  This avoids a hang when
      btr_parse_page_reorganize(), called from an I/O handler thread,
      attempts to acquire log_sys->mutex while it is being held by
      the main thread (the one that runs innobase_init()).  This change
      was committed accidentally.  It may be unsafe to clear
      mtr.modifications, because buf_page_release() at mtr_commit() may
      forget to put modified pages to the flush list.
      
      Cleanup: Remove the "type" parameter from many ibuf functions.
      Let the caller check that !dict_index_is_clust().  This should avoid
      function calls and register spilling.
      
      ibuf_set_free_bits_func(), ibuf_set_free_bits(): Remove the parameter "type".
      
      ibuf_reset_free_bits_with_type(): Rename to ibuf_reset_free_bits().
      Remove the parameter "type".
      
      ibuf_update_free_bits_if_full(), ibuf_update_free_bits_zip(),
      ibuf_update_free_bits_low(), ibuf_update_free_bits_for_two_pages_low():
      Remove the parameter "index".
      2e739224
    • marko's avatar
    • marko's avatar
      branches/zip: Minor cleanup. · fdb017ff
      marko authored
      log_write_up_to(): Replace if-else if-else with a switch block.
      
      log_archive_do(): Remove an excess mutex_enter().  Replace if-else if-else
      with a switch block.  (This function is not included unless UNIV_LOG_ARCHIVE
      is defined.)
      fdb017ff
    • marko's avatar
      08582d6d
  5. 03 May, 2007 1 commit
  6. 02 May, 2007 1 commit
  7. 30 Apr, 2007 2 commits
  8. 17 Apr, 2007 4 commits
    • marko's avatar
      branches/zip: Minor cleanup. · e0cb06f8
      marko authored
      Add __attribute__((const)) or __attribute__((pure)) to various
      mach_read functions.
      
      dtype_new_read_for_order_and_null_size(): Remove a statement
      without effect: mach_read_from_2(buf + 4).
      e0cb06f8
    • marko's avatar
      branches/zip: Reintroduce the local variables "sorted" that were removed · a55e2191
      marko authored
      in r1445.  They are needed after all, but apparently the tests do not
      actually verify that the records are sorted.  (Also, a buffer overflow
      will occur in index_merge_innodb.test if MERGE_BLOCK_SIZE is made smaller.)
      a55e2191
    • marko's avatar
      branches/zip: Clean up fast index creation. · 93558a3b
      marko authored
      Correct the language of some comments.  Eliminate the local variables
      "num_of_merges" (renamed to "sorted" in one function).
      93558a3b
    • marko's avatar
      branches/zip: Clean up. · 65a34315
      marko authored
      cmp_rec_rec_with_match(): Initialize ret=0.  Remove assignments ret=0.
      
      rec_init_offsets(): Remove bogus comment.
      65a34315
  9. 16 Apr, 2007 4 commits
  10. 13 Apr, 2007 1 commit
  11. 12 Apr, 2007 3 commits
    • marko's avatar
      branches/zip: Clean up fast index creation. · 4e14254e
      marko authored
      row_merge_read(), row_merge_write(): Add UNIV_LIKELY hints.
      
      row_merge_sort_linked_list_in_disk(): Reduce the scope of many variables.
      Eliminate the variable "selected".
      4e14254e
    • marko's avatar
      branches/zip: Minor cleanup of merge_file_t and merge_block_header_t. · 13817f1d
      marko authored
      Replace byte offsets of type dulint with block offsets of type ulint.
      Avoid references to MERGE_BLOCK_SIZE.
      
      Improve the language of some comments.
      
      row_merge_insert_index_tuples(), row_merge_sort_linked_list_in_disk():
      Make the offset a ulint.
      
      row_merge_read(), row_merge_write(): Helper functions.  Return the
      status of os_file_read() and os_file_write().  TO DO: check the status
      in the callers.
      13817f1d
    • marko's avatar
      branches/zip: More cleanup of fast index creation. · 96e90174
      marko authored
      innobase_create_temporary_tablename(): Add static qualifier.  Allocate
      the memory from heap.  Return a fixed identifier.
      
      ha_innobase::add_index(): Allocate all memory from a single heap.
      Simplify error handling.  Use a fixed prefix for temporary table names,
      because only one add_index() can be active for a given table.
      
      mem_heap_empty_noninline(): New function, to be called from ha_innodb.cc.
      
      row_build_index_for_mysql(): Remove the parameter new_primary.
      96e90174
  12. 11 Apr, 2007 4 commits
    • marko's avatar
      branches/zip: Clean up fast index creation. · 5c54c363
      marko authored
      row_merge_remove_index(), row_merge_rename_index(): Remove risky sprintf()
      calls.  Make use of named literals and que_eval_sql().
      5c54c363
    • marko's avatar
      branches/zip: Some more cleanup of fast index creation. · 4b1e9a91
      marko authored
      Move more definitions from row0mysql.h to row0mysql.c.  Remove the
      unused definition of merge_thread.
      
      merge_index_def_t: Replace merge_index_field_t** with merge_index_field_t*.
      Use mem_heap_strdup() when copying strings.
      
      ha_innobase::add_index(): Avoid excessive use of current_thd.
      4b1e9a91
    • marko's avatar
      branches/zip: row_merge_sort_linked_list_in_disk(): Remove some unnecessary · e3e30549
      marko authored
      assignments.  A memory leak remains at "goto error_handling": the memory
      allocated with row_merge_block_create() in the beginning of this function
      will not be freed.
      e3e30549
    • marko's avatar
      branches/zip: Initial clean up of the merge sort subsystem. · fcfed198
      marko authored
      Define the merge_rec_ structures in row0merge.c instead of
      row0merge.h.  They are not used in the interface defined in row0merge.h.
      
      row_merge_create_file_structure(): Rename to row_merge_file_create().
      Input a pointer to a pre-allocated block of memory.
      
      row_merge_read_clustered_index(): Replace merge_file_t** with merge_file_t*.
      
      row_merge_sort_and_insert_thread(): Remove the declaration.
      This function was never defined or called.
      
      row_merge_is_index_usable(): Correct the formatting.
      
      row_build_index_for_mysql(): Allocate an array of merge_file_t instead
      of an array of pointers to merge_file_t.
      fcfed198
  13. 10 Apr, 2007 2 commits
  14. 04 Apr, 2007 2 commits
    • marko's avatar
      branches/zip: Fix the merge of branches/fast-index-creation -r1413 in r1414. · 5650bfbe
      marko authored
      innodb.test: The error code 1540 has been renumbered to 1542.
      innodb.result: Adjust the expected value of Innodb_buffer_pool_pages_total.
      Something may have changed in the BLOB handling in branches/zip.
      
      ha_innodb.cc: Add ha_innobase:: prefix to some DBUG_ENTER macros.
      
      row_merge_create_temporary_table(): Free the heap only after invoking
      row_create_table_for_mysql().  The table->col_names points to the heap
      until the system columns are added by row_create_table_for_mysql().
      
      TODO: use the filename-safe encoding in temporary table names.  Test
      extensively under Valgrind and fix all errors found.  Eliminate
      merge_rec_t and rewrite row0merge.c to write the records directly to
      the merge blocks.
      5650bfbe
    • marko's avatar
      branches/zip: Merge branches/fast-index-creation -r1413. · a47b9e64
      marko authored
      Fix some bugs.  The tests innodb and innodb-index fail, but that might
      be due to an old MySQL source tree being used.
      a47b9e64
  15. 02 Apr, 2007 1 commit
  16. 29 Mar, 2007 2 commits
    • marko's avatar
      branches/zip: Make TRUNCATE TABLE recreate single-table tablespaces. · 34238330
      marko authored
      dict_truncate_index_tree(): Add the parameter space for specifying the
      new tablespace identifier of a single-table tablespace that has been
      recreated.  When SYS_INDEXES.PAGE_NO == FIL_NULL, do not abort but
      create the index tree.
      
      fil_discard_tablespace(): Pass the return code from fil_delete_tablespace().
      
      row_truncate_table_for_mysql(): Attempt to discard and recreate
      single-table tablespaces.  Reassign the tablespace identifier both in
      the data dictionary (SYS_TABLES and SYS_INDEXES) and in the data
      dictionary cache.
      34238330
    • marko's avatar
      branches/zip: Minor cleanup in rollback. · 9f505aa1
      marko authored
      trx_undo_left(): Add const qualifiers.
      
      trx_undo_page_report_insert(): Use exact trx_undo_left() limit.
      Remove a duplicated trx_undo_left() check.
      
      trx_undo_page_report_modify(): Eliminate the local variable len.
      Document that no prefix for BLOBs needs to be stored in the undo log.
      Lump two trx_undo_left() checks together.
      9f505aa1
  17. 28 Mar, 2007 4 commits
    • marko's avatar
      branches/zip: btr_cur_pessimistic_update(): Add parameter heap. · 750e130c
      marko authored
      Previously, when big_rec was returned, the fields would point to
      freed memory.  The memory heap was allocated locally, and the data tuple
      was allocated from the heap, and the big_rec would point to some fields
      in the data tuple.
      
      row_ins_clust_index_entry_by_modify(): Add parameter heap,
      for the same reason.
      750e130c
    • marko's avatar
      e4d8b192
    • marko's avatar
      branches/zip: buf_LRU_block_free_non_file_page(): Flag block->frame · 1cd52812
      marko authored
      allocated before overwriting some fields and flagging the frame freed.
      Some of the buffer frame may have been flagged freed by the user
      (such as mem_heap).
      1cd52812
    • marko's avatar
      branches/zip: Add Valgrind instrumentation to the InnoDB memory management · 3a23bff3
      marko authored
      functions.
      
      ut_malloc_low(): Flag the block with UNIV_MEM_ALLOC().  Do not flag the
      block with UNIV_MEM_FREE() in ut_free(), because it would cause bogus
      Valgrind warnings in the underlying memory allocator.
      
      mem_pool_create(): Flag the data area with UNIV_MEM_FREE().
      
      mem_pool_fill_free_list(): Flag the area header with UNIV_MEM_ALLOC().
      
      mem_area_alloc(): Flag the data area with UNIV_MEM_ALLOC().
      
      mem_area_free(): Flag the data area with UNIV_MEM_FREE().
      
      mem_heap_alloc(): Flag the buffer with UNIV_MEM_ALLOC().
      
      mem_heap_block_free(): Flag the block with UNIV_MEM_FREE().
      
      mem_heap_free_top(): Flag the block with UNIV_MEM_FREE().
      3a23bff3
  18. 14 Mar, 2007 1 commit
    • marko's avatar
      branches/zip: Minor cleanup. · 6e8da36b
      marko authored
      btr_rec_free_updated_extern_fields(): Remove the parameter
      do_not_free_inherited, which is always passed as TRUE.
      
      btr_cur_unmark_extern_fields(): Invoke rec_offs_any_extern().
      
      btr_cur_unmark_dtuple_extern_fields(): Remove a local variable.
      6e8da36b