1. 30 Apr, 2021 2 commits
  2. 29 Apr, 2021 1 commit
    • Sergei Golubchik's avatar
      MDEV-25530 Error 1451 on slave: Cannot delete or update a parent row: a... · e8b9d8d3
      Sergei Golubchik authored
      MDEV-25530 Error 1451 on slave: Cannot delete or update a parent row: a foreign key constraint fails
      
      after dfb41fdd tables that failed to drop are excluded from the
      binlogged DROP TABLE statement. It means that the slave should not
      expect any errors when executing DROP TABLE, and the binlog should
      report that no error has happened, even if it was.
      
      Do not write error code into the binlogged DROP TABLE,
      and remove all code that was needed to compute it.
      e8b9d8d3
  3. 28 Apr, 2021 2 commits
    • Vladislav Vaintroub's avatar
      MDEV-24382 Assertion in tdc_remove_table · 65e73b56
      Vladislav Vaintroub authored
      The assert is no more reproducible in the lastest 10.5-10.6
      
      The patch only adds testcase from MDEV-24382.
      65e73b56
    • Krunal Bauskar's avatar
      MDEV-25093: Adaptive flushing fails to kick in even if · 3f4b7ed9
      Krunal Bauskar authored
                  innodb_adaptive_flushing_lwm is hit. (possible regression)
      
      adaptive flushing should kick in if
      a. dirty_pct (dirty pages in buffer pool) > innodb_max_dirty_pages_pct_lwm
      OR
      b. innodb_adaptive_flushing_lwm limit is reached (default to 10%)
      
      both conditions are mutually exclusive and whichever is first to evaluate
      true should kick-start the adaptive flushing.
      
      After recent changes to simplify the flushing algorithm logic, (b) got ignored
      that introduced the said regression.
      3f4b7ed9
  4. 27 Apr, 2021 4 commits
  5. 26 Apr, 2021 5 commits
    • Daniel Black's avatar
      MDEV-25513: raise systemd LimitNOFILE limits to match server defaults · a35cde8c
      Daniel Black authored
      Quoting MDEV reporter Daniel Lewart:
      
      Starting MariaDB with default configuration causes the following problems:
      
          "[Warning] Could not increase number of max_open_files to more than 16384 (request: 32186)"
          silently reduces table_open_cache_instances from 8 (default) to 4
      
      Default Server System Variables:
      
          extra_max_connections = 1
          max_connections = 151
          table_open_cache = 2000
          table_open_cache_instances = 8
          thread_pool_size = 4
      
      LimitNOFILE=16834 is in the following files:
      
          support-files/mariadb.service.in
          support-files/mariadb@.service.in
      
      Looking at sql/mysqld.cc lines 3837-3917:
      wanted_files= (extra_files + max_connections + extra_max_connections +
      tc_size * 2 * tc_instances);
      wanted_files+= threadpool_size;
      
      Plugging in the default values:
      wanted_files = (30 + 151 + 1 + 2000 * 2 * 8 + 4) = 32186
      
      However, systemd configuration has LimitNOFILE = 16384, which is far smaller.
      
      I suggest increasing LimitNOFILE to 32768.
      a35cde8c
    • Marko Mäkelä's avatar
      MDEV-24758 heap-use-after-poison in innobase_add_instant_try/rec_copy · 4d412e98
      Marko Mäkelä authored
      This is a backport of
      commit fd9ca2a7 (MDEV-23295) and
      commit 9a156e1a (MDEV-23345) to 10.3.
      
      An instant ADD/DROP/reorder column could create a dummy table
      object with the wrong ROW_FORMAT when innodb_default_row_format
      was changed between CREATE TABLE and ALTER TABLE.
      
      prepare_inplace_alter_table_dict(): If we had promised that
      ALGORITHM=INPLACE is supported, we must preserve the ROW_FORMAT.
      
      The rest of the changes are related to adding
      Alter_inplace_info::inplace_supported to cache the return value of
      handler::check_if_supported_inplace_alter().
      4d412e98
    • Marko Mäkelä's avatar
      MDEV-15756: Remove some garbage output · dd07cfce
      Marko Mäkelä authored
      os_aio_print(): Remove output that should have been removed in
      commit 5e62b6a5 (MDEV-16264).
      dd07cfce
    • Daniele Sciascia's avatar
      Fix MTR test wsrep.variables_debug · 9e6310e3
      Daniele Sciascia authored
      The test was changing variable wsrep_provider dynamically,
      but wsrep_provider was recently made read-only.
      
      followup for ce3a2a68
      9e6310e3
    • Sujatha's avatar
      MDEV-24773: slave_compressed_protocol doesn't work properly with semi-sync replication · 391f1aa6
      Sujatha authored
      Back port upstream fix
      
      commit 1800b015a1d487330f7b15f2020b887be348a66b
      Author: Venkatesh Duggirala <venkatesh.duggirala@oracle.com>
      Date:   Fri Sep 8 20:29:22 2017 +0530
      
      Bug#26027024    SLAVE_COMPRESSED_PROTOCOL DOESN'T WORK WITH
      SEMI-SYNC REPLICATION IN MYSQL-5.7
      
      Analysis: In mysql-5.6, dump thread (the thread that is created
      on Master after Slave requested for a binlog dump) is also used
      to receive acknowledgements from the Slave and act on them accordingly.
      For performance reasons, a special thread called Ack Receiver thread
      is added in mysql-5.7 Semi synchronous replication plugin.
      This thread does not have special handling to receive acknowledgements
      if Slave has enabled compression in the protocol. Hence Master is
      unable to handle any slave if Slave_compressed_protocol is enabled
      on it.
      
      Fix: Enable compress flag on the communication channels if the Slave
      has Slave_compressed_protocol ON.
      391f1aa6
  6. 25 Apr, 2021 6 commits
  7. 24 Apr, 2021 4 commits
    • Igor Babaev's avatar
      This commit adds the same call of st_select_lex::set_unique_exclude() that · 2c9bf0ae
      Igor Babaev authored
      complemented the fix for MDEV-24823 in 10.2. As it is the only call of
      this function in 10.3 the commit also has added the code of the function.
      2c9bf0ae
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · c425d93b
      Marko Mäkelä authored
      except commit 1288dfff
      c425d93b
    • Marko Mäkelä's avatar
      MDEV-23026/MDEV-25474 fixup: Assertion ib_table->stat_initialized · 14a18d7d
      Marko Mäkelä authored
      It is possible that an object that was originally created by
      open_purge_table() will remain cached and reused for SQL execution.
      Our previous fix wrongly assumed that ha_innobase::open() would
      always be called before SQL execution starts. Therefore, we must
      invoke dict_stats_init() in ha_innobase::info_low() instead of
      only doing it in ha_innobase::open().
      
      Note: Concurrent execution of dict_stats_init() on the same table
      is possible, but it also was possible between two calls to
      ha_innobase::open(), with no ill effects observed.
      
      This should fix the assertion failure on stat_initialized.
      A possibly easy way to reproduce it would have been
      to run the server with innodb_force_recovery=2 (disable the purge of
      history), update a table so that an indexed virtual column will be
      affected, and finally restart the server normally (purge enabled),
      to observe a crash when the table is accessed from SQL.
      
      The problem was first observed and this fix verified by
      Elena Stepanova. Also Thirunarayanan Balathandayuthapani
      repeated the problem.
      14a18d7d
    • Marko Mäkelä's avatar
      MDEV-25459 MVCC read from index on CHAR or VARCHAR wrongly omits rows · 25ed665a
      Marko Mäkelä authored
      row_sel_sec_rec_is_for_clust_rec(): If the field in the
      clustered index record stored off page, always fetch it,
      also when the secondary index field has been built on the
      entire column. This was broken ever since the InnoDB Plugin
      for MySQL Server 5.1 introduced ROW_FORMAT=DYNAMIC and
      ROW_FORMAT=COMPRESSED for InnoDB tables. That code was first
      introduced in this tree in
      commit 3945d5e5.
      
      For the original ROW_FORMAT=REDUNDANT and the MySQL 5.0.3
      ROW_FORMAT=COMPRESSED, there was no problem, because for
      those tables we always stored at least a 768-byte prefix of
      each column in the clustered index record.
      
      row_sel_sec_rec_is_for_blob(): Allow prefix_len==0 for matching
      the full column.
      25ed665a
  8. 23 Apr, 2021 5 commits
    • Igor Babaev's avatar
      1288dfff
    • Aleksey Midenkov's avatar
      MDEV-25091 CREATE TABLE: field references qualified by a wrong table name succeed · 42f8548f
      Aleksey Midenkov authored
      Before FRM is written walk vcol expressions through
      check_table_name_processor() and check if field items match (db,
      table_name) qualifier.
      
      We cannot do this in check_vcol_func_processor() as there is already
      no table name qualifiers in expressions of written and loaded FRM.
      42f8548f
    • Aleksey Midenkov's avatar
      MDEV-23455 Hangs + Sig11 in unknown location(s) due to single complex FK query · 4649ba74
      Aleksey Midenkov authored
      Buffer overflow in ib_push_warning() fixed by using vsnprintf().
      
      InnoDB parser was obsoleted by MDEV-16417.
      
      Thanks to Nikita Malyavin for review and suggestion.
      4649ba74
    • Sergei Golubchik's avatar
      remove EXCEPTIONS-CLIENT · 018d7440
      Sergei Golubchik authored
      It's Oracle libmysqlclient license exception, we no longer include,
      build or ship libmysqlclient
      018d7440
    • Igor Babaev's avatar
      MDEV-24823 Crash with invalid multi-table update of view in 2nd execution of SP · e3a25793
      Igor Babaev authored
      Before this patch mergeable derived tables / view used in a multi-table
      update / delete were merged before the preparation stage.
      When the merge of a derived table / view is performed the on expression
      attached to it is fixed and ANDed with the where condition of the select S
      containing this derived table / view. It happens after the specification of
      the derived table / view has been merged into S. If the ON expression refers
      to a non existing field an error is reported and some other mergeable derived
      tables / views remain unmerged. It's not a problem if the multi-table
      update / delete statement is standalone. Yet if it is used in a stored
      procedure the select with incompletely merged derived tables / views may
      cause a problem for the second call of the procedure. This does not happen
      for select queries using derived tables / views, because in this case their
      specifications are merged after the preparation stage at which all ON
      expressions are fixed.
      This patch makes sure that merging of the derived tables / views used in a
      multi-table update / delete statement is performed after the preparation
      stage.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      e3a25793
  9. 22 Apr, 2021 11 commits
    • Igor Babaev's avatar
      MDEV-24823 Crash with invalid multi-table update of view in 2nd execution of SP · b3b5d57e
      Igor Babaev authored
      Before this patch mergeable derived tables / view used in a multi-table
      update / delete were merged before the preparation stage.
      When the merge of a derived table / view is performed the on expression
      attached to it is fixed and ANDed with the where condition of the select S
      containing this derived table / view. It happens after the specification of
      the derived table / view has been merged into S. If the ON expression refers
      to a non existing field an error is reported and some other mergeable derived
      tables / views remain unmerged. It's not a problem if the multi-table
      update / delete statement is standalone. Yet if it is used in a stored
      procedure the select with incompletely merged derived tables / views may
      cause a problem for the second call of the procedure. This does not happen
      for select queries using derived tables / views, because in this case their
      specifications are merged after the preparation stage at which all ON
      expressions are fixed.
      This patch makes sure that merging of the derived tables / views used in a
      multi-table update / delete statement is performed after the preparation
      stage.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      b3b5d57e
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      MYSQL_MAINTAINER_MODE fixes · a40f29ab
      Sergei Golubchik authored
      * MSVC check was lost in a bad merge
      * add a comment
      * move AIX check where it belongs and where it would still
        allow -Werror, if desired
      a40f29ab
    • Vladislav Vaintroub's avatar
      5c5d24c7
    • Vladislav Vaintroub's avatar
      MDEV-25456 MariaBackup logs "[ERROR]" on Invalid log block checksum · 78bb9533
      Vladislav Vaintroub authored
      Fix is to changed message to be [WARNING] for backup
      78bb9533
    • Vladislav Vaintroub's avatar
      Update timezone data on Windows · f6542a7a
      Vladislav Vaintroub authored
      There is new Yukon Standard time Windows timezone.
      
      Also fix the powershell script that generates the Windows locale mapping,
      tell powershell to use TLSv1.2 to access the github (on some reason it is
      TLS1.1 that powershell is using by default, and it does no work)
      f6542a7a
    • Marko Mäkelä's avatar
      Revert "MDEV-24589 DROP TABLE is not crash-safe" · 1636db54
      Marko Mäkelä authored
      This reverts commit e731a283.
      
      A crash occurred during the test stress.ddl_innodb when
      fil_delete_tablespace() for DROP TABLE was waiting in
      fil_check_pending_operations() and a purge thread for handling
      an earlier DROP INDEX was attempting to load the index root page
      in btr_free_if_exists() and btr_free_root_check(). The function
      buf_page_get_gen() would write out several times
      "trying to read...being-dropped tablespace"
      before giving up and committing suicide.
      
      It turns out that during any page access in btr_free_if_exists(),
      fil_space_t::set_stopping() could have been invoked by
      fil_check_pending_operations(), as part of dropping the tablespace.
      Preventing this race condition would require extensive changes
      to the allocation code or some locking mechanism that would ensure
      that we only set the flag if btr_free_if_exists() is not in progress.
      
      Either way, that could be a too risky change in a GA release.
      Because MDEV-24589 is not strictly necessary in the 10.5 release
      series and it only is a requirement for MDEV-25180 in a later
      major release, we will revert the change from 10.5.
      1636db54
    • sachin's avatar
      MDEV-22953 main.flush_read_lock failed in buildbot with XAER_NOTA: Unknown XID · 21973d0d
      sachin authored
      Issue:- Since there is no waiting for the actual disconnection of the con_tmp
      (which does XA prepare of test1), We can have a issue when test1 is not
      prepared and we are calling rollback on test1 , giving XAER_NOTA: Unknown XID
      error
      
      Solution:- Wait for the complete disconnection of con_tmp
      21973d0d
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · df33b719
      Marko Mäkelä authored
      df33b719
    • Marko Mäkelä's avatar
      MDEV-25483: Shutdown crash during innodb.innodb_buffer_pool_resize_temporary · cbbca7ed
      Marko Mäkelä authored
      buf_resize_callback(): Correct an invalid assertion, and enable
      the assertion in debug builds only.
      
      Between buf_resize_start() and buf_resize_shutdown(),
      srv_shutdown_state must be less than SRV_SHUTDOWN_CLEANUP.
      
      The incorrect assertion had been introduced in
      commit 5e62b6a5 (MDEV-16264).
      As a result, the server could crash if shutdown was initiated
      concurrently with initiating a change of innodb_buffer_pool_size.
      cbbca7ed
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · ee455e6f
      Marko Mäkelä authored
      ee455e6f