- 01 Apr, 2020 2 commits
-
-
Marko Mäkelä authored
Let us enable all GCC and clang warnings independently of the MYSQL_MAINTAINER_MODE setting for both Debug and RelWithDebInfo builds, and have MYSQL_MAINTAINER_MODE only enable -Werror. The default setting of MYSQL_MAINTAINER_MODE=AUTO will continue to apply the -Werror only to CMAKE_BUILD_TYPE=Debug. To build a debug version without -Werror, MYSQL_MAINTAINER_MODE=OFF can be used.
-
Marko Mäkelä authored
-
- 25 Mar, 2020 2 commits
-
-
Oleksandr Byelkin authored
--ignore-table-data parameter added.
-
Thirunarayanan Balathandayuthapani authored
FOREIGN_KEY_CHECKS is disabled - dict_foreign_find_index() can return NULL if InnoDB already dropped the foreign index when FOREIGN_KEY_CHECKS is disabled.
-
- 24 Mar, 2020 1 commit
-
-
Vladislav Vaintroub authored
-
- 23 Mar, 2020 1 commit
-
-
Sergei Golubchik authored
these three SHOW statements (and more) are issued from include/analyze-sync_with_master.test too. no need to do it twice.
-
- 20 Mar, 2020 1 commit
-
-
Alexander Barkov authored
The problem happened in these line: uval0= (ulonglong) (val0_negative ? -val0 : val0); uval1= (ulonglong) (val1_negative ? -val1 : val1); return check_integer_overflow(val0_negative ? -(longlong) res : res, !val0_negative); when unary minus was performed on -9223372036854775808. This behavior is undefined in C/C++.
-
- 15 Mar, 2020 1 commit
-
-
Igor Babaev authored
This bug could manifest itself in a very rare cases when the optimizer chose an execution plan by which a joined table was accessed by a table scan and the optimizer was checking whether ranges checked for each record could improve this plan. In such cases the optimizer evaluates range conditions over a table that depend on other tables. For such conditions the constructed SEL_ARG trees are marked as MAYBE_KEY. If a SEL_ARG object constructed for a sargable condition marked as RANGE_KEY had the same first key part as a MAYBE_KEY SEL_ARG object and the key_and() function was called for this pair of SEL_ARG objects then an invalid SEL_ARG object could be constructed that ultimately could lead to a crash before the execution phase.
-
- 14 Mar, 2020 2 commits
-
-
Sergei Golubchik authored
to work better for CPUs with more than 2000 bogomips. old behavior is preserved if less than 2500 bogomips.
-
Sergei Golubchik authored
see e.g. `add_to_status()`
-
- 13 Mar, 2020 2 commits
-
-
Igor Babaev authored
'index_merge_sort_union=off' When index_merge_sort_union is set to 'off' and index_merge_union is set to 'on' then any evaluated index merge scan must consist only of ROR scans. The cheapest out of such index merges must be chosen. This index merge might not be the cheapest index merge.
-
Marko Mäkelä authored
-
- 11 Mar, 2020 4 commits
-
-
Eugene Kosov authored
actually, page_zip_verify_checksum() generally allows all-zeroes checksums because our CRC32 checksum is something like crc_1 ^ crc_2 ^ crc_3 Also, all zeroes page is considered correct. As a side effect fix nasty reinterpret_cast<> UB Also, since c0f47a4a innodb_checksum_algorithm=full_crc32 exists which computes CRC32 in one go (without bitwise arithmetic)
-
Eugene Kosov authored
-
Marko Mäkelä authored
Also, remove some trailing white space and add missing static qualifier to free_annotate_event().
-
Sergei Petrunia authored
It was: implicit conversion from 'ha_rows' (aka 'unsigned long long') to 'double' changes value from 18446744073709551615 to 18446744073709551616 Follow what JOIN::get_examined_rows() does for similar code.
-
- 10 Mar, 2020 1 commit
-
-
Marko Mäkelä authored
-
- 06 Mar, 2020 1 commit
-
-
Oleksandr Byelkin authored
-
- 28 Feb, 2020 1 commit
-
-
Vicențiu Ciorbaru authored
-
- 26 Feb, 2020 1 commit
-
-
Ben Boeckel authored
When installing, no headers are installed into the parent directory of `${includedir}`.
-
- 25 Feb, 2020 1 commit
-
-
Daniel Black authored
-
- 22 Feb, 2020 1 commit
-
-
Anel Husakovic authored
MDEV-21374: When "--help --verbose" prints out configuration file paths, the --defaults-file option is not considered * `--defaults-file` option is showed only in `--help --verbose` if applied * `--default-extra-file` is showing correctly now in `--help --verbose`, previously it was treated as a directory with appended `my.cnf`
-
- 12 Feb, 2020 1 commit
-
-
Oleksandr Byelkin authored
Emulate older API
-
- 10 Feb, 2020 1 commit
-
-
Oleksandr Byelkin authored
-
- 08 Feb, 2020 1 commit
-
-
Marko Mäkelä authored
The symbol SRV_MASTER_PURGE_INTERVAL became unused in mysql/mysql-server@42f36919584e82c621dbec1e69fd05ab023c54c6 when separate purge threads were introduced in MySQL 5.6.5.
-
- 07 Feb, 2020 1 commit
-
-
Thirunarayanan Balathandayuthapani authored
- Added the test case in innodb_fts suite - Updated copyright year in row0mysql.cc
-
- 06 Feb, 2020 1 commit
-
-
Thirunarayanan Balathandayuthapani authored
Problem: ======= After discarding the table, fts_optimize_thread aborts during shutdown. InnoDB fails to remove the table from fts_optimize_wq and it leads to the fts_optimize_thread to lookup for the auxiliary table and fails. Fix: ==== While discarding the fts table, remove the table from fts_optimize_wq.
-
- 31 Jan, 2020 1 commit
-
-
Marko Mäkelä authored
fil_space_encrypt(): Remove the debug check that decrypts the just encrypted page. We are exercising the decryption of encrypted pages enough via --suite=encryption,mariabackup. It is a waste of computing resources to decrypt every page immediately after encrypting it. The redundant check had been added in commit 2bedc397 (MDEV-9931).
-
- 30 Jan, 2020 1 commit
-
-
Thirunarayanan Balathandayuthapani authored
- dict_table_try_drop_aborted() can generate undo logs. So it should be avoided after shutdown of background threads.
-
- 29 Jan, 2020 2 commits
-
-
Anel Husakovic authored
Deleted with commit: c70a9fa1
-
Sujatha authored
MDEV-20923:UBSAN: member access within address … which does not point to an object of type 'xid_count_per_binlog' Problem: ------- Accessing a member within 'xid_count_per_binlog' structure results in following error when 'UBSAN' is enabled. member access within address 0xXXX which does not point to an object of type 'xid_count_per_binlog' Analysis: --------- The problem appears to be that no constructor for 'xid_count_per_binlog' is being called, and thus the vtable will not be initialized. Fix: --- Defined a parameterized constructor for 'xid_count_per_binlog' class.
-
- 28 Jan, 2020 3 commits
-
-
Daniel Black authored
Original patch from Daniel Black <daniel@linux.ibm.com>, backported to 10.1.
-
Vicențiu Ciorbaru authored
-
Oleksandr Byelkin authored
-
- 27 Jan, 2020 2 commits
-
-
Daniel Bartholomew authored
-
Daniel Bartholomew authored
-
- 25 Jan, 2020 1 commit
-
-
Elena Stepanova authored
-
- 24 Jan, 2020 3 commits
-
-
Rafli Akmal authored
..as they have their own tools that parses those files, such as opensysusers[1] that handles sysusers file and opentmpfiles[2] that handles tmpfiles.d settings Because of this. Move both sysusers and tmpfiles 'if' function outside systemd function, allowing independent install Signed-off-by: Rafli Akmal <thefallenrat@artixlinux.org> [1] - https://github.com/artix-linux/opensysusers [2] - https://github.com/OpenRC/opentmpfiles Changes done by vicentiu@mariadb.org, from original author patch: Installing sysusers and tmpfiles without checking for systemd existence means that by default, cmake will ALWAYS install these files. Our general policy is we do not install things which are not needed. However, there is a valid use case when these files are useful, as is described above. To allow this, provide an extra switch that can be enabled during configuring by doing -DINSTALL_SYSTEMD_{SYSUSERS|TMPFILES}=True This will use the default path INSTALL_SYSTEMD_{SYSUSERS|TMPFILES}DIR fetched from install_layout.cmake for rpm & deb based layouts respectively, or they must be overriden if the install_layout is standalone. Example: cmake . -DINSTALL_SYSTEMD_SYSUSERS=True -DINSTALL_SYSTEMD_SYSUSERSDIR=/etc/sysusers.d
-
Christian Hesse authored
These files were installed to: ${INSTALL_SYSTEMD_SYSUSERSDIR}/sysusers.conf ${INSTALL_SYSTEMD_TMPFILESDIR}/tmpfiles.conf Instead rename the files to more descriptive file names 'mariadb.conf'.
-
Sujatha authored
MDEV-21490: binlog tests fail with valgrind: Conditional jump or move depends on uninitialised value in sql_ex_info::init Problem: ======= P1) Conditional jump or move depends on uninitialised value(s) sql_ex_info::init(char const*, char const*, bool) (log_event.cc:3083) code: All the following variables are not initialized. ---- return ((cached_new_format != -1) ? cached_new_format : (cached_new_format=(field_term_len > 1 || enclosed_len > 1 || line_term_len > 1 || line_start_len > 1 || escaped_len > 1))); P2) Conditional jump or move depends on uninitialised value(s) Rows_log_event::Rows_log_event(char const*, unsigned int, Format_description_log_event const*) (log_event.cc:9571) Code: Uninitialized values is reported for 'var_header_len' variable. ---- if (var_header_len < 2 || event_len < static_cast<unsigned int>(var_header_len + (post_start - buf))) P3) Conditional jump or move depends on uninitialised value(s) Table_map_log_event::pack_info(Protocol*) (log_event.cc:11553) code:'m_table_id' is uninitialized. ---- void Table_map_log_event::pack_info(Protocol *protocol) ... size_t bytes= my_snprintf(buf, sizeof(buf), "table_id: %lu (%s.%s)", m_table_id, m_dbnam, m_tblnam); Fix: === P1 - Fix) Initialize cached_new_format,field_term_len, enclosed_len, line_term_len, line_start_len, escaped_len members in default constructor. P2 - Fix) "var_header_len" is initialized by reading the event buffer. In case of an invalid event the buffer will contain invalid data. Hence added a check to validate the event data. If event_len is smaller than valid header length return immediately. P3 - Fix) 'm_table_id' within Table_map_log_event is initialized by reading data from the event buffer. Use 'VALIDATE_BYTES_READ' macro to validate the current state of the buffer. If it is invalid return immediately.
-