1. 09 Jul, 2024 1 commit
  2. 08 Jul, 2024 3 commits
    • Alexander Barkov's avatar
      027f1377
    • Robin Newhouse's avatar
      Delete unused global variables from mysqld.h · becc8372
      Robin Newhouse authored
      Several variables declared in mysqld.h appear to be old system variables
      that have been left over after deprecation. Delete them using IDE
      refactoring to automatically search for other uses. Most cases had no
      other uses in the code.
      
      slave_allow_batching had a test that was effectively unused, as the
      result was only
      -ERROR HY000: Unknown system variable 'slave_allow_batching'
      so that was deleted as well.
      
      Build and test still works without issue as expected.
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license. I am contributing on behalf of my employer Amazon Web
      Services.
      becc8372
    • Alexander Barkov's avatar
      8f4ec79d
  3. 06 Jul, 2024 2 commits
  4. 02 Jul, 2024 1 commit
  5. 28 Jun, 2024 3 commits
    • Monty's avatar
      MDEV-34240 galera.MDEV-27862 fails binlog assert in close_thread_tables() · 86770ada
      Monty authored
      Affects:
      MDEV-34150 Assertion failure in Diagnostics_area::set_error_status upon binary
                 logging hitting tmp space limit
      MDEV-9101 Limit size of created disk temporary files and tables
      
      This bug was caused by moving flushing of the in-memory-row-events from
      close_thread_tables() to binlog_commit() in MDEV-34150.
      This was needed to be able to handle the case where binlog writes could
      fail.
      
      Galera have two case where the change caused problems:
      
      - Row events in commit_one_phase_2() was not done in the case the standard
        binary log was not enabled but Galera was using the binary log
        internally.
      - Galera disabled the call to binlog_commit_flush_stmt_cache() for not
        ending transactions.
      
      Fixed by adding code that flushes the in-memory-row-events to the binary
      log (write, but now sync) in the two above cases if Galera is enabled.
      86770ada
    • Monty's avatar
      f385837d
    • Nikita Malyavin's avatar
      fix MDEV-34424 for ed255129 · 14d9801c
      Nikita Malyavin authored
      realloc can't be done for mysql->passwd. There's also no pretty way to
      pass the ext-salt into hash_password, so let's use thread_local instead.
      
      For GCC < 4.9 (SLES 12, CentOS 7), which don't support _Thread_local,
      pk will be recalculated instead
      14d9801c
  6. 21 Jun, 2024 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-33748 get rid of pthread_(get_/set_)specific, use thread_local · 7c5fdc9b
      Vladislav Vaintroub authored
      Apart from better performance when accessing thread local variables,
      we'll get rid of things that depend on initialization/cleanup of
      pthread_key_t variables.
      
      Where appropriate, use compiler-dependent pre-C++11 thread-local
      equivalents, where it makes sense, to avoid initialization check overhead
      that non-static thread_local can suffer from.
      7c5fdc9b
  7. 20 Jun, 2024 2 commits
  8. 18 Jun, 2024 1 commit
  9. 17 Jun, 2024 5 commits
  10. 16 Jun, 2024 2 commits
    • Monty's avatar
      Change mysqldump to use DO instead of 'SELECT' for storing sequences. · 956bcf8f
      Monty authored
      This avoids a lot of SETVAL() results when applying a mysqldump with
      sequences.
      956bcf8f
    • Monty's avatar
      MDEV-34406 Enhance mariadb_upgrade to print failing query in case of error · fef32fd9
      Monty authored
      To make this possible, it was also necessary to enhance the mariadb
      client with the option --print-query-on-error.
      This option can also be very useful when running a batch of queries
      through the mariadb client and one wants to find out where things goes
      wrong.
      
      TODO: It would be good to enhance mariadb_upgrade to not call the mariadb
      client for executing queries but instead do this internally.  This
      would have made this patch much easier!
      
      Reviewed by: Sergei Golubchik <serg@mariadb.com>
      fef32fd9
  11. 14 Jun, 2024 2 commits
  12. 13 Jun, 2024 6 commits
  13. 12 Jun, 2024 3 commits
  14. 11 Jun, 2024 5 commits
  15. 10 Jun, 2024 3 commits
    • Yuchen Pei's avatar
      MDEV-34002 Initialise fields in spider_db_handler · d524cb5b
      Yuchen Pei authored
      Otherwise it may result in nonsensical values like 190 for a boolean.
      d524cb5b
    • Alexey Yurchenko's avatar
      MDEV-31809 Automatic SST user account management · a1e5a284
      Alexey Yurchenko authored
      Implement automatic creation of temporary accounts for SST and pass
      account credentials to SST script via socket as opposed to environment
      variables. Delete the user after the SST script returns,
      
      Respect wsrep_sst_auth set by the adminitrator in case some additional
      privilege grants are needed for particular SST method.
      
      mysqldump SST requires significant change to make use of the new
      automatic user generation facility. For now just make it compatible
      by ignoring automatically generated user and rely only on wsrep_sst_auth
      setting on the joiner node to keep backward compatibility.
      
      Adapt mysqldump SST to automatic SST user generation changes:
       - disable special treatment for mysqldump SST on donor
       - make mysqldump SST script compatible with the new SST script
         interface.
      
      Differentiate user privileges for different SST methods:
       - grant minimum required privileges for clone and xtrabackup SST
         accounts
       - grant all privileges to custom SST accounts as it is not known what
         is needed.
       - disable SST account generation for rsync SST since it is not needed.
      
      MTR tests:
       - add MTR tests for clone and xtrabackup SSTs without wsrep_sst_auth,
       - add MTR test for testing masking of wsrep_sst_auth.
       - don't attmept to restore original wsrep_sst_auth in MTR tests as it
         is always masked.
      Signed-off-by: default avatarJulius Goryavsky <julius.goryavsky@mariadb.com>
      a1e5a284
    • Alexey Yurchenko's avatar