1. 12 Sep, 2006 4 commits
    • unknown's avatar
      Merge polly.local:/tmp/20924/bug20294/my50-bug20294 · 90792d4c
      unknown authored
      into  polly.local:/home/kaa/src/maint/m50-maint--07OGt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/sql_class.h:
        Auto merged
      mysql-test/r/user_var.result:
        Manual merge
      mysql-test/t/user_var.test:
        Manual merge
      sql/item_func.cc:
        Manual merge
      sql/item_func.h:
        Manual merge
      90792d4c
    • unknown's avatar
      Fixed compilation · 40d292ad
      unknown authored
      40d292ad
    • unknown's avatar
      Merge polly.local:/tmp/20924/bug20294/my41-bug20294 · 51b27a3a
      unknown authored
      into  polly.local:/tmp/20924/bug20294/my50-bug20294
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      mysql-test/r/case.result:
        Manual merge
      mysql-test/r/func_if.result:
        Manual merge
      mysql-test/r/func_test.result:
        Manual merge
      mysql-test/r/user_var.result:
        Manual merge
      mysql-test/t/case.test:
        Manual merge
      mysql-test/t/func_if.test:
        Manual merge
      mysql-test/t/func_test.test:
        Manual merge
      mysql-test/t/user_var.test:
        Manual merge
      sql/item_func.cc:
        Manual merge
      51b27a3a
    • unknown's avatar
      Post-review fixes for bug #20924 · c839cd8e
      unknown authored
      
      mysql-test/r/case.result:
        Post-review fix for bug #20924
      mysql-test/r/func_if.result:
        Post-review fix for bug #20924
      mysql-test/r/func_test.result:
        Post-review fix for bug #20924
      mysql-test/r/user_var.result:
        Post-review fix for bug #20924
      mysql-test/t/case.test:
        Post-review fix for bug #20924
      mysql-test/t/func_if.test:
        Post-review fix for bug #20924
      mysql-test/t/func_test.test:
        Post-review fix for bug #20924
      mysql-test/t/user_var.test:
        Post-review fix for bug #20924
      sql/item_func.cc:
        Post-review fix for bug #20924
      sql/item_func.h:
        Post-review fix for bug #20924
      sql/log_event.cc:
        Post-review fix for bug #20924
      c839cd8e
  2. 08 Sep, 2006 1 commit
    • unknown's avatar
      Bug #20924: CAST(expr as UNSIGNED) returns SIGNED value when used in various functions · 8e14a50a
      unknown authored
      - Honor unsigned_flag in the corresponding functions
      - Use compare_int_signed_unsigned()/compare_int_unsigned_signed() instead of explicit comparison in GREATEST() and LEAST()
      
      
      mysql-test/r/case.result:
        Added test case for bug #20924
      mysql-test/r/func_if.result:
        Added test case for bug #20924
      mysql-test/r/func_test.result:
        Added test case for bug #20924
      mysql-test/r/user_var.result:
        Added test case for bug #20924
      mysql-test/t/case.test:
        Added test case for bug #20924
      mysql-test/t/func_if.test:
        Added test case for bug #20924
      mysql-test/t/func_test.test:
        Added test case for bug #20924
      mysql-test/t/user_var.test:
        Added test case for bug #20924
      sql/item_cmpfunc.cc:
        Bug #20924: CAST(expr as UNSIGNED) returns SIGNED value when used in various functions
        
        - Moved some code out of Arg_comparator to external functions to be reused in Item_func_min_max
        - Fixed IFNULL(), IF(), CASE() and COALESCE()
      sql/item_cmpfunc.h:
        Bug #20924: CAST(expr as UNSIGNED) returns SIGNED value when used in various functions
        
        - Moved some code out of Arg_comparator to external functions to be reused in Item_func_min_max
      sql/item_func.cc:
        Bug #20924: CAST(expr as UNSIGNED) returns SIGNED value when used in various functions
        
        Fixed LEAST(), GREATEST() and "SET @A=..." parts
      sql/item_func.h:
        Bug #20924: CAST(expr as UNSIGNED) returns SIGNED value when used in various functions
        
        Fixed "SET @A=..." part
      sql/sql_class.h:
        Bug #20924: CAST(expr as UNSIGNED) returns SIGNED value when used in various functions
        
        Fixed "SET @A=..." part
      8e14a50a
  3. 06 Sep, 2006 8 commits
  4. 05 Sep, 2006 1 commit
    • unknown's avatar
      Fix for BUG#11151 "LOAD DATA INFILE commits transaction in 5.0". · d03d3c01
      unknown authored
      In 5.0 we made LOAD DATA INFILE autocommit in all engines, while
      only NDB wanted that. Users and trainers complained that it affected
      InnoDB and was a change compared to 4.1 where only NDB autocommitted.
      To revert to the behaviour of 4.1, we move the autocommit logic out of mysql_load() into
      ha_ndbcluster::external_lock().
      The result is that LOAD DATA INFILE commits all uncommitted changes
      of NDB if this is an NDB table, its own changes if this is an NDB
      table, but does not affect other engines.
      Note: even though there is no "commit the full transaction at end"
      anymore, LOAD DATA INFILE stays disabled in routines (re-entrency
      problems per a comment of Pem).
      Note: ha_ndbcluster::has_transactions() does not give reliable results
      because it says "yes" even if transactions are disabled in this engine...
      
      
      sql/ha_ndbcluster.cc:
        NDB wants to do autocommit if this is LOAD DATA INFILE.
        For this to not affect all other engines, we move the logic
        inside ha_ndbcluster.
      sql/sql_load.cc:
        This ha_enable_transaction() in mysql_load() forced an autocommit
        in all engines, while only NDB wants to do that.
        So we move the logic inside ha_ndbcluster.cc.
      mysql-test/include/loaddata_autocom.inc:
        test for engines to see if they autocommit or not in LOAD DATA INFILE
      mysql-test/r/loaddata_autocom_innodb.result:
        result for InnoDB (no autocommit)
      mysql-test/r/loaddata_autocom_ndb.result:
        result for NDB (autocommit)
      mysql-test/r/rpl_ndb_innodb_trans.result:
        result for InnoDB+NDB transactions. Observe that when ROLLBACK
        cannot rollback the LOAD DATA INFILE in NDB it issues warning 1196
        as appropriate.
      mysql-test/t/loaddata_autocom_innodb.test:
        test that InnoDB does not autocommit in LOAD DATA INFILE.
      mysql-test/t/loaddata_autocom_ndb.test:
        test that NDB does autocommit in LOAD DATA INFIL
      mysql-test/t/rpl_ndb_innodb_trans-slave.opt:
        need to tell the slave to use innodb
      mysql-test/t/rpl_ndb_innodb_trans.test:
        test of transactions mixing NDB and InnoDB. To see if ROLLBACK
        rolls back in both engines, with the exception of LOAD DATA INFILE
        which does not roll back NDB: we see that a LOAD DATA INFILE in NDB
        commits all what has been done in NDB so far, commits its changes,
        but does not commit in other engines.
      d03d3c01
  5. 04 Sep, 2006 11 commits
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/50-work · e7709f71
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0-ndb
      
      
      sql/log.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      e7709f71
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/41-work · 31b006b1
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/50-work
      
      
      sql/log.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_repl.cc:
        merge
      31b006b1
    • unknown's avatar
      bug#21965 - replication · 698f3b7e
      unknown authored
        fix deadlock if master switches log file in parallell with "show master logs"
        
      
      
      sql/log.cc:
        add raw_get_current_log which dont take log mutex
      sql/sql_class.h:
        add raw_get_current_log which dont take log mutex
      sql/sql_repl.cc:
        Fix lock order i.e first log_lock then index_lock
      698f3b7e
    • unknown's avatar
      Merge dl145s:/data/tkatchaounov/5.0-bug-21787 · 4a2b181f
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      sql/sql_select.cc:
        Auto merged
      4a2b181f
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-maint · 1a57e2ab
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      1a57e2ab
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · 6719e61c
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      6719e61c
    • unknown's avatar
      Fix problem where mysql-test-run.pl fails to start up the mysqld after a... · bcd39db2
      unknown authored
      Fix problem where mysql-test-run.pl fails to start up the mysqld after a failed test. Shows up on win hosts where one failed test case make subsequent ones fails with error "Could not open connection 'default': 2003 Can't connect to MySQL server on 'localhost'" 
      
      
      mysql-test/lib/mtr_process.pl:
        Reset the associated "pid" of masters and slave when building the list of processes to shutdown.
      bcd39db2
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-cmake · a728d352
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      a728d352
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 38b47461
      unknown authored
      into  maint1.mysql.com:/data/localhome/tnurnberg/my50-21913
      
      
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      38b47461
    • unknown's avatar
      Merge salvation.intern.azundris.com:/home/tnurnberg/21913/my41-21913 · 325daf37
      unknown authored
      into  salvation.intern.azundris.com:/home/tnurnberg/21913/my50-21913
      
      21913: DATE_FORMAT() Crashes mysql server if I use it through mysql-connector-j driver.
      
      Variable character_set_results can legally be NULL (for "no conversion.")
      This could result in a NULL deref that crashed the server.  Fixed.
      
      (Although ran some additional precursory tests to see whether I could break
      anything else, but no breakage so far.)
      
      
      mysql-test/r/func_time.result:
        Bug#21913: DATE_FORMAT() Crashes mysql server if I use it through mysql-connector-j driver.
        
        Prove DATE_FORMAT() no longer crashes the server when character_set_results is
        NULL (which is a legal value and means, "no conversion").
      mysql-test/t/func_time.test:
        Bug#21913: DATE_FORMAT() Crashes mysql server if I use it through mysql-connector-j driver.
        
        Prove DATE_FORMAT() no longer crashes the server when character_set_results is
        NULL (which is a legal value and means, "no conversion").
      sql/sql_string.cc:
        Bug#21913: DATE_FORMAT() Crashes mysql server if I use it through mysql-connector-j driver.
        
        Avoid NULL deref in my_charset_same() -- if !to_cs, we won't need to compare
        because it is magic for, "no conversion."
      325daf37
    • unknown's avatar
      Bug#21913: DATE_FORMAT() Crashes mysql server if I use it through mysql-connector-j driver. · eefe3430
      unknown authored
      Variable character_set_results can legally be NULL (for "no conversion.")
      This could result in a NULL deref that crashed the server.  Fixed.
      
      (Although ran some additional precursory tests to see whether I could break
      anything else, but no breakage so far.)
      
      
      mysql-test/r/func_time.result:
        Bug#21913: DATE_FORMAT() Crashes mysql server if I use it through mysql-connector-j driver.
        
        Prove DATE_FORMAT() no longer crashes the server when character_set_results is
        NULL (which is a legal value and means, "no conversion").
      mysql-test/t/func_time.test:
        Bug#21913: DATE_FORMAT() Crashes mysql server if I use it through mysql-connector-j driver.
        
        Prove DATE_FORMAT() no longer crashes the server when character_set_results is
        NULL (which is a legal value and means, "no conversion").
      sql/sql_string.cc:
        Bug#21913: DATE_FORMAT() Crashes mysql server if I use it through mysql-connector-j driver.
        
        Avoid NULL deref in my_charset_same() -- if !to_cs, we won't need to compare
        because it is magic for, "no conversion."
      eefe3430
  6. 03 Sep, 2006 1 commit
  7. 02 Sep, 2006 5 commits
  8. 01 Sep, 2006 9 commits
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/cmiller/mtr_reorder/my50-mtr_reorder · 59e662fb
      unknown authored
      into  maint1.mysql.com:/data/localhome/cmiller/mysql-5.0-maint
      
      59e662fb
    • unknown's avatar
      mtr_cases.pl: · 4e985aeb
      unknown authored
        Provide a more extensible, easier-to-change way of reordering
        test cases.
      
      
      mysql-test/lib/mtr_cases.pl:
        Provide a more extensible, easier-to-change way of reordering
        test cases.
      4e985aeb
    • unknown's avatar
    • unknown's avatar
      Modification for win subdirectory · 33844a8d
      unknown authored
      
      configure.in:
        added win subdir
      33844a8d
    • unknown's avatar
      Fixes for crashes and test failures · f0ec47a9
      unknown authored
      
      scripts/make_win_bin_dist:
        BitKeeper file /home/georg/work/mysql/prod/mysql-5.0-win/scripts/make_win_bin_dist
      client/mysqlbinlog.cc:
        Fix for cmake build: Cmake doesn't use the VC++ files
      extra/comp_err.c:
        fixed windows crash (debug): We can't call DBUG_RETURN after my_end.
      include/my_dbug.h:
        added missing empty define for DBUG_LEAVE to prevent precompiler errors when
        compiling in non_debug mode
      mysql-test/mysql-test-run.pl:
        Added support for new cmake release and debug paths.
      mysql-test/t/system_mysql_db_fix.test:
        This test requires unix shell script mysql_fix_previleges_tables -> skip under windows
      mysys/my_seek.c:
        Fix for windows debug crash. However this solution is bad: we should never
        call lseek with an invalid file pointer.
      sql/ha_archive.cc:
        Fixed windows crash: We need dup in gzdopen to keep the filehandle open,
        otherwise subsequent calls to mysql_close will fail/crash.
      f0ec47a9
    • unknown's avatar
      Merge timka@10.100.64.80:/home/timka/mysql/src/4.1-bug-21787 · e9f83e13
      unknown authored
      into  dl145s.mysql.com:/data/tkatchaounov/5.0-bug-21787
      
      
      mysql-test/r/limit.result:
        Auto merged
      mysql-test/t/limit.test:
        Auto merged
      sql/sql_select.cc:
        Adjust the fix for BUG#21787 for 5.0
      e9f83e13
    • unknown's avatar
      Fix for BUG#21787: COUNT(*) + ORDER BY + LIMIT returns wrong result · bc56d84f
      unknown authored
        
      The problem was due to a prior fix for BUG 9676, which limited
      the rows stored in a temporary table to the LIMIT clause. This
      optimization is not applicable to non-group queries with aggregate
      functions. The fix disables the optimization in this case.
      
      
      mysql-test/r/limit.result:
        Test case for BUG#21787
      mysql-test/t/limit.test:
        Test case for BUG#21787
      sql/sql_select.cc:
        If there is an aggregate function in a non-group query,
        materialize all rows in the temporary table no matter if
        there is a LIMIT clause. This is necessary, since the
        aggregate functions must be computed over all result rows,
        not just the first LIMIT rows.
      bc56d84f
    • unknown's avatar
      Fix problem with windows where stderr is not flushed until end of program. · 711cd440
      unknown authored
      
      client/mysqldump.c:
        fflush stderr after writing to it.
      711cd440
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 17883212
      unknown authored
      into  mysql.com:/home/psergey/mysql-5.0-bug21477-look-64bit
      
      17883212