1. 12 Feb, 2009 4 commits
  2. 11 Feb, 2009 5 commits
  3. 10 Feb, 2009 14 commits
    • Mats Kindahl's avatar
      Merging with 5.1-bugteam · 9bb2b474
      Mats Kindahl authored
      9bb2b474
    • Mats Kindahl's avatar
      Bug #36763 · e9179186
      Mats Kindahl authored
      TRUNCATE TABLE fails to replicate when stmt-based binlogging is not supported.
      
      Correcting some tests that was failing in pushbuild as well as fixing result
      file for some tests that are not executed in the default MTR run.
      
      mysql-test/suite/binlog/t/binlog_truncate_innodb.test:
        Need to reset master to avoid the check to be for the wrong binlog file.
      mysql-test/suite/binlog/t/binlog_truncate_myisam.test:
        Need to reset master to avoid the check to be for the wrong binlog file.
      e9179186
    • Georgi Kodinov's avatar
      merged 5.0-bugteam to 5.1-bugteam · f1f5d7d7
      Georgi Kodinov authored
      f1f5d7d7
    • Georgi Kodinov's avatar
      fixed a libedit compilation problem · de7665ac
      Georgi Kodinov authored
      de7665ac
    • Mats Kindahl's avatar
      Merging with 5.1-bugteam · 6520a8a1
      Mats Kindahl authored
      6520a8a1
    • Chad MILLER's avatar
      Merge from bugteam team tree. · ad2e40f0
      Chad MILLER authored
      ad2e40f0
    • Mats Kindahl's avatar
      BUG#36763: TRUNCATE TABLE fails to replicate when stmt-based binlogging is not supported. · 8d43b845
      Mats Kindahl authored
      Post-merge fixes. Changes to some result sets.
      
      mysql-test/r/commit_1innodb.result:
        TRUNCATE TABLE does not cause the binary log to do commits any more.
      mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
        TRUNCATE TABLE is not transactional, hence does not have BEGIN/COMMIT around itself.
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        TRUNCATE TABLE is not transactional, hence does not have BEGIN/COMMIT around itself.
      mysql-test/suite/rpl/r/rpl_innodb_mixed_dml.result:
        TRUNCATE TABLE is not transactional, hence does not have BEGIN/COMMIT around itself.
      mysql-test/suite/rpl/r/rpl_truncate_2myisam.result:
        STOP SLAVE was replaced with include file.
      mysql-test/suite/rpl/r/rpl_truncate_3innodb.result:
        STOP SLAVE was replaced with include file.
      8d43b845
    • Chad MILLER's avatar
      Bug#30261: "mysqld --help" no longer possible for root · b8b9d723
      Chad MILLER authored
      The check for root-ness would signal an error.  Errors would make the
      server exit before usage (help) information was printed.
      
      Now, test for whether we want help regardless of whether we're going
      to exit with an error.  If plugins are not initialized by the time we 
      print usage information, inform the user that some parameters are 
      missing.
      b8b9d723
    • Georgi Kodinov's avatar
      merged 5.0-bugteam -> 5.1-bugteam · f90f02d6
      Georgi Kodinov authored
      f90f02d6
    • Georgi Kodinov's avatar
      From jperkin : Merge libedit 2.11 and related files, · da2e124f
      Georgi Kodinov authored
      based on NetBSD CVS as of 2009/02/06 20:09:00.
      da2e124f
    • Vladislav Vaintroub's avatar
      merge · c99c001b
      Vladislav Vaintroub authored
      c99c001b
    • Luis Soares's avatar
      BUG#13684: SP: DROP PROCEDURE|FUNCTION IF EXISTS not binlogged if routine does not exist · feb6654e
      Luis Soares authored
      There is an inconsistency with DROP DATABASE IF EXISTS, DROP
      TABLE IF EXISTS and DROP VIEW IF EXISTS: those are binlogged even
      if the DB or TABLE does not exist, whereas DROP PROCEDURE IF
      EXISTS does not. It would be nice or at least consistent if DROP
      PROCEDURE/STATEMENT worked the same too.
            
      Fixed DROP PROCEDURE|FUNCTION IF EXISTS by adding a call to
      write_bin_log in mysql_execute_command. Checked also if all
      documented "DROP (...) IF EXISTS" get binlogged. Left out DROP
      SERVER IF EXISTS because it seems that it only gets binlogged when
      using row event (see BUG#25705).
      feb6654e
    • Bjorn Munch's avatar
      Bug #42590 MTR v1 crashes under Active State Perl · c8528e02
      Bjorn Munch authored
      Perl crashes when MTR 2 tries to start v1
      Replaced require with system()
      c8528e02
    • Georgi Kodinov's avatar
      Bug #33813: Schema names are case-sensitive in DROP FUNCTION · 574b1e25
      Georgi Kodinov authored
      The parser was not using the correct fully-qualified-name
      production for DROP FUNCTION.
      Fixed by copying the production from DROP PROCEDURE.
      Tested in the windows specific suite to make sure it's 
      tested on a case-insensitive file system.
      
      mysql-test/r/windows.result:
        Bug #33813: test case
      mysql-test/t/windows.test:
        Bug #33813: test case
      sql/sql_yacc.yy:
        Bug #33813: use the correct production for the name in
        DROP PROCEDURE
      574b1e25
  4. 09 Feb, 2009 6 commits
    • Mats Kindahl's avatar
      Merging with 5.1-bugteam. · 8948cb62
      Mats Kindahl authored
      8948cb62
    • Davi Arnaut's avatar
      Merge from upstream 5.1-bugteam. · 9a538660
      Davi Arnaut authored
      9a538660
    • Vladislav Vaintroub's avatar
      Bug#42709: safe_process_win.cc does not print correct system error messages. · 0a397bfe
      Vladislav Vaintroub authored
      Fix: use FormatMessage() to output system errors , not strerror()
      0a397bfe
    • Davi Arnaut's avatar
      Bug#42634: % character in query can cause mysqld signal 11 segfault · df88c8e3
      Davi Arnaut authored
      The problem is that a unfiltered user query was being passed as
      the format string parameter of sql_print_warning which later
      performs printf-like formatting, leading to crashes if the user
      query contains formatting instructions (ie: %s). Also, it was
      using THD::query as the source of the user query, but this
      variable is not meaningful in some situations -- in a delayed
      insert, it points to the table name.
      
      The solution is to pass the user query as a parameter for the
      format string and use the function parameter query_arg as the
      source of the user query.
      
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Add test case result for Bug#42634
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        Add test case for Bug#42634
      sql/sql_class.cc:
        Don't pass the user query as a format string.
      df88c8e3
    • Sergey Glukhov's avatar
      Bug#42610 Dynamic plugin broken in 5.1.31 · 5d2a707d
      Sergey Glukhov authored
      added ignore-builtin-innodb option which disabled
      initialization of builtin InnoDB plugin
      
      mysql-test/r/innodb_ignore_builtin.result:
        test case
      mysql-test/t/innodb_ignore_builtin-master.opt:
        test case
      mysql-test/t/innodb_ignore_builtin.test:
        test case
      sql/mysql_priv.h:
        added ignore-builtin-innodb option which disabled
        initialization of builtin InnoDB plugin
      sql/mysqld.cc:
        added ignore-builtin-innodb option which disabled
        initialization of builtin InnoDB plugin
      sql/set_var.cc:
        added ignore-builtin-innodb option which disabled
        initialization of builtin InnoDB plugin
      sql/sql_plugin.cc:
        added ignore-builtin-innodb option which disabled
        initialization of builtin InnoDB plugin
      5d2a707d
    • Vladislav Vaintroub's avatar
      Bug#42427 : MTR v2 fails with "can't write to /tmp/mysql-test-ports.sem" on Windows · 3ff66087
      Vladislav Vaintroub authored
      - /tmp directory is not guaranteed to exist on Windows. 
      Use the value of environment variable TEMP here
      3ff66087
  5. 07 Feb, 2009 5 commits
  6. 06 Feb, 2009 6 commits
    • Joerg Bruehe's avatar
      Merge main 5.0 into 5.0-build · a3e94608
      Joerg Bruehe authored
      a3e94608
    • Joerg Bruehe's avatar
      Final merge of 5.0.72sp1 into 5.0-build · bfadc3d2
      Joerg Bruehe authored
      This involves just the tag, no file changes - they were all present before.
      bfadc3d2
    • Timothy Smith's avatar
      8ce69d9d
    • Tatiana A. Nurnberg's avatar
      auto-merge · 83f44d59
      Tatiana A. Nurnberg authored
      83f44d59
    • Tatiana A. Nurnberg's avatar
      Bug#42525: TIMEDIFF function · d7b158e7
      Tatiana A. Nurnberg authored
      In 37553 we declared longlong results for
      class Item_str_timefunc as per comments/docs,
      but didn't add a method for that. And the
      default just wasn't good enough for some
      cases.
      
      Changeset adds dedicated val_int() to class.
      
      mysql-test/r/func_sapdb.result:
        More tests for casts of TIME() / TIMEDIFF() with negative results.
      mysql-test/t/func_sapdb.test:
        More tests for casts of TIME() / TIMEDIFF() with negative results.
      sql/item_timefunc.h:
        Since we claim to provide longlong results, we should have
        a suitable function to provide them (the default won't do).
        This one matches the val_real() variant.
      d7b158e7
    • Mats Kindahl's avatar
      Bug #36763 · 2dc08879
      Mats Kindahl authored
      TRUNCATE TABLE fails to replicate when stmt-based binlogging is not supported.
      
      There were two separate problems with the code, both of which are fixed with
      this patch:
      
      1. An error was printed by InnoDB for TRUNCATE TABLE in statement mode when
         the in isolation levels READ COMMITTED and READ UNCOMMITTED since InnoDB
         does permit statement-based replication for DML statements. However,
         the TRUNCATE TABLE is not transactional, but is a DDL, and should therefore
         be allowed to be replicated as a statement.
      
      2. The statement was not logged in mixed mode because of the error above, but
         the error was not reported to the client.
      
      This patch fixes the problem by treating TRUNCATE TABLE a DDL, that is, it is
      always logged as a statement and not reporting an error from InnoDB for TRUNCATE
      TABLE.
      
      
      mysql-test/extra/binlog_tests/binlog_truncate.test:
        Adding new test to check that TRUNCATE TABLE is written correctly
        to the binary log.
      mysql-test/extra/rpl_tests/rpl_truncate.test:
        Removing redundant testing by eliminating settings of BINLOG_FORMAT.
      mysql-test/extra/rpl_tests/rpl_truncate_helper.test:
        Replacing slave and master reset code with include file.
        Removing settings of BINLOG_FORMAT.
        Replacing printing of table contents to compare master and slave
        with diff_tables.inc.
      mysql-test/suite/binlog/t/binlog_truncate_innodb.test:
        Adding test for testing that TRUNCATE TABLE is logged correctly for InnoDB
        in all isolation levels.
      mysql-test/suite/binlog/t/binlog_truncate_myisam.test:
        Adding test for testing that TRUNCATE TABLE is logged correctly for MyISAM.
      mysql-test/suite/binlog/t/disabled.def:
        Disabling binlog_truncate_innodb since it does not work (yet).
      sql/sql_base.cc:
        Correcting setting of capabilities flags to make the comparison with 0
        later in the code work correctly.
      sql/sql_delete.cc:
        Re-organizing code to ensure that TRUNCATE TABLE is logged in statement
        format and that row format is not used unless there are rows to log (which
        there are not when delete_all_rows() is called, so this has to be logged
        as a statement).
      2dc08879