1. 27 Dec, 2018 15 commits
  2. 26 Dec, 2018 1 commit
    • Teodor Mircea Ionita's avatar
      travis: upgrade Ubuntu target dist to 16.04 Xenial · 829fce9e
      Teodor Mircea Ionita authored
      Ubuntu 14.04 Trusty is LTS until April 2019 and since we are
      approaching that, upgrade to Xenial which is LTS until April 2021.
      
      One bonus of this upgrade is that the Travis Xenial virtual images
      have a much bigger disk size, thus no need to limit ccache below
      the default of 5G anymore.
      
      Also had to remove linux/clang-8 toolchain testing since
      llvm-toolchain-xenial is not listed at:
      https://github.com/travis-ci/apt-source-safelist/blob/master/ubuntu.json
      
      And fails with:
      Disallowing sources: llvm-toolchain-xenial
      ...
      E: Unable to locate package clang-8
      E: Unable to locate package llvm-8-dev
      829fce9e
  3. 25 Dec, 2018 4 commits
  4. 21 Dec, 2018 2 commits
    • Marko Mäkelä's avatar
      MDEV-18048: Relax a too strict debug assertion · a8eb0c76
      Marko Mäkelä authored
      This assertion should have been relaxed when implementing the first part of
      MDEV-15563: instant removal of NOT NULL attribute for ROW_FORMAT=REDUNDANT
      tables.
      
      For ROW_FORMAT=REDUNDANT, there is no bitmap of null columns;
      the null flags are encoded in the end offset of each field.
      We do not really care about the number of fields that can be NULL.
      a8eb0c76
    • Marko Mäkelä's avatar
      MDEV-18035 Failing assertion on DELETE · ccb1acbd
      Marko Mäkelä authored
      instant_alter_column_possible(): Do not allow instant removal of NOT NULL
      attribute from a column that belongs to the key of the clustered index.
      ccb1acbd
  5. 20 Dec, 2018 2 commits
  6. 18 Dec, 2018 8 commits
  7. 17 Dec, 2018 8 commits
    • Marko Mäkelä's avatar
      MDEV-12112: Support WITH_INNODB_BUG_ENDIAN_CRC32 · ed13a0d2
      Marko Mäkelä authored
      fil_space_verify_crypt_checksum(): Compute the bug-compatible variant
      of the CRC-32C checksum if the correct one does not match.
      ed13a0d2
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · fae7e350
      Marko Mäkelä authored
      fae7e350
    • Marko Mäkelä's avatar
      Fix a compiler warning · 51a1fc73
      Marko Mäkelä authored
      fil_space_verify_crypt_checksum(): Add a dummy return statement
      in case memory is corrupted and innodb_checksum_algorithm has
      an invalid value.
      51a1fc73
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · 7d245083
      Marko Mäkelä authored
      7d245083
    • Marko Mäkelä's avatar
      Follow-up to MDEV-12112: corruption in encrypted table may be overlooked · 8c43f963
      Marko Mäkelä authored
      The initial fix only covered a part of Mariabackup.
      This fix hardens InnoDB and XtraDB in a similar way, in order
      to reduce the probability of mistaking a corrupted encrypted page
      for a valid unencrypted one.
      
      This is based on work by Thirunarayanan Balathandayuthapani.
      
      fil_space_verify_crypt_checksum(): Assert that key_version!=0.
      Let the callers guarantee that. Now that we have this assertion,
      we also know that buf_page_is_zeroes() cannot hold.
      Also, remove all diagnostic output and related parameters,
      and let the relevant callers emit such messages.
      Last but not least, validate the post-encryption checksum
      according to the innodb_checksum_algorithm (only accepting
      one checksum for the strict variants), and no longer
      try to validate the page as if it was unencrypted.
      
      buf_page_is_zeroes(): Move to the compilation unit of the only callers,
      and declare static.
      
      xb_fil_cur_read(), buf_page_check_corrupt(): Add a condition before
      calling fil_space_verify_crypt_checksum(). This is a non-functional
      change.
      
      buf_dblwr_process(): Validate the page only as encrypted or unencrypted,
      but not both.
      8c43f963
    • Jan Lindström's avatar
      Merge pull request #1030 from tempesta-tech/sysprg/MDEV-17848 · 36b7f8f4
      Jan Lindström authored
      MDEV-17848: Galera test failure on galera_sst_xtrabackup-v2[_data_dir]
      36b7f8f4
    • Marko Mäkelä's avatar
      Fix USE_AFTER_FREE (CWE-416) · 10e01b56
      Marko Mäkelä authored
      A static analysis tool suggested that in the function
      row_merge_read_clustered_index(), ut_free(nonnull) could
      be invoked twice for nonnull!=NULL. While a manual review
      of the code disproved this, it should not hurt to clean up
      the code so that the static analysis tool will not complain.
      
      index_tuple_info_t::insert(), row_mtuple_cmp(): Remove the
      parameter mtr_committed, which duplicated !mtr->is_active().
      
      row_merge_read_clustered_index(): Initialize row_heap = NULL.
      Remove a duplicated call mem_heap_empty(row_heap) that was
      inadvertently added in commit cb1e76e4.
      
      Replace a "goto func_exit" with "break", to get consistent error
      handling for both failures to create or write a temporary file.
      
      end_of_index: Assign row_heap=NULL and nonnull=NULL to prevent
      double freeing.
      
      func_exit: Check for row_heap!=NULL before invoking mem_heap_free().
      
      Closes #959
      10e01b56
    • Jan Lindström's avatar
      Merge pull request #1026 from codership/10.1-galera-defaults · 517c59c5
      Jan Lindström authored
      Remove provider defaults check from 'galera_defaults' MTR test
      517c59c5