1. 09 Nov, 2010 8 commits
  2. 08 Nov, 2010 10 commits
  3. 07 Nov, 2010 3 commits
    • Dmitry Shulga's avatar
      11ebb5ba
    • Dmitry Shulga's avatar
      A fix and a test case for Bug#47924 -main.log_tables times out · 59c9bdf5
      Dmitry Shulga authored
      sporadically.
      
      The cause of the sporadic time out was a leaking protection
      against the global read lock, taken by the RENAME statement,
      and not released in case of an error occurred during RENAME.
      The leaking protection counter would lead to the value of
      protect_against_global_read never dropping to 0.
      Consequently FLUSH TABLES in all connections, including the
      one that leaked the protection, could not proceed.
       
      The fix is to ensure that all branchesin RENAME code properly
      release GRL protection.
      
      mysql-test/r/log_tables.result:
        Added results for test for bug#47924.
      mysql-test/t/log_tables.test:
        Added test for bug#47924.
      sql/sql_rename.cc:
        mysql_rename_tables() modified: replaced return from function
        to goto to clean up code block in case of error.
      59c9bdf5
    • He Zhenxing's avatar
  4. 06 Nov, 2010 1 commit
  5. 05 Nov, 2010 10 commits
  6. 04 Nov, 2010 6 commits
    • Jorgen Loland's avatar
      Bug#57882 - Item_func_conv_charset::val_str(String*): · df34c2c0
      Jorgen Loland authored
                  Assertion `fixed == 1' failed
      
      Followup patch. Test case relied on system variable that is
      only available if replication is compiled in. Replaced with
      variable available in all builds.
      
      mysql-test/r/errors.result:
        Test case relied on system variable that is only available if
        replication is compiled in. Replaced with variable available in
        all builds.
      mysql-test/t/errors.test:
        Test case relied on system variable that is only available if
        replication is compiled in. Replaced with variable available in
        all builds.
      df34c2c0
    • smenon's avatar
      merge · c40ad9f5
      smenon authored
      c40ad9f5
    • smenon's avatar
      Bug #57746: Win directory of source distribution - out-of-date files / support for new files · 2ad0c288
      smenon authored
      (win/README updated with some more changes)
      2ad0c288
    • Mats Kindahl's avatar
      BUG#57108: mysqld crashes when I attempt to install plugin · e8cbcf15
      Mats Kindahl authored
      If a relative path is supplied to option --defaults-file or
      --defaults-extra-file, the server will crash when executing
      an INSTALL PLUGIN command. The reason is that the defaults
      file is initially read relative the current working directory
      when the server is started, but when INSTALL PLUGIN is executed,
      the server has changed working directory to the data directory.
      Since there is no check that the call to my_load_defaults()
      inside mysql_install_plugin(), the subsequence call to
      free_defaults() will crash the server.
      
      This patch fixes the problem by:
      
      - Prepending the current working directory to the file name when
        a relative path is given to the --defaults-file or --defaults-
        extra-file option the first time my_load_defaults() is called,
        which is just after the server has started in main().
      
      - Adding a check of the return value of my_load_defaults() inside
        mysql_install_plugin() and aborting command (with an error) if
        an error is returned.
      
      - It also adds a check of the return value for load_defaults in
        lib_sql.cc for the embedded server since that was missing.
      
      To test that the relative files for the options --defaults-file and
      --defaults-extra-file is handled properly, mysql-test-run.pl is also
      changed to not add a --defaults-file option if one is provided in the
      tests *.opt file.
      e8cbcf15
    • Jorgen Loland's avatar
      Bug#57882 - Item_func_conv_charset::val_str(String*): · ca44833d
      Jorgen Loland authored
                  Assertion `fixed == 1' failed
      
      (also fixes duplicate bug 57515)
      
      agg_item_set_converter() (item.cc) handles conversion of 
      character sets by creating a new Item. fix_fields() is then 
      called on this newly created item. Prior to this patch, it was
      not checked whether fix_fields() was successful or not. Thus, 
      agg_item_set_converter() would return success even when an 
      error occured. This patch makes it return error (TRUE) if 
      fix_fields() fails.
      
      mysql-test/r/errors.result:
        Add test for BUG#57882
      mysql-test/t/errors.test:
        Add test for BUG#57882
      sql/item.cc:
        Make agg_item_set_converter() return with error if fix_fields() 
        on the newly created converted item fails.
      ca44833d
    • He Zhenxing's avatar
      BUG#47027 delegates_init() failure is not user friendly (usability issue) · 68980c3e
      He Zhenxing authored
            
      Function delegetas_init() did not report proper error messages
      when there are failures, which made it hard to know where the problem
      occurred.
      
      Fixed the problem by adding specific error message for every possible
      place that can fail. And since these failures are supposed to never
      happen, ask the user to report a bug if they happened.
      68980c3e
  7. 03 Nov, 2010 2 commits
    • Marc Alff's avatar
      Bug#57609 performance_schema does not work with lower_case_table_names · db9aeb42
      Marc Alff authored
      Before this fix, the performance schema tables were defined in UPPERCASE.
      
      This was incompatible with the lowercase_table_names option, and caused
      issues with the install / upgrade process, when changing the lower case
      table names setting *after* the install or upgrade.
      
      With this fix, all performance schema tables are exposed with lowercase names.
      As a result, the name of the performance schema table is always lowercase,
      no matter how / if / when the lowercase_table_names setting if changed.
      db9aeb42
    • Luis Soares's avatar
      BUG#57899: Certain reserved words should not be reserved · 54429e18
      Luis Soares authored
      In MySQL 5.5 the new reserved words include:
      SLOW                    as in FLUSH SLOW LOGS
      GENERAL                 as in FLUSH GENERAL LOGS
      IGNORE_SERVER_IDS       as in CHANGE MASTER ... IGNORE_SERVER_IDS
      MASTER_HEARTBEAT_PERIOD as in CHANGE MASTER ... MASTER_HEARTBEAT_PERIOD
      
      These are not reserved words in standard SQL, or in Oracle 11g,
      and as such, may affect existing applications.
      
      We fix this by adding the new words to the list of 
      keywords that are allowed for labels in SPs.
      
      mysql-test/t/keywords.test:
        Test case that checks that the target words can be used
        for naming fields in a table or as local routine variable
        names.
      54429e18