component/nodejs: enforce min gcc version

component/nodejs/buildout.cfg

@@ -16,6 +16,9 @@ parts =
 #<= nodejs-X.Y.Z
 
 # nodejs 16 needs gcc > 8.3
+[gcc]
+min_version = 8.3
+
 [nodejs-16.13.2]
 <= nodejs-base
 openssl_location = ${openssl:location}

[Jérome Perrin]

When introduced in 27cf29fc , there was this note in the commit message:

Also add a note for minimal supported version, that will have to be set in software

As far as I know, we do not have a convention about where to set these kind of constraints (for gcc or for the [versions] used for zc.recipe.egg), at the time I was thinking that a software is a collection of multiple components, that each component can have version constraints and only in the software we can know what's the minimal version for gcc. I still believe that this is that this is true that only in software we can know the final version, but this seems no problem to also set a version in component's buildout: It will be applied by default, we can override it in software and it's better than a comment in a file that will not be noticed.

[Jérome Perrin]

actually, maybe we have a convention and I missed it :) in https://lab.nexedi.com/nexedi/slapos/blob/756f8b32ba0380d28247493ae45450e12554dd60/component/kumo/buildout.cfg#L12-14 and some other places we are setting some version constraints.

[Thomas Gambier]

I had a ticket in slapos master because nodejs didn't compile on Debian 9 machine.

This is actually fixing the problem but indeed we may have a problem if several components with different min_version are used. We will see when the case arrise.