- 02 Sep, 2019 8 commits
-
-
Andrew Bonventre authored
Fixes #33954 Change-Id: Idfe71bf825adcd7cbf70cd139b3e779963394ff6 Reviewed-on: https://go-review.googlesource.com/c/go/+/192105 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Katie Hockman <katie@golang.org>
-
Ivan Trubach authored
These changes make cmd/doc -src deterministic, or, more precisely, go/ast.MergePackageFiles, which is used by cmd/doc. So far the order of comments depended on the package file map iteration order. cmd/doc with -src flag has been inserting and omitting random comments ever since the addition of -src flag. After investigating the code path with the debugger, I’ve noticed that ast.File.Comments slice order changes between invocations of the command. The bug was introduced in 3e24f2d6, which ironically claimed to “fix formatting of -src output”. The commit implemented the collection of comments by iterating over the map and c7cdce13 “godoc: make ?m=src mode deterministic” did’t actually make go/ast.MergePackageFiles deterministic. I’ve found this issue after running “go doc -src sync.WaitGroup.Wait”. There are likely other packages and functions affected, but the bug should be somewhat reproducible across all Go versions. Change-Id: Iae223e99550c0a3b54005c5cde36f909e655b66b GitHub-Last-Rev: c49532f79fcd7529d7ad1a369c467abc59d4df0a GitHub-Pull-Request: golang/go#33553 Reviewed-on: https://go-review.googlesource.com/c/go/+/189477 Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Robert Griesemer <gri@golang.org>
-
tomocy authored
Fixes #33743. Change-Id: I80621321d56b6cf312a86e272800f1ad03c5544c GitHub-Last-Rev: d91cb3697516ccfc3f956e97837404cbfee5922f GitHub-Pull-Request: golang/go#33856 Reviewed-on: https://go-review.googlesource.com/c/go/+/191879 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Emmanuel Odeke <emm.odeke@gmail.com>
-
Daniel Martí authored
Some were never used, and some haven't been used for years. One exception is net/http's readerAndCloser, which was only used in a test. Move it to a test file. While at it, remove a check in regexp that could never fire; the field is an uint32, so it can never be negative. Change-Id: Ia2200f6afa106bae4034045ea8233b452f38747b Reviewed-on: https://go-review.googlesource.com/c/go/+/192621 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
peter zhang authored
Change-Id: Ib637381ab8a12aeb798576b781e1b3c458ba812d GitHub-Last-Rev: 12994496b6b636d75564e5ae7e938b65bca526df GitHub-Pull-Request: golang/go#34017 Reviewed-on: https://go-review.googlesource.com/c/go/+/192877Reviewed-by:
Daniel Martí <mvdan@mvdan.cc>
-
spacewander authored
Fixes #33385 Change-Id: I497ccd868d408a9c5648c72aa5ce41221368daf4 GitHub-Last-Rev: 3bf483808e10a13c522df02c2fc55fe278044680 GitHub-Pull-Request: golang/go#33423 Reviewed-on: https://go-review.googlesource.com/c/go/+/188677Reviewed-by:
-
itchyny authored
scanEnd is delayed one byte so we decrement the scanner bytes count by 1 to ensure that this value is correct in the next call of Decode. Fixes #32399 Change-Id: I8c8698e7f95bbcf0373aceaa05319819eae9d86f GitHub-Last-Rev: 0ac25d8de23d38c7ac577faddc6983571023f561 GitHub-Pull-Request: golang/go#32598 Reviewed-on: https://go-review.googlesource.com/c/go/+/182117Reviewed-by:
-
Derek Phan authored
The URL port is already checked in net/url, so we can remove the redundant validation in net/http. Fixes #33600 Change-Id: I62511a452df6262d4b66180933758d34627ff9df GitHub-Last-Rev: c19afa31025fee68ba0601bb75e9e20e09a36822 GitHub-Pull-Request: golang/go#33611 Reviewed-on: https://go-review.googlesource.com/c/go/+/190057 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 01 Sep, 2019 10 commits
-
-
LE Manh Cuong authored
CL 187979 added set .dynsym info field, but it won't when there are no global symbols. This CL sets that field unconditionally. Fixes #34000 Change-Id: Icc2f8bc74afdade88a377793e6760912b03686ba Reviewed-on: https://go-review.googlesource.com/c/go/+/192600 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Tom Thorogood authored
This partly reverts CL 173417 as it incorrectly documented that Compact performed HTML escaping and the output was safe to embed inside HTML <script> tags. This has never been true. Although Compact does escape U+2028 and U+2029, it doesn't escape <, > or &. Compact is thus only performing a subset of HTML escaping and it's output is not safe to embed inside HTML <script> tags. A more complete fix would be for Compact to either never perform any HTML escaping, as it was prior to CL 10883045, or to actually perform the same HTML escaping as HTMLEscape. Neither change is likely safe enough for go1.13. Updates #30357 Change-Id: I912f0fe9611097d988048b28228c4a5b985080ba GitHub-Last-Rev: aebababc9233c5705785b225377e80096d4bb8c4 GitHub-Pull-Request: golang/go#33427 Reviewed-on: https://go-review.googlesource.com/c/go/+/188717Reviewed-by:
-
William Poussier authored
This change adds a a check in the encodeWithString.resolve method to ensure that a reflect.Value with kind Ptr is not nil before the type assertion to TextMarshaler. If the value is nil, the method returns a nil error, and the map key encodes to an empty string. Fixes #33675 Change-Id: I0a04cf690ae67006f6a9c5f8cbb4cc99d236bca8 GitHub-Last-Rev: 6c987c90846f854e21814dbfb3a073605ec8a94c GitHub-Pull-Request: golang/go#33700 Reviewed-on: https://go-review.googlesource.com/c/go/+/190697 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Alex Gaynor authored
Change-Id: I17148bb2b8021ed305ed0d230675d51c41736a11 GitHub-Last-Rev: 2998d46d10587a850fb36f5784df23b371244479 GitHub-Pull-Request: golang/go#34004 Reviewed-on: https://go-review.googlesource.com/c/go/+/192797Reviewed-by:
Ingo Oeser <nightlyone@googlemail.com> Reviewed-by:
Andrew Bonventre <andybons@golang.org>
-
Alberto Donizetti authored
For performance reasons (avoiding costly cross-compilations) CL 177577 changed the codegen test harness to only run the tests for the machine's GOARCH by default. This change updates the codegen README accordingly, explaining what all.bash does run by default and how to perform the tests for all architectures. Fixes #33924 Change-Id: I43328d878c3e449ebfda46f7e69963a44a511d40 Reviewed-on: https://go-review.googlesource.com/c/go/+/192619Reviewed-by:
-
Daniel Martí authored
Just the low-hanging fruit; code that was either never used, or its last use was removed a while ago. Change-Id: Ic7f90aeee3e6daf7edc16cde3c0a767d67e617ee Reviewed-on: https://go-review.googlesource.com/c/go/+/192618 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Andrew Bonventre authored
application/javascript is being deprecated per https://datatracker.ietf.org/doc/draft-ietf-dispatch-javascript-mjs/ Specify a charset to be consistent with other text/* mime types. Fixes #32351 Change-Id: I7300f6cfdbcf574103764991cb75172a252a3400 Reviewed-on: https://go-review.googlesource.com/c/go/+/186927 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Irbe Krumina authored
At the moment the last output line of ExampleSplit- two empty strings- are being trimmed from the output. I have formatted the output of the function to avoid whitespace trimming and show empty strings more clearly. Fixes #23542 Change-Id: Ic2a4d98cfa06db1466c6c6d98099542df9e7c88b Reviewed-on: https://go-review.googlesource.com/c/go/+/191397 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Rob Pike <r@golang.org> Reviewed-by:
-
jsign authored
*os.File already does it. Fixes #33064 Change-Id: I3edf0a31bf6d6e5023f47f01ebc92ed057357278 GitHub-Last-Rev: e6a5ba45d7e74def668adf145f46387ef27f5d28 GitHub-Pull-Request: golang/go#33065 Reviewed-on: https://go-review.googlesource.com/c/go/+/185857Reviewed-by:
-
Ou Changkun authored
This CL removes an outdated comment regarding converting a pointer to `uintptr`. The comment was introduced in Go 1.4 and runtime GC was under the consideration of major revisions. According to the current situation, Go runtime memory allocator has no fragmentation issue. Therefore compact GC won't be implemented in the near future. Change-Id: I5c336d81d810cf57b76797f05428421bb39a5b9f GitHub-Last-Rev: 2ab4be3885d3f48abbcb59af3f74bc95501ff23f GitHub-Pull-Request: golang/go#33685 Reviewed-on: https://go-review.googlesource.com/c/go/+/190520Reviewed-by:
Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 31 Aug, 2019 9 commits
-
-
Brian Kessler authored
wasm has 32-bit versions of all integer operations. This change lowers RotateLeft32 to i32.rotl on wasm and intrinsifies the math/bits call. Benchmarking on amd64 under node.js this is ~25% faster. node v10.15.3/amd64 name old time/op new time/op delta RotateLeft 8.37ns ± 1% 8.28ns ± 0% -1.05% (p=0.029 n=4+4) RotateLeft8 11.9ns ± 1% 11.8ns ± 0% ~ (p=0.167 n=5+5) RotateLeft16 11.8ns ± 0% 11.8ns ± 0% ~ (all equal) RotateLeft32 11.9ns ± 1% 8.7ns ± 0% -26.32% (p=0.008 n=5+5) RotateLeft64 8.31ns ± 1% 8.43ns ± 2% ~ (p=0.063 n=5+5) Updates #31265 Change-Id: I5b8e155978faeea536c4f6427ac9564d2f096a46 Reviewed-on: https://go-review.googlesource.com/c/go/+/182359 Run-TryBot: Brian Kessler <brian.m.kessler@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Richard Musiol <neelance@gmail.com>
-
LE Manh Cuong authored
.dynsym section info field is the index of first non-local symbol, mean the number of local symbols. The go linker have never ever set it before, so just set it. Fixes #33358 Change-Id: Ifde2deb7c15471b04d565861f5d81daffb0c0d3d Reviewed-on: https://go-review.googlesource.com/c/go/+/187979 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Jason A. Donenfeld authored
Previously users who opted into cgo might have received a bit of a behavior surprise when their mingw installation defaulted to a potentially older and different set of compatibility hacks. Since Go is explicitly targeting >=6.1 for internal linkage, propagate these changes to external linkage too. While we're at it, we move these values into constant variables so that they don't become out of sync and allow for easy updating as Go gradually drops compatibility for older operating systems. Change-Id: I41e654d135be6e3db9088e73efeb414933e36caa Reviewed-on: https://go-review.googlesource.com/c/go/+/191842Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
Jason A. Donenfeld authored
This has been the default in MSVC for a very long time, and it's hard to imagine modern programs actually wanting the old legacy behavior. For example, no modern programs try to install their junk into C:\windows and therefore need to have an emulated writable windows directory. That's not really even allowed by ACLs on modern systems. Change-Id: Iadaca6815e39ea5c6b05c1cac5a95cfc35e5b48a Reviewed-on: https://go-review.googlesource.com/c/go/+/191840 Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Elias Naur authored
macOS and iOS deliver SIGPIPE signals to the main thread and not the thread that raised it by writing to a closed socket or pipe. SIGPIPE signals can be suppressed for sockets with the SO_NOSIGPIPE option, but there is no similar option for pipes. We have no other choice but to never forward SIGPIPE on macOS. This is a fixup of reverted CL 188297. Fixes #33384 Change-Id: I09b258b078857ad3b22025bc2902d1b12d2afd92 Reviewed-on: https://go-review.googlesource.com/c/go/+/191785 Run-TryBot: Elias Naur <mail@eliasnaur.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
OlgaVlPetrova authored
Change-Id: I366b89e35d194ca2a7eb97a8253497bd3fc2af94 Reviewed-on: https://go-review.googlesource.com/c/go/+/142019 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Eli Bendersky authored
When a test has a TestMain that doesn't run any tests (doesn't invoke m.Run), `go test` passes, but `go test -json` reports a "fail" event though the exit code is still 0. This CL fixes test2json to behave similarly to `go test` in such cases - no output from the test is taken as "pass" by default, not as "fail". Fixes #31969 Change-Id: I1829d40fc30dc2879e73974fac416f6a34212ccd Reviewed-on: https://go-review.googlesource.com/c/go/+/192104 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Emmanuel Odeke authored
Updates #32326. Updates #33953. Change-Id: I97a1cbe682becfe9592e19294d4d94f5e5b16c21 Reviewed-on: https://go-review.googlesource.com/c/go/+/192342 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Simon Ferquel authored
If Go DLL is used by external C program, and lastcontinuehandler is reached, lastcontinuehandler will crash the process it is running in. But it should not be up to Go runtime to decide if process to be crashed or not - it should be up to C runtime. This CL adjusts lastcontinuehandler to not to crash when running as DLL. Fixes #32648. Change-Id: Ia455e69b8dde2a6f42f06b90e8af4aa322ca269a GitHub-Last-Rev: dbdffcb43206e94ef130ecadd1c82a8763225ac2 GitHub-Pull-Request: golang/go#32574 Reviewed-on: https://go-review.googlesource.com/c/go/+/181839 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 30 Aug, 2019 13 commits
-
-
Ben Shi authored
This CL eliminates unnecessary pairs of I32WrapI64 and I64ExtendI32U generated by the WASM backend for IF statements. And it makes the total size of pkg/js_wasm/ decreases about 490KB. Change-Id: I16b0abb686c4e30d5624323166ec2d0ec57dbe2d Reviewed-on: https://go-review.googlesource.com/c/go/+/191758 Run-TryBot: Ben Shi <powerman1st@163.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Cherry Zhang authored
runtime/asm.s contains two variable declarations that don't seem needed. The variables are defined in Go and not referenced in assembly. They were added in 2014 during the C to Go transition. Maybe they were useful at that time, but not now. Remove them. Change-Id: Id00d724813d18db47126c2f2b8cacfc9d77ffd4b Reviewed-on: https://go-review.googlesource.com/c/go/+/192378 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Austin Clements <austin@google.com>
-
David Chase authored
helpful for debugging failures to figure out which lines disappeared to cause the failure. Change-Id: Id42b64a65f76eed47e01003f05346bc09cec27e8 Reviewed-on: https://go-review.googlesource.com/c/go/+/188019 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Jeremy Faller <jeremy@golang.org>
-
micnncim authored
Removed repetitions of "the" in some comments. Change-Id: I36a6f51609765076de32e1b97398c4c08743aafc GitHub-Last-Rev: 4d06aea6a787cfca40eda10845897ff149fff62c GitHub-Pull-Request: golang/go#33797 Reviewed-on: https://go-review.googlesource.com/c/go/+/191497Reviewed-by:
-
Ben Shi authored
This CL reverts CL 192097 and fixes the issue in CL 189277. Change-Id: Icd271262e1f5019a8e01c91f91c12c1261eeb02b Reviewed-on: https://go-review.googlesource.com/c/go/+/192519 Run-TryBot: Ben Shi <powerman1st@163.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
zdjones authored
The partially ordered set uses a method named 'dominates' to determine whether two nodes are partially ordered. Dominates does a depth-first search of the DAG, beginning at the source node, and returns true as soon as it finds a path to the target node. In the context of the forest-of-DAGs that makes up the poset, dominates is not necessarily checking dominance, but is checking reachability. See the issue tracker for a more detailed discussion of the difference. Fortunately, reachability is logically correct everywhere dominates is currently used in poset.go. Reachability within a DAG is sufficient to establish the partial ordering (source < target). This CL changes the name of the method (dominates -> reaches) and updates all the comments in the file accordingly. Fixes #33971. Change-Id: Ia3a34f7b14b363801d75b05099cfc686035f7d96 Reviewed-on: https://go-review.googlesource.com/c/go/+/192617Reviewed-by:
Giovanni Bajo <rasky@develer.com> Run-TryBot: Giovanni Bajo <rasky@develer.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Rhys Hiltner authored
Only call "go list" when explicitly listing packages. An empty coverage profile references no packages, and would otherwise lead to "go list" implicitly looking at the package in "." (which might not exist). Fixes #33855 Change-Id: I02d4e374405d86f03d105fe14648aa03b4d2284c Reviewed-on: https://go-review.googlesource.com/c/go/+/192340Reviewed-by:
Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Clément Chigot authored
Change-Id: I92173c3b5f842b829aac7c4d7abbe8b5113e530a Reviewed-on: https://go-review.googlesource.com/c/go/+/191787 Run-TryBot: Clément Chigot <clement.chigot@atos.net> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Tobias Klauser <tobias.klauser@gmail.com>
-
Jason A. Donenfeld authored
Starting in Windows 8, the wait functions don't take into account suspend time, even though the monotonic counters do. This results in timer buckets stalling on resume. Therefore, this commit makes it so that on resume, we return from the wait functions and recalculate the amount of time left to wait. Fixes: #31528 Change-Id: I0db02cc72188cb620954e87a0180e0a3c83f4a56 Reviewed-on: https://go-review.googlesource.com/c/go/+/191957 Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ben Shi authored
Update cmd/compile/internal/ssa/gen/README, suggest using go-1.13 and above for rulegen. Change-Id: I5256d6f1bb4273b5eb7d5122a4364add52fc42c6 Reviewed-on: https://go-review.googlesource.com/c/go/+/192517Reviewed-by:
-
Tobias Klauser authored
This fixes TestFormats after CL 192278. Change-Id: I7ffb8f76b4f6469d1b161d41687306e0d9e7abd1 Reviewed-on: https://go-review.googlesource.com/c/go/+/191786 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by:
-
Keith Randall authored
Raising an out-of-bounds panic is confusing. There's no indication that the underlying problem is a race. The runtime already does a pretty good job of detecting this kind of race (modification while iterating). We might as well just reorganize a bit to avoid the out-of-bounds panic. Fixes #33275 Change-Id: Icdd337ad2eb3c84f999db0850ec1d2ff2c146b6e Reviewed-on: https://go-review.googlesource.com/c/go/+/191197Reviewed-by:
Martin Möhrmann <moehrmann@google.com>
-
Keith Randall authored
Fixes #33960 Change-Id: I4f8cf65dcf4140a97e7b368572b31c171c453316 Reviewed-on: https://go-review.googlesource.com/c/go/+/192498 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
